From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id ADFA4199AE for ; Tue, 19 Sep 2017 19:01:02 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id o42so197243wrb.3 for ; Tue, 19 Sep 2017 10:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Cypl78I+2t2jAMZPP2f5lo/zHcIH55kr/El+lrs4eqw=; b=BYjgAqZJ3usKiXnMsr6GQl19YtQiQHPuR9x3OucBAeoDnuxbq32fbtm/fRqwfQzw5P qYqjM6Cco08vDdGl4xsMO2U8i4S3hTE0HArRePBB8B4cw6nyKkx6BNAnJ+WPqhSPPOpF mKMvr/qEngoK7pu1zvC/6wZCq471hHSAqiUOCKB9Hq6H20hW8yvNEf4BO2I74NpQtDUR zsaF6PPGTWYmRt5DYv5sWNhHH9SazMvsL8/1+Ob/MKP+APGVrFLP0jtOEyeBta5RAoAz i/y1+iNmQhEyD7Ed9Ps1Fu7FHpUon38DsOHUAhZivWb0Ak3FAUunuo1rczWsNqLd+nfG OAmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cypl78I+2t2jAMZPP2f5lo/zHcIH55kr/El+lrs4eqw=; b=NTAoJeG0DnIaL8hg0p5EaRvwbTEkNpNCM7moW4gZkEzNEwL6PuwFvTfY8XmkPVRbqr VkjHKYiZ+LR/QaTjSAznc3F1pCfN992JR46tNS+icZt+i/fRWVTdLDc+W9YEeyhxigTP oCx2siAFx3lw+CSEasbcz2O3aZZS/DNdhFAQW40DggvK2zH/YqcZrc+HaD7KZNoo8p9a 5ZAuh6ZDbNSNdUsnFUqg9Mp9BNsE9KR8C65aTBfo6WbWHuoCix1f0P85Kx34GcpduBaT umTrRHyOhwWu+i8/aCMHX59k4RlqfZemW6JdRFTi2QeU1Bsg0buUgiiaX9rRNw+xWgj3 +eTw== X-Gm-Message-State: AHPjjUi/NoEJRjxzHWInI+TPW84Uorjz4XEvidmiiLPNRXVRSwrinsj5 xLI1mFH/C8CLcsBo2J2PWqJhxw== X-Google-Smtp-Source: AOwi7QDKMrvz8nj017QpblHtkAiTgI5/CG4HPw93A2b+m2Xc5/wlJONflFIwv5AA61bjunJWHGpy9w== X-Received: by 10.223.164.13 with SMTP id d13mr2170641wra.48.1505840462455; Tue, 19 Sep 2017 10:01:02 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 55sm12783734wrw.60.2017.09.19.10.01.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2017 10:01:01 -0700 (PDT) Date: Tue, 19 Sep 2017 19:00:51 +0200 From: Adrien Mazarguil To: "Dumitrescu, Cristian" Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" Message-ID: <20170919170051.GP2481@6wind.com> References: <1496162653-137817-3-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-1-git-send-email-cristian.dumitrescu@intel.com> <1503705973-80742-4-git-send-email-cristian.dumitrescu@intel.com> <20170906162302.GD4301@6wind.com> <3EB4FA525960D640B5BDFFD6A3D891267BABC13D@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891267BABC13D@IRSMSX108.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 17:01:02 -0000 Hi Cristian, On Tue, Sep 19, 2017 at 04:36:50PM +0000, Dumitrescu, Cristian wrote: > > > /** > > > + * RTE_FLOW_ACTION_TYPE_METER > > > + * > > > + * Traffic metering and policing (MTR). > > > + * > > > + * Packets matched by items of this type can be either dropped or passed > > to the > > > + * next item with their color set by the MTR object. > > > + * > > > + * Non-terminating by default. > > > + */ > > > +struct rte_flow_action_meter { > > > + uint32_t mtr_id; /**< MTR object ID created with rte_mtr_create(). > > */ > > > +}; > > > + > > > > Default mask definition is missing. > > > > I do not understand this comment. This is a flow action, not a flow item (that might be a packet field with an associated mask); this mtr_id is similar to queue ID/index/VF ID from other flow actions, none having any mask attached. Adrien, can you please clarify? Yes, I actually misread it as a pattern item definition for some reason. Nothing to see here, move along! > > > > +/** > > > * Definition of a single action. > > > * > > > * A list of actions is terminated by a END action. > > > -- > > > 2.7.4 > > > > > > > Even if MTR is a separate API, please add to this commit: > > > > - Documentation update: guides/prog_guide/rte_flow.rst > > - Testpmd update: app/test-pmd/cmdline_flow.c > > - Testpmd documentation update: > > doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > > You can find examples in previous commits related to rte_flow. > > > > All of these items are a must and will get done, but do they have to be done in the same patch set? That'd be much better as far as I'm involved in this review (rte_flow changes). You should put them in the same patch as the above. > My plan was to introduce test-pmd updates through separate patch sets after the API is accepted. I know you had these items done in the same patch set for rte_flow, but there are other APIs such as eventdev and ethdev traffic management which introduced sample app one release later. In that case, could you split these changes in two parts? This patch could bring the basic MTR action support in testpmd, by this I mean the ability to type a flow command with such an action and not get rejected with a "bad arguments" error since it is actually part of the API, even if nothing is connected to that action at this point. The rule should however get rejected by its lack of support in the underlying PMD. Same idea for rte_flow and testpmd documentation update, this patch only needs the minimum amount describing what this action is without a link to the actual MTR documentation, which is not present at this point. Subsequent commits shall update these as they complete the MTR API. -- Adrien Mazarguil 6WIND