From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 7AD5A6D45 for ; Thu, 21 Sep 2017 05:33:37 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id d187so2562607pfg.11 for ; Wed, 20 Sep 2017 20:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=47yxGQthJmqiB+ElBmjoOoJRtq/Bn/E7hVjq54D5rMk=; b=waZBMgFEBJ/WBa6gZgjP1AywtBHf6QdHytKkZxZUz8Rk9rU7IkxN/QvYOIxNwmPRNQ 8jGU4B3Db07X5DSFneGLgzU//MnCmjviaRXyAT7xWDK+dLF2DnEOqQetocl3rxyxqs4m v2FgnMrJPtiT1yXYLm5xBfK7khpSvem3g4mkuQmAeQ1+BoNNmy1LoRoMdpik5UD+JGXa eIkJmEyq2T5x9rgyOSUtkKk5LNxkuvSDzTZlf7U1g6O5d4UUYlRYtPOPY2ywKeu/ke7f m3kLqOIk/fA5uNV9SFY6GjR+Razs0B4x8vcFPJ2gviz3KKBoNWabEmKNrTvL++5f83HR ptyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=47yxGQthJmqiB+ElBmjoOoJRtq/Bn/E7hVjq54D5rMk=; b=if9dlan3T6VFcNvAtig0mMXIo/USchx2Lr5noM+WiFF39tL6HkrzSb7Yli0bi7ZGrA yuKxCUCo1/RbWNnKBRRsPTDV6fdXKqg4pWkaGR5fKI97hyKaMwspngz8P8aqUwxy98cb WjVvvFeN2S5iayPcoWgGaJkXwMfUrZ19kR2boZfalW8U/27cMPOmSk/sA21+Iol9w9ew f75AODGLz8Fu//Glnb6a1+EjGQcXhMo5f5pgvY5zotI8StA2ynfhVPiR1+KM7muOAruq kUok8FeE/+URTLHwau4rINQVQT49IgIZo13uHc/6slt5G/F6AzkMlumbtKZPRjUebPU6 BJIw== X-Gm-Message-State: AHPjjUjpMs61ihZhIf64f+Vn6ar8dZViVbqgHTOucg60mG58E6ri9bEp wSeU+JJNQFqj1z87Juq9RIMx3g== X-Google-Smtp-Source: AOwi7QDLqO0RE42OtvWcPE9Tn8H9tN1/DcXyQFIOKFs3jeiq6F9UJXlGwJe1egsgp7HOxSF9Pb9RTQ== X-Received: by 10.159.218.7 with SMTP id v7mr4251225plp.322.1505964816656; Wed, 20 Sep 2017 20:33:36 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id m190sm509461pga.2.2017.09.20.20.33.33 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 20:33:35 -0700 (PDT) Date: Thu, 21 Sep 2017 11:33:25 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Message-ID: <20170921033323.GA2251@yliu-home> References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-11-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503654052-84730-11-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 03:33:37 -0000 Firstly, very sorry for so late review! On Fri, Aug 25, 2017 at 09:40:50AM +0000, Jianfeng Tan wrote: > To support kick in secondary process, we propose callfd_pri and > kickfd_pri to store the value in primary process; and by a new > API, rte_vhost_set_vring_effective_fd(), we can set effective > callfd and kickfd which can be used by secondary process. > > Note in this case, either primary process or the secondary process > can kick the frontend; that is, they cannot kick a vring at the > same time. Since only one can work, why not just overwriting the fd? Say, you could introudce some APIs like "rte_vhost_set_vring_callfd", then you don't need to introduce few more fields like "callfd_pri". --yliu