From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0052.outbound.protection.outlook.com [104.47.34.52]) by dpdk.org (Postfix) with ESMTP id 7E10C1B194 for ; Thu, 21 Sep 2017 12:04:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SRmQPOL86QswOXCPp/kYBSTL1VdtwBnKa9HVuDse5V0=; b=IFzhR2OnYHJVqkpCSxhneFyNxuezJIeonnqGGTwhVJ6PCUiAYUTFfMFn2+UIsHVGNMyCSdpi9JOpp+Ncf0kvtiRsJZ8Qlufx1TfdVvaZeShKpHUIOaDj9e28gzMFziin+pGuqf0tmFMgRupfW62DLkUsIkVxB/mNUnUY3P/UnpU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (111.93.218.67) by DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Thu, 21 Sep 2017 10:04:07 +0000 Date: Thu, 21 Sep 2017 15:33:42 +0530 From: Pavan Nikhilesh Bhagavatula To: "Van Haaren, Harry" , thomas@monjalon.net Cc: dev@dpdk.org Message-ID: <20170921100341.GA20451@PBHAGAVATULA-LT> References: <1503501027-11046-1-git-send-email-pbhagavatula@caviumnetworks.com> <1505984291-18702-1-git-send-email-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0111.INDPRD01.PROD.OUTLOOK.COM (10.174.208.27) To DM5PR07MB3467.namprd07.prod.outlook.com (10.164.153.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 377e6410-7a40-4b2e-56f4-08d500d819df X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 3:fGTnz/n+DyKPFlFDlFol57mceqzRisWaiYXkNFS8qAj+PTRT6Yu8NIUAE4auOFcj4mzBm6UOmVOrIQ8Q9ZkAGZNR73oLcRoIEQygjd3SYL/E212IljB+lsNVTV5PW1Uy/gRg6AZP9d0gb4hRExy9hXMA9E0QWWgC5yQ8786/y485fbXLpjqMnlmiLu112UqY5s+eqf4TZkDWZ/CAYSQq8++NZXT4rxhki4wc510Y5me/9wfOssfOEGjlQvYJHa/D; 25:njEr7REGvhAP6sZQCVhuRGpFDzGXyIApGMpk5zwWMY1EhXBbP+X7wYfc4DY+RlTZDmxXzXvVztvDlMEg95hBl+tnz4HWboOHk9cXjn0AnM5Ziw1mYZY6jYzQCrsVzpsduzXqO+C5kwDmVsrviF5fEWk9bbmm/m0cM/Sdqh7duhZ2ez+8UV1QVFWy1y2oxdT4mTH5NPQSy/VYFZdRZtf/mCYObtxWJmP9BuiXQuZJJYaJ+vc5t7RTwRBjbTO24ZXYGkdoUVwQ45pX1xocqYFBxrZlwmzsQ9rUjI4Ufnn0UHxozS0ZDt6Uscmj5H9oXaRfIAX/RrRactlbUfUD5DXuOw==; 31:ywz+3ALW7zwL+kPTME8slYxYdPEWDp0UrTDRTQTRGgk4QUfl6S7QoimEfiNG2/y5cekhpeZvAvR28nDxmVyOeYSmlTHprad7PByHKaGq03d+ZbZ6uq2HfsefUDE0MQs0pHpgQpugrqn/lJCb4Lt1yjQ7qEyb4DhXREiJcB87B6d1Bblgo3e5JA1w01DYaBFrJoEcV/oFj0E2aOfJtD61jmEO98kAhFgvM2pt9HnAMLs= X-MS-TrafficTypeDiagnostic: DM5PR07MB3467: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 20:l7OjHS9R+FujFmA2TGQEj2Bdof3+CM95ai/E907hzgSUieYxBYs2HF6l9kfNegS/JBsRZ7isRugwluTVxDI7CN9xXGkw0aIdnFpUxXSTzkf6PdJeqU65XRLQRHAp5jerpKfD8Kq71kpM3hv5GrzoEArJXUcPC0U8U+fVO8oXxuFFa2v6BqEpFAAZIctRyPIkpP9ebjUGCsOeL9dNhx+6yuJvKLU6s0eq6vMSFs4oJN82/uYpX+WHwJpZnXdDvxyblH/lGLIcAKiPHHi4GXzh3UIDHp21pMAXjrnw9XWYwlgcGVDWUOKKkr91YblZCtkieiWDx6tkfukq/ypRoOZDiTSKoL21gMlr46pyHsgEwYtQ2JdjGtzelqf/++VlaPm4vmKaZI/rke1FPFtJLaFPnb2uy04c1cLdtX3rb/42l/Ljjhw9OHc/6yMU+cXsbiWZl2444Hpq8JCI7gNIweufYPDDFfq4nVq+pShuMwjfyKxLycrfuybWXpQkXWuAp4nfd2Xoak5Uu9szLSb6RmyvhKARJQ0fRLQ5KMFQ/t+u+2Nky+tmIVl6yy3k3Kbdbb31XKQrJO9kJ4ZLrSPrzQhBWPIU79+kZhJ+ED5oF1xP3G8= X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3467; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 4:2g09G8wIc5lKFTFeeSEJhxkpET3Wx3CR+UbUtH2LvE/5srnp9AHjDzGePLJtC7EUgsCpTZD14jlHInODrfWZBfKyhlv9DIqz4tTV+k3TSweGXR+yHkeXCnv/dMQIRHa6YwfsVCzurIgjq9Ze114ONwWDlrBVDtLCZWtB69gf2QnT/FJPmK4C8hyj5gQPG5MvTGkv2kj74np7zJnOHMekB9L8vZzR3pk9CQT3iMdldbyPL/YlDMRHX11qOK5cR2HA35E6zq02q4IVMb0obOOmCedYeRwb9+B9L31ZVR91tA9jwAwiIJvjnnvZSDdT8egQbhhU/fMqbK9ZCIUZZqe0mQ== X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(377454003)(24454002)(199003)(189002)(16586007)(478600001)(2906002)(50466002)(33656002)(16526017)(229853002)(2950100002)(42882006)(5660300001)(68736007)(5009440100003)(83506001)(72206003)(575784001)(23726003)(53546010)(1076002)(3846002)(6116002)(6666003)(105586002)(58126008)(106356001)(101416001)(33716001)(76176999)(7736002)(97736004)(8936002)(81156014)(25786009)(81166006)(54356999)(8676002)(305945005)(50986999)(55016002)(53936002)(9686003)(47776003)(66066001)(6496005)(6246003)(316002)(4326008)(189998001)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3467; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3467; 23:N8CIXmrLbPEWaGStuEY2xnJBcfs9qJ878+7dCv2H+?= =?us-ascii?Q?151UzDYQ1DzMz4VTYkWB2FVuEvrdTl20aG/BlBGUvWLlmF6f7T/fJx4rKi7Q?= =?us-ascii?Q?2NSbbyduUpLLSJyBn0RYjJqZxMPqQBkubnSmYXFgn69n/g33igK+VKtgZX1n?= =?us-ascii?Q?ly3drkAl9W8ViFzG2v337bZDptMfGmUJroC84wf1bNy8o5EQZdkfOgp0vgLn?= =?us-ascii?Q?KszoY2dO/lJplh9dW3c27TzzMtUvBlkh4xRTglmwdpYjiqM6l4uyQ8wOSX0G?= =?us-ascii?Q?aibZx7VYlTMmPyiEMpcw6HB4YdYNFoKhLfEaTWGITkhmsNQOpN0AGzKWLbs0?= =?us-ascii?Q?8R+dXsdjudzYfUBXDDAD8txcS7SiJzaChPb3PIvHD6letw8Mmk3uMXtYqx89?= =?us-ascii?Q?pMQ1PL7uAX3NsdPxh6woUeQnf1jpUufziRKvT6G/dF8T7HYw7tPd37crr3Sn?= =?us-ascii?Q?tE38LhJO3nEbcVF4C/ZPW4kwIYQIls8QF4KtZ37wjzjQeBNENal4VdgP9bdD?= =?us-ascii?Q?pYdOSw6UOGhIKYmgwJ45JyVNd5a/NbZOvl7F1juzMjfPP0QHE3g0mYTzcM9s?= =?us-ascii?Q?zZyc3rEH9+S14w16zSBDyTx2vyZMldaxcutIhAMTkjjP5DfBnIXo06bnaXcJ?= =?us-ascii?Q?xNV40Q6OVGmDNSgVZPv9ZcaJwPgLuAqxS8rOEDnFapmrQRy1lDd8upBt2RGB?= =?us-ascii?Q?jIXfqdrSl8fVm+SKhLbWV9WTwebquD2YNL0jpe3R7qrTfEYmyq76lrk8lgBl?= =?us-ascii?Q?E1u72K700Bcr98xzEwg30Oz56YXldUpPlC+q2g1vfHZLKoOMy/oeU0M6V3x8?= =?us-ascii?Q?ABoirK9o7odBwcUFE2jLBcG0nJZE4cVJLU6ZkBZpitOseos3YW5TjNvIlqJ8?= =?us-ascii?Q?N7tjUELfUrGR9iHBDhxyWwnwIVofMa9VecZTH77pqWrbE6UCjhzlHkHm+xKb?= =?us-ascii?Q?8XdbF3raaRXobx6SWYABFGxZDsHQAbjYS8hb5ZYVjJWqZoI4nlFG14JmUbqz?= =?us-ascii?Q?Jgi6YfwUqfMJxZExAAzOAMpgEvE4DO8rHz+FqEivQBw0PwFyqC0WOLQx2wbE?= =?us-ascii?Q?PIx1c+utc6oZitksjs0UDcv8rKuGtxFmpWPmKTZbIryvNXAEEYPflEMcsQ/B?= =?us-ascii?Q?c18WXwxd/p21f6eq6Jv/6zBAGNpDSMjPkz2IkdoHcoMvEVdMgAzTEmVKqWYK?= =?us-ascii?Q?8fhwJqI1ziKq3kMEEms/NIFb2uf+CMROEt4yn/H1q5KHsDWi6oBYUNlQ1fN8?= =?us-ascii?Q?kBKX6LX63yfucoXJgT25dj/KJy6w57s5/n7NoSceEfdh/mEJRRRfx422wGMK?= =?us-ascii?Q?t2Bs9Zh1VESzPSj7fEl5bk=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 6:BQXRDR5tuLvnCBVTaM6YMNa5yqGPVcpRhFLnoSBCXDeyQeOLbcSm9cCxEQHzfpya8TqUQMNUm9SPOmmgQzCdD4Haiw9UoFB9te1tuh36xiXrVUrBh+9RAxcM5Fl+Rn/ClpimmJBGJ8RJzhOO+dzHf6Fz6W/7oj1ZheFTErnsMW28mY4anGDGQ7rYzxVGfkGU3h1TCak8QyzXbGoJSMWHhk/EO7nr3YNiiwCfHxkFHlh1X/yqkQNPKVq1HrBnrVmNsa2ru2jInLUneVXbYpQ8nfpy0txt+I2bIV/sGiX7Hgg3yeRFkQ09PZj2AKs8V86KA32J/9wAY6oNx5/r80wOLg==; 5:1iwP6n/eLVNH1nJaH7CQ2/ANgtGbiPhYVqzbmrjnCmMnH12dtNY8u1hZ7ivuKc14Bu8NoswKnbGercXjmRfzvIPRIn9grgNeLiysGd45aKbFk/tVK4qFcFp5LzXjdTspiH1sBeV8DKQWtfUa0YkCjA==; 24:ZjZAXZ5Ojku41jXKzYFsub/HEU1SIQLy4OR5ux8f9294x8spol8gNOls+M/+jvbR12iAW5v2Em7YAUVHoxLDeGWOAGZzDbow7gUzal6PFrk=; 7:FGBAPMiZesE+asQsVPm2nR9pAhiSh96/2txKFn5uzfUS7nwQmRgy4aZ0c9q/l2HK2AMFkvziMYY2vmMb6+a6UCocDg5CmM/6OAE/g7TcuKZBK84O49siKCID9hJAOmH1qvkEj5qaUeJ3yinAxIINZ3W0scpQHaLeXYnNkYB6jwI8eGfKNtrZZQ39AR0OBejiKMiUyD393J6uxUtlRsGkPeImj2BY5bD//BFIBbBqz3E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 10:04:07.3858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3467 Subject: Re: [dpdk-dev] [PATCH v2] eal: add function to check lcore role X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 10:04:11 -0000 On Thu, Sep 21, 2017 at 09:41:29AM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Thursday, September 21, 2017 9:58 AM > > To: Van Haaren, Harry ; thomas@monjalon.net > > Cc: dev@dpdk.org; Pavan Bhagavatula > > Subject: [dpdk-dev] [PATCH v2] eal: add function to check lcore role > > > > From: Pavan Bhagavatula > > > > This function can be used to check the role of a specific lcore. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2 changs: > > - removed ack due to significant changes in patch > > - addressed review comments > > - modified commit title and message > > Good work - a few final inline comments below; Thanks Harry > > - whitespace in bsd/linux .map files > - "unsigned" -> "unsigned int" (checkpatch) > - Move function to eal_common_thread.c > For some reason ./devtools/checkpatches.sh reports no error. Will move the function to eal_common_thread.c and send a v3. > With those, > > Acked-by: Harry van Haaren > > > > lib/librte_eal/bsdapp/eal/Makefile | 1 + > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 +++ > > lib/librte_eal/common/include/rte_lcore.h | 14 +++++++ > > lib/librte_eal/common/rte_lcore.c | 49 +++++++++++++++++++++++++ > > lib/librte_eal/linuxapp/eal/Makefile | 1 + > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 6 +++ > > 6 files changed, 77 insertions(+) > > create mode 100644 lib/librte_eal/common/rte_lcore.c > > > > diff --git a/lib/librte_eal/bsdapp/eal/Makefile > > b/lib/librte_eal/bsdapp/eal/Makefile > > index 005019e..f1263fc 100644 > > --- a/lib/librte_eal/bsdapp/eal/Makefile > > +++ b/lib/librte_eal/bsdapp/eal/Makefile > > @@ -88,6 +88,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += malloc_elem.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += malloc_heap.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_keepalive.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_service.c > > +SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_lcore.c > > > > # from arch dir > > SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) += rte_cpuflags.c > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > index aac6fd7..3be3287 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > @@ -237,3 +237,9 @@ EXPERIMENTAL { > > rte_service_unregister; > > > > } DPDK_17.08; > > + > > +DPDK_17.11 { > > + global: > > + > > + rte_lcore_has_role; > > +} DPDK_17.08; > > > I think there's usually a newline between the function and closing brace - nit pick. > > > > diff --git a/lib/librte_eal/common/include/rte_lcore.h > > b/lib/librte_eal/common/include/rte_lcore.h > > index 50e0d0f..777208d 100644 > > --- a/lib/librte_eal/common/include/rte_lcore.h > > +++ b/lib/librte_eal/common/include/rte_lcore.h > > @@ -262,6 +262,20 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > > */ > > int rte_thread_setname(pthread_t id, const char *name); > > > > +/** > > + * Test if the core supplied has a specific role > > + * > > + * @param lcore_id > > + * The identifier of the lcore, which MUST be between 0 and > > + * RTE_MAX_LCORE-1. > > + * @param role > > + * The role to be checked against. > > + * @return > > + * On success, return 0; otherwise return a negative value. > > + */ > > +int > > +rte_lcore_has_role(unsigned lcore_id, enum rte_lcore_role_t role); > > + > > Other functions use "unsigned" in this header, however checkpatch complains about it. I think we should use "unsigned int" instead, to make checkpatch happy and use more modern C practice (at the cost of minor deviation from the existing funcs). > > > > #ifdef __cplusplus > > } > > #endif > > diff --git a/lib/librte_eal/common/rte_lcore.c > > b/lib/librte_eal/common/rte_lcore.c > > new file mode 100644 > > index 0000000..66c03f4 > > --- /dev/null > > +++ b/lib/librte_eal/common/rte_lcore.c > > @@ -0,0 +1,49 @@ > > +/* > > + * BSD LICENSE > > + * > > + * Copyright (C) Cavium, Inc. 2017. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Cavium, Inc nor the names of its > > + * contributors may be used to endorse or promote products derived > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > + */ > > + > > +#include > > +#include > > + > > + > > +int > > +rte_lcore_has_role(unsigned lcore_id, enum rte_lcore_role_t role) > > +{ > > + struct rte_config *cfg = rte_eal_get_configuration(); > > + > > + if (lcore_id >= RTE_MAX_LCORE) > > + return -EINVAL; > > + > > + if (cfg->lcore_role[lcore_id] == role) > > + return 0; > > + > > + return -EINVAL; > > +} > > While reviewing, I found that the rte_socket_id() function is declared in rte_lcore.h, but implemented in eal_common_thread.c > This function should probably move there too - common thread sounds like a good home to this function. Apologies for not noticing this earlier, and suggesting rte_lcore.c > > > > diff --git a/lib/librte_eal/linuxapp/eal/Makefile > > b/lib/librte_eal/linuxapp/eal/Makefile > > index 90bca4d..9596acb 100644 > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > @@ -100,6 +100,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += malloc_elem.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += malloc_heap.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_service.c > > +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_lcore.c > > > > # from arch dir > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > index 3a8f154..7304a34 100644 > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -242,3 +242,9 @@ EXPERIMENTAL { > > rte_service_unregister; > > > > } DPDK_17.08; > > + > > +DPDK_17.11 { > > + global: > > + > > + rte_lcore_has_role; > > +} DPDK_17.08; > > -- > > 2.7.4 >