From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix service array initialisation
Date: Thu, 21 Sep 2017 14:04:43 +0200 [thread overview]
Message-ID: <20170921120442.GC13383@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FA8728@IRSMSX101.ger.corp.intel.com>
Hi Harry,
On Thu, Sep 21, 2017 at 11:53:48AM +0000, Van Haaren, Harry wrote:
> > From: Nelio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > Sent: Thursday, September 21, 2017 12:48 PM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>
> > Subject: [PATCH] eal: fix service array initialisation
> >
> > GCC is complaining on variable used without being initialised.
> >
> > dpdk.org/lib/librte_eal/common/rte_service.c:
> > In function ‘rte_service_start_with_defaults’:
> > dpdk.org/lib/librte_eal/common/rte_service.c:449:9:
> > error: ‘ids[0]’ may be used uninitialized in this function [-Werror=maybe-
> > uninitialized]
> > ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1);
> >
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: harry.van.haaren@intel.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> Hi Nelio,
>
> Thanks for the patch - indeed this seems to be an issue. It was raised by Yang too
> in this thread http://dpdk.org/ml/archives/dev/2017-September/076210.html
>
> Given I've asked for a v2 of that patchset, and it was posted earlier I'll suggest
> to merge that one, if that's OK with you?
Yes, it is. I have search for such patch, but it is not easy to find
it. I will move this patch to superseded on the patchwork.
> On another note, I'm curious why neither I or the automated build-system experienced this...
I don't know either, I faced the issue on debian 8, on ubuntu 16.04 and
redhat the issue is not visible. It becomes quiet complicate for a
single guy to test on so many distributions ;)
> Thanks for investigating / proposing a solution. -Harry
Thanks,
--
Nélio Laranjeiro
6WIND
prev parent reply other threads:[~2017-09-21 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 11:48 Nelio Laranjeiro
2017-09-21 11:53 ` Van Haaren, Harry
2017-09-21 12:04 ` Nélio Laranjeiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921120442.GC13383@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).