From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0081.outbound.protection.outlook.com [104.47.37.81]) by dpdk.org (Postfix) with ESMTP id 2ECE31B1A3 for <dev@dpdk.org>; Thu, 21 Sep 2017 14:36:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fC+/G3kJkZwpSDwOThI1ZaqYLXDB7B/so9RqHzOyN8o=; b=e7ajdFf9a0eRPAd+xRJgaAVtYOXiPsQ0cWtGEHvwMbfB6y0Xj53cuewvkpRMIMnaNgyI303r2BrrBOcXN/bOxqjuLGUtC2l3GliEQ5datg2qioAYdxiZKpFGL6+p2LOCfjtOFDubjeiLkVxj+7FMgzLgJ1tUoQlMM5g+BgFzTxA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Thu, 21 Sep 2017 12:36:22 +0000 Date: Thu, 21 Sep 2017 18:06:04 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Nikhil Rao <nikhil.rao@intel.com> Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com Message-ID: <20170921123603.GB20126@jerin> References: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com> User-Agent: Mutt/1.9.0 (2017-09-02) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0011.INDPRD01.PROD.OUTLOOK.COM (10.174.214.149) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81fe44b3-580f-4354-307f-08d500ed5fdb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:Pov+8sVjRCVoY3UMKqD372NDsLHIcdYGPdCFMv5Ss3ul/jxiSKYhjk+SaeeBO/Ql3C0Ko2zli9+5V7ObJid7k1cUKQnfp+RdMzLBn4/u8J6ugqWvWD14Hwvpw1RuCY7ogO2PM+7Wi6XhLUEpmNlxRLR7is6JWmFg3IdH1+82O1507GQjqP/ZLO6TZJcP8EeYebHfweiN2qi9yyt1FccNHYgurbNrDXRvYBAq5nYsTWOpIT5unlspxmmWianMM67A; 25:Hj//CHofwvppHoaSOXzUrOqvcbU0BEsuUI/w6fNAwIu+awK4PFNK/SDjzpEEH0Yzzo+Y7D+CekuXhEMjPWvSrpbeeqegf8sRq39etpTtOtFBC9pZ4O25Tt2YzP6VCaIFp1a4yU5fZ80vN2Gc2vh6eLYtYKXnbjUs5BHLh9fKxF5L1Xvl2srf8h+pi1DTJtbzMRpGnU4tevomM2H5FE2ULSL3nvCmFRcXuh+4ld9Qy3yYeApzY4G7X/p+k7Yv31ibyPc7lrEqAQRJQiitcktvV85s2a73QVIQCrTMjJei+qlvSeZmEQ59uMHtuX+nLNq1NUZW77TO3BGeDscEn2M9fg==; 31:oUSEq23Q6kYDlYwn8QWAzraPTu1LWKliZqcuNvGPcMIoTdRmmxap7+u5V12CSlyzfu8k8hqHVlQlSzr6tp+h49DY3ngsSOksK9gNKIi66J0pBaRYfT+y2Yuf7FpndSKhlBh4qRyNjQg8Zhb4RvN2Z89+iNTfheLuhCeQWGTeLdVAFXex4s3S+70aQqG1dMlQcMUiZ8EW4mUbYfIlOarYSrB0mg6uqcWr9NzVTaQU9Sc= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:NivCDz6zpEtIwT4PsjTE2eRIJuEgrHwltpaRbNMbNMCODuH1KeV8DyFdHcbPmMfdeRG456Hl7a8I86qpLJBKYBR8JF0zjJxGZK/m+fKt9oOZroajyGQ8iaJ82M8FO19UbyFTG4LFZmugMtTAcL5yDFd3Xqu8GZ9k/cUfCij+vs2Ifq3Oc3ML0AdKSDr5LvBid4PxeUon9Zz7UW6bk1gRmqj3Ft6iSu/4SQ0FE6qg7915+3I7JI1humwvE6dZHMBm+884LVD3IrAalJ9XkFdGjSGGz58bgXt7DaSA8AgvPK7Fh3+V5mtVBRR7vVCrFTBczIxfVuCG4sS3xQF+mjW8bjY5EthfcnsbLiMN9mIDQArGhOVsIyfuETYFOb+vD2ECs1fLXr8SxiZgCebaUHQjaphrhpd/fftfVe/zRI8u61DekjBdAjOxJUZX3su25bS4FfnmCJLHLDLDXBxfCztRudSZGcDxkrEqlbH/1ghyuTpLkmlnfqe7C8IH1U7Lzw04Robgm91WRge9Ha8V3bQpKpe0A2bCzUaJosZdsqp/ozHWrZQ4Pe8dKdkIPGfY5GuYya3uM3pRmpYG6cJ/F5rVICMmgmZML8I5i9PVMJjW1/A= X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: <BN3PR07MB2513B4343ECCAB235127458CE3660@BN3PR07MB2513.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:BtKu1zemlYGAE9xgKA0QKoULru5qJhxcAivkNvykvj9gd4pTn4zuH53M3a9A6bofVuzrHfD0fsPg77xh0AbVMJaMZ9WDWs0zxZax/N/ggKmUIDyQ7iAjOGURAE7AiFNv37I03SqIL9PJL0ANtvOD9HFw0R2/OkOfmPSQqj3+HUje/LlYABbH7jsAKsP/LSpmfzZ6glRvsv81d6V6NxWbfVgl1Msu01tdTtT1rqf1tkDwHHDypXuxfIpgEvguK7Gp4W05OWO8DEh9NDMXE3mHhs/jrTibMjSA98+GUxO6H06H4YCwoos1U6p+OkvPFKkwZEFW+hJr+4riupeqMisR0mlmZRM6T2b3sFPjjiFC8CTK8jLJACYY040QhLac0xTe X-Forefront-PRVS: 04371797A5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(13464003)(5009440100003)(6666003)(16526017)(16586007)(1076002)(33656002)(58126008)(50466002)(229853002)(47776003)(25786009)(8656003)(2906002)(316002)(66066001)(33716001)(97736004)(305945005)(53936002)(9686003)(7416002)(2950100002)(55016002)(42882006)(6916009)(7736002)(50986999)(4326008)(76176999)(54356999)(68736007)(6496005)(8936002)(6246003)(81156014)(81166006)(8676002)(83506001)(6116002)(72206003)(23726003)(3846002)(478600001)(189998001)(5660300001)(106356001)(105586002)(101416001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:Nh95uJ0KmwVScIAy/ttr360s8dYlx1k0QphEfZ55o?= =?us-ascii?Q?WLFSjpzcMSj/yxrASTI/B6TjgtCABlpuQwuKg/PmK3hXcMcpSuTHXRRga4zc?= =?us-ascii?Q?mGftAwTQB+u/ojgBj7D11G2raV1Eo+YG5PnH9RuKtSHvNKf5CNeTLUN5RMOv?= =?us-ascii?Q?QVcIpRLryIM8fQi3Op8ST8dUvlOuj8EnMfn3pU7dNuo4iR/1U4XU4tkKzhdL?= =?us-ascii?Q?lGQHJJWiEfSdQ/r3ZP6KDwFEKIBhqqRkg6iDVyHVW2oz5h/KSVfkAuEwScDv?= =?us-ascii?Q?NQmtn2NFaWBqu29EPPnSzKxo0z6h/gNtesxEmup7SnXct2yxghwliwthsrfT?= =?us-ascii?Q?g+lNnBuSBRc4H7ypaBbsq+UBdCNUN1LIVNJ7u/sNd0+bwN+hG5UFpqyHfNKF?= =?us-ascii?Q?UHZ8Sw4boOGF6iaEvInzyRx40SzTYeJ4baJPa29HUZ1KEyx7Rcb+hMKAALqi?= =?us-ascii?Q?/mX5v8MRJi9fbd7aqM1U6TlbSkYf+xeMis3tanzUgRYu4hsxAE2wIeaxGkOd?= =?us-ascii?Q?6HRFiDant8HRLp+OARVsPtrvRIfaK6TnpBMTueyKqdcbfmcXBb4nQ+Bl6xMJ?= =?us-ascii?Q?Rj+K5pDi3JiDgi4rZFFcmNpnJnU/eTe1Os9Mr4CuKtD1XGAyfz75CY/sI8x9?= =?us-ascii?Q?v+2fRYc9Vl571dBcy1Xjg2OPB3SqPDGZNCK5qxL0xXxF6Es+andqWfYAU3wt?= =?us-ascii?Q?3wqpK27gQrqQDHi240o+E0RfEW8lHJ5QWWP6yivttjyPyK7yHDqUFhY6IEet?= =?us-ascii?Q?fQL0NXGmKTABrGlNGgEF71nbGXcrWbQChIRu+qgtF6t0uz6H9UTbSQpzHrD7?= =?us-ascii?Q?XHKABNDjomo+xPVv8YsaL/qYSUxQ9dH00LNUPTEo26WVGSeevQwNT5WhjVD5?= =?us-ascii?Q?hBnHBeQhbnxaog4vdmxucMwSSjDJul7xSj0RtuOCQ7FH+ci+V1J+t6qx566Q?= =?us-ascii?Q?tp6omrK3xoveYs7bXSTf0hfUd8P2t+RPNQwDn2+YfW1sT3DInwZXcULdnPIO?= =?us-ascii?Q?bSD0HJkoBy4WSPL7+e4/K0FgHCRmYjbowNy3w1oqqqGvL9BbEAPjxLNsy1x6?= =?us-ascii?Q?aglfksu0I+uAiUQf686eQHimDpanRjFkESPlqN5jkGGCUzstD74C8nS4mF8S?= =?us-ascii?Q?Cd94o9gqF5dp04uYM20uDndfCiWcbm6p8/E4E5awTVqNTyBKI0iWBlBTUG9I?= =?us-ascii?Q?26h6Ev0HzvN4/gXP6XqTO6COPJVzIo7FnbF8ZeGXw6rNDxViWdstdlvKCAM6?= =?us-ascii?Q?1jzmsM3rWBnPQEMlGb7005w7VxuGSb1/d4JFFTz?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:vAF6b/FPQOvY47rVn0ThpoC8AgBGznO1H/XTJhZv4yZbLIZ4KAd+HWe/5jwk075lflnM7NsEAgumc7AblMs7gqbf85olfTFI75zojHib8l/EVuJ2kMzyCAylupoT1LgEpJPXJ9QJGpUXSBE14PFkGmuAOo67dRvTtP/JJJ1aOyJ1zrXSJuwD9BxNXvWwRNQFNwCEktja8U8GeklhkkrkImYMw6Az0NE/sc8NAyAamoIPHjeeY62m7GWdGcKC/aH533RcgwyhLhgQ9yPKLeI52tN78LkM4AoNs1OsdUTmUW8cVZNqK/ViLRcwyST6pauw7imnnH+GV5Avqgm9ax6TPw==; 5:CzN43UgRVMmn4aIHkz9e1Jx7F2fv3A1gCfBkeYX43HU1H71L1DWlezGYhnj7aN9Wi6BkpXbw6CVAqKAHSD9gZvhg1jQCg5AtvTy2/0Gw5Lgmhwef0eSEGPbWqeWeUfa+mkyIQLr6xSzuL9Cc28cx4w==; 24:HGigaUvLrR8yhgSXmkDvaxN3cVaAm5Y4jl/7E6djHSkCigv9Gj0obhr2Nh6sYzFstnnwbOB2oBWwhoQ84wD6RWuNggNzNSPRFxS/YIO9aKw=; 7:6UrR8ukJwUZCuKrl+8BBO4yrLbpHMkxxdMImFbas/y9wd2s7zSRDF1l1dW+8dOHlnXT7hdZbg8uBMLRc+r8D8o5RKIG2V9e6fn+Y0gCqktQh1J4Qgtg//AFdcpPbQ+UvSJwJWBFf2P+q+zwL5A67/0s0895zpYoBgqCb3vwCH4PBCdMCNaiuC6ym7FMYrvGSpvqYX81umliDh+WHrVG3pV+DzarY9chdPWSjSWPkQSQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 12:36:22.7148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 21 Sep 2017 12:36:29 -0000 -----Original Message----- > Date: Tue, 12 Sep 2017 17:59:25 +0530 > From: Nikhil Rao <nikhil.rao@intel.com> > To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com > CC: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, > harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, > narender.vangati@intel.com, erik.g.carrillo@intel.com, > abhinandan.gujjar@intel.com, Nikhil Rao <nikhil.rao@intel.com> > Subject: [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event > adapter > X-Mailer: git-send-email 2.7.4 > > Eventdev-based networking applications require a component to dequeue > packets from NIC Rx queues and inject them into eventdev queues[1]. While > some platforms (e.g. Cavium Octeontx) do this operation in hardware, other > platforms use software. > > This patchset introduces an ethernet Rx event adapter that dequeues packets > from ethernet devices and enqueues them to event devices. This patch is based on > a previous RFC[2] and supercedes [3], the main difference being that > this version implements a common abstraction for HW and SW based packet transfers. > > The adapter is designed to work with the EAL service core[4] for SW based > packet transfers. An eventdev PMD callback is used to determine that SW > based packet transfer service is required. The application can discover > and configure the service with a core mask using rte_service APIs. > > The adapter can service multiple ethernet devices and queues. For SW based > packet transfers each queue is configured with a servicing weight to > control the relative frequency with which the adapter polls the queue, > and the event fields to use when constructing packet events. The adapter > has two modes for programming an event's flow ID: use a static per-queue > user-specified value or use the RSS hash. > > A detailed description of the adapter is contained in the header's > comments. Hi Nikhil. Overall this series looks good. The patch specific comments, I will send on each patches. Please fix the 1) ./devtools/check-git-log.sh & ./devtools/checkpatches.sh issues with series 2) I guess for next revision you could split the patches to more fine granularity with make sure each patch build separately.