From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1-b.wedos.net [46.28.106.43]) by dpdk.org (Postfix) with ESMTP id 05889968 for ; Fri, 22 Sep 2017 10:31:04 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3xz6Bc3Zvvz78K; Fri, 22 Sep 2017 10:31:04 +0200 (CEST) Date: Fri, 22 Sep 2017 10:31:03 +0200 From: Jan Viktorin To: Lukasz Majczak Cc: chaozhu@linux.vnet.ibm.com, dev@dpdk.org Message-ID: <20170922103103.2ef17602.viktorin@rehivetech.com> In-Reply-To: <20170921155953.9984-1-lma@semihalf.com> References: <20170921155953.9984-1-lma@semihalf.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] librte_eal: fix wrong assert for arm and ppc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 08:31:05 -0000 On Thu, 21 Sep 2017 17:59:53 +0200 Lukasz Majczak wrote: > The assertion of return value from the open() function is done against > 0, while it is a correct value - open() returns -1 in case of an error. > It causes problems while trying to run as a daemon, in which case, this > call to open() will return 0 as a valid descriptor. I'd put an empty line here... > Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7") > Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8") > Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power") > > Signed-off-by: Lukasz Majczak Acked-by: Jan Viktorin