From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1D9403230 for ; Mon, 25 Sep 2017 11:40:57 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2017 02:40:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="152970969" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.24]) by orsmga005.jf.intel.com with SMTP; 25 Sep 2017 02:40:54 -0700 Received: by (sSMTP sendmail emulation); Mon, 25 Sep 2017 10:40:54 +0100 Date: Mon, 25 Sep 2017 10:40:53 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, Chas Williams Message-ID: <20170925094053.GA14012@bricha3-MOBL3.ger.corp.intel.com> References: <1506322206-30233-1-git-send-email-arybchenko@solarflare.com> <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 09:40:58 -0000 On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote: > On 9/25/2017 7:50 AM, Andrew Rybchenko wrote: > > Failure happens on build using: > > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > Yes, that case is missed. What do you think about following one: > > @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, > unsigned int blockcnt, > unsigned int framesize, > unsigned int framecnt, > - unsigned int qdisc_bypass, > + unsigned int qdisc_bypass __rte_unused, > struct pmd_internals **internals, > struct rte_eth_dev **eth_dev, > struct rte_kvargs *kvlist) > > > > > Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable") > > > > Signed-off-by: Andrew Rybchenko > > --- > > May be the right solution in fact remove PACKET_QDISC_BYPASS conditional > > completely. If below solution is accepted, feel free to squash it into > > the original patch. > > It is a little to late for this, I already sent a pull-request with this > patch. So fix will need to be a separate patch. > Pull request hasn't actually been pulled yet, so you should be able to supercede it by a later one, right? /Bruce