From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 617321B19F for ; Tue, 26 Sep 2017 16:31:27 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 26 Sep 2017 07:31:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,441,1500966000"; d="scan'208";a="1018587315" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.14.171]) by orsmga003.jf.intel.com with SMTP; 26 Sep 2017 07:31:19 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Sep 2017 15:31:18 +0100 Date: Tue, 26 Sep 2017 15:31:18 +0100 From: Bruce Richardson To: Tomasz Duszynski Cc: dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jacek Siuda Message-ID: <20170926143117.GA24952@bricha3-MOBL3.ger.corp.intel.com> References: <1506418805-12117-1-git-send-email-tdu@semihalf.com> <1506418805-12117-2-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506418805-12117-2-git-send-email-tdu@semihalf.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH 1/8] app: link the whole rte_cfgfile library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 14:31:28 -0000 On Tue, Sep 26, 2017 at 11:39:58AM +0200, Tomasz Duszynski wrote: > Since MRVL NET PMD needs librte_cfgfile to parse QoS configuration file > link it as the whole library. > > Signed-off-by: Jacek Siuda > Signed-off-by: Tomasz Duszynski > --- Can you clarify a bit more why this is needed? For a static build, the cfgfile should be linked in to the after the PMDs, so the dependencies in the driver should be satisfied in the link. For a dynamic build, the PMD should depend upon the cfgfile directly, and use it at runtime appropriately. Am I missing something? /Bruce