From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com [209.85.215.41]) by dpdk.org (Postfix) with ESMTP id F2F081AEF3 for ; Wed, 27 Sep 2017 09:36:05 +0200 (CEST) Received: by mail-lf0-f41.google.com with SMTP id d4so6798764lfj.7 for ; Wed, 27 Sep 2017 00:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gXdNXTskxuO42nHwjEkxcNnIJ6Om1IwKHEntI3He0/E=; b=mnVTWhxa0FIZOnamAI75jDCv+jbSFApHYSstsGdG62VUYDcPN3phhmrDW8650MfWPu M9VIoG2kiqNSOmQnTLW3O9ng9X4bb06SyXZ8L7iGBFM75+ATSXe2dYQIEpEunhyB+vxG BJFzcVS8F1e2NUDChtMSEdmHdrsB+SgTdSKduCmVFOI0MlPmrEfYsN+yzr9Agcn2smyb SC/V+6HnQSdE6wZQmd15nl4Q0LhhZAzlKB6d9/vQFdH5485KD5UtmooYMmz2GdL/GKoh nmJ2iqjCZDakjM0QMPgJGM5KsFZ36CyMZ/wl+48aB83kZi8vU3eluajgfuIs+qNtWYI1 12ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=gXdNXTskxuO42nHwjEkxcNnIJ6Om1IwKHEntI3He0/E=; b=pC4+lau1KuVtva7V6HvScj2m4+PNi+zJdkJnYxQBpx9LbrAbNhCR0J8NdI3Q+no5fT Uw9hOlF+Oob4HqU+/4a7C5srIH5TMfKWKW3ooa7XngPiFv9nICpBn/cj2Mh9gJupdVD5 R+rNL6vT/ZoSZ0tcox/nJvoeNy8ROeZQ1kE3xRTlm1sW7mLiqqwxzOmBikSkGtw0GBv+ Ch/HkLeuyLYsuVFUd8othnqCcNZ7Php84Auohb7r3GqDdThKQ3nGH1jCoHgY3E4AFm++ ypnGvEHPhqIITmpRzK4QrJfXn9qML3OWMDLSIMREKs+CLhAU8CsGZvjCwAygK4JuAzn+ 3M7A== X-Gm-Message-State: AHPjjUhF3VTcUnNjwUe3Z1rRatcnF9i7Zm8JK1AIwWz/507P2bICA/YI 0fF2s/v2LkrKRy0rmAnAlTk6Ew== X-Google-Smtp-Source: AOwi7QDlQGxaG4KnJYMwYzg/6RplKa2isU9nsVOwrUbGgUmJp13fhHfxtiIStSeuPUxrgvFi18TDCg== X-Received: by 10.46.64.216 with SMTP id r85mr299688lje.120.1506497765563; Wed, 27 Sep 2017 00:36:05 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id m12sm2240044lje.21.2017.09.27.00.36.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2017 00:36:04 -0700 (PDT) Date: Wed, 27 Sep 2017 09:36:03 +0200 From: Tomasz Duszynski To: Bruce Richardson Cc: Tomasz Duszynski , dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jacek Siuda Message-ID: <20170927073603.GA30028@tdu> References: <1506418805-12117-1-git-send-email-tdu@semihalf.com> <1506418805-12117-2-git-send-email-tdu@semihalf.com> <20170926143117.GA24952@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20170926143117.GA24952@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/8] app: link the whole rte_cfgfile library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 07:36:06 -0000 On Tue, Sep 26, 2017 at 03:31:18PM +0100, Bruce Richardson wrote: > On Tue, Sep 26, 2017 at 11:39:58AM +0200, Tomasz Duszynski wrote: > > Since MRVL NET PMD needs librte_cfgfile to parse QoS configuration file > > link it as the whole library. > > > > Signed-off-by: Jacek Siuda > > Signed-off-by: Tomasz Duszynski > > --- > > Can you clarify a bit more why this is needed? For a static build, the > cfgfile should be linked in to the after the PMDs, so the dependencies > in the driver should be satisfied in the link. For a dynamic build, the > PMD should depend upon the cfgfile directly, and use it at runtime > appropriately. > Am I missing something? > > /Bruce Hi Bruce, You are correct, all dependencies in the driver will be satisfied. The reason this change was introduced is that, librte_pmd_mrvl.a contains undefined symbols from librte_cfgfile.a thus linking applications under app/ directory will fail as librte_cfgfile.a comes before librte_pmd_mrvl.a during the linking stage. Linking librte_cfgfile.a with --whole-archive solves the issue. -- - Tomasz Duszy=C5=84ski