DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app
Date: Sun, 1 Oct 2017 10:24:10 -0700	[thread overview]
Message-ID: <20171001102410.3c928ad5@xeon-e3> (raw)
In-Reply-To: <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com>

On Sat, 30 Sep 2017 09:59:08 +0800
Xiaoyun Li <xiaoyun.li@intel.com> wrote:

> To make the performance can be tuning on different NICs or platforms. We
> need to make the number of descriptors and Rx/TX threshold as arguments
> when starting l3fwd application.
> 
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>

Not sure about this. The point of l3fwd is to make it as simple
an application as possible to help users.

Given that drivers can now supply default values for thresholds, I think
the l3fwd sample should get rid of all the special descriptor values it
is setting. Then if the values are not right for best performance that should
be pushed back to the driver writer to fix.

  reply	other threads:[~2017-10-01 17:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  2:31 [dpdk-dev] [PATCH] examples/l3fwd: pass flow arguments when starting l3fwd Xiaoyun Li
2017-09-30  1:59 ` [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app Xiaoyun Li
2017-10-01 17:24   ` Stephen Hemminger [this message]
2017-10-05  8:35     ` Wu, Jingjing
2017-10-10  7:57       ` Wu, Jingjing
2017-10-18  7:11   ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2017-10-24  1:38     ` Wu, Jingjing
2017-10-24 21:44       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171001102410.3c928ad5@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).