From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 7F41C1B1FA for ; Mon, 2 Oct 2017 13:53:29 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id q124so10080654wmb.0 for ; Mon, 02 Oct 2017 04:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RqO9lVg37TjLOby05LQe0YLAvmq9eHu1UTJCCC2Vkfc=; b=VTONOGhYkkVV5MHh1y0H7IPUd60S8eb68qtaAmBsbHecPzBz5V8ddOPCVPWTbA6ypq mIEnEy496qY0TVzC4VvIKxA3rAu6Ya4Ugs2DA+CuJ9ctWj0JHQG5tubwAVqXDAETeErJ TSlQ0gbxHENgYXHgxbr+0DgEurTVD7JacE4L9wfkvBobd3oDNvzQ4PGscuniKm+Fz+i+ WL2xOpaAeWTVOLs34C+ryZLbPnaSuqyvwMVbHcKPCAP2rAID3JuBr+KYVZ/nL7vrpaHw d3vmVCkexf1jV00xbF/rX75ClLrJUezmbqeKU5/mQw/GjNiy5O+2ldYiqqmMu9ToWMjB eCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RqO9lVg37TjLOby05LQe0YLAvmq9eHu1UTJCCC2Vkfc=; b=NLz5b75qfhEc+uTs5D/mt1SfIDP0HlET2hXCwPr6gbCiF0Mk/P22Od3zkxaX5ls7KU TMzOfltbbe/VIMkXisrHC+SdFrqSxGSOxoujSSLuGHzkHXGx9Mhc2tlYo9rYMlY/nBVH zx/uLJB9/jbHlDTIHk+g/cNYvYHhzaErAHALfT49300BxHrpVPVHU6LbjFD1hS2fedvD FwfGY9NCzbYur5dMHCdUKEkuw99ES/y9bI3PMEa/+yIWUtZ/s43IXkNPoxeECkkuaCvn IzaKz1KJtkhuFk5v3CxMZJOocDB0YPdTnwlFS+G7mpE2u/T7o8mb2bdMYFxIo+Cz9XSm zTmw== X-Gm-Message-State: AMCzsaX/uQXAhZal1L1+9ptadcCRYDzjEKmJRetcOkghXYURgzocl3Wk CJ8VovYrf3BgRgED2ZQrtLO8bCe4 X-Google-Smtp-Source: AOwi7QDdSAf8b7x9cKuRKKZ/uYpcX6Rd0HyFR04vVdX75/TME3kjcn3Kzc/7g5/CEUxYp3jyUTmflw== X-Received: by 10.28.94.138 with SMTP id s132mr9359621wmb.0.1506945208842; Mon, 02 Oct 2017 04:53:28 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r6sm8607954wrg.40.2017.10.02.04.53.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Oct 2017 04:53:27 -0700 (PDT) Date: Mon, 2 Oct 2017 13:53:17 +0200 From: Adrien Mazarguil To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20171002115317.GJ3871@6wind.com> References: <20170929153749.9806-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170929153749.9806-1-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 11:53:29 -0000 Hi Stephen, On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: > The Linux kernel style policy about strings is that strings should > be always put on one line. This makes sense since a typical use > case is for a user to type the error message into a search engine > or grep, and it won't be found if split across lines. > This patch just re-enables that check. > > Yes, lots of DPDK code now splits strings, that doesn't > make it right. > > Signed-off-by: Stephen Hemminger > --- > devtools/checkpatches.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index a56c41a301c0..3e6081dd673e 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -44,7 +44,6 @@ options="$options --show-types" > options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > -SPLIT_STRING,LONG_LINE_STRING,\ > LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > NEW_TYPEDEFS,COMPARISON_TO_NULL" I'm not sure, given that the main reason for splitting strings in the first place is to avoid LONG_LINE_STRING warnings, I think we must choose between the two options. If split strings are not allowed, then long lines must be. Since checkpatches.sh is used by various automated scripts to complain loudly about problems in submissions, the above change prevents maintainers from writing long string at all (can't split and can't go past 80 columns). As a result, they will be tempted to cripple their code with nasty workarounds to shut up checkpatches.sh, we don't want that to happen. Also I think the reasons stated by original commit cf75514c8e2e are still relevant. My vote would be to keep things as is. -- Adrien Mazarguil 6WIND