Re: [dpdk-dev] [PATCH v2 1/4] crypto/mrvl: add mrvl crypto pmd driver

[Tomasz Duszynski <tdu@semihalf.com>]

On Thu, Oct 05, 2017 at 04:47:37PM +0100, Bruce Richardson wrote:
> On Thu, Sep 28, 2017 at 12:23:29PM +0200, Tomasz Duszynski wrote:
> > Add support for the Marvell Security Crypto Accelerator EIP197.
> > Driver is based on external, publicly available, Marvell MUSDK
> > library that provides access to the hardware with minimum overhead
> > and high performance.
> >
> > Driver comes with support for the following features:
> >
> > * Symmetric crypto
> > * Sym operation chaining
> > * AES CBC (128)
> > * AES CBC (192)
> > * AES CBC (256)
> > * AES CTR (128)
> > * AES CTR (192)
> > * AES CTR (256)
> > * 3DES CBC
> > * 3DES CTR
> > * MD5
> > * MD5 HMAC
> > * SHA1
> > * SHA1 HMAC
> > * SHA256
> > * SHA256 HMAC
> > * SHA384
> > * SHA384 HMAC
> > * SHA512
> > * SHA512 HMAC
> > * AES GCM (128)
> >
> > Driver was engineered cooperatively by Semihalf and Marvell teams.
> >
> > Semihalf:
> > Jacek Siuda <jck@semihalf.com>
> > Tomasz Duszynski <tdu@semihalf.com>
> >
> > Marvell:
> > Dmitri Epshtein <dima@marvell.com>
> > Natalie Samsonov <nsamsono@marvell.com>
> >
> > Signed-off-by: Jacek Siuda <jck@semihalf.com>
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  config/common_base                           |   6 +
> >  drivers/crypto/Makefile                      |   2 +
> >  drivers/crypto/mrvl/Makefile                 |  63 ++
> >  drivers/crypto/mrvl/rte_mrvl_compat.h        |  48 ++
> >  drivers/crypto/mrvl/rte_mrvl_pmd.c           | 870 +++++++++++++++++++++++++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_ops.c       | 787 ++++++++++++++++++++++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_private.h   | 121 ++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_version.map |   3 +
>
> The standard convention for naming version files for these drivers is
> "rte_pmd_<name>_version.map". Without this, the new meson build system
> will have trouble finding the map file. The same convention applies to
> net drivers too.
>

OK. Thanks for pointing this out.

> Regards,
> /Bruce

--
- Tomasz Duszyński