From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <tdu@semihalf.com>
Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com
[209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 849B81B254
for <dev@dpdk.org>; Fri, 6 Oct 2017 09:24:22 +0200 (CEST)
Received: by mail-lf0-f53.google.com with SMTP id d10so17059218lfg.11
for <dev@dpdk.org>; Fri, 06 Oct 2017 00:24:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=JIVjxnjMmCBOdz+SmkLBnbHAr3OBkwFg/V3KFHucfyA=;
b=AXMV2H2Srj/MtEHfC451nzLrW7mcJ7+ewZark21FTgKgsiByoaGxxbVDpBy5GcCiaw
v2cIK9N48Ia97eYyZJ9dOssM73u8dVB7cM+CoZygWWjVb3W3egu1SowhRBm0yrZm0bHH
Z22EPNAfERdJj+U0kptaaX3rd1IQJ7ljg5BBkWUx3e8CXI8ZT2lw5yq2gPwsFUXntSfP
DgNgP8CzuDGaZUUW8wjbkLgEKgQgNKNvJ3ghambzrch4BCcPpC+97vKqzY5YiATAHVV4
wGeoQP7nprksixeLyUZPmqmsrsKCAnulbgUHtjQoDf/eQdplpaXtFbs5nGkDAD/p1n9o
+xAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=JIVjxnjMmCBOdz+SmkLBnbHAr3OBkwFg/V3KFHucfyA=;
b=Ta0kJeG/ROPtaOGa00kqIeY+J9qNCnj8icD1dbmJ1tAchb0OjTLqjsWyY8OmUzSuVd
BnaJLYq7bjeVU8/9vNKFRXPrtIt++Rf0cY6nT6oQnAcOCQgnAtHDSlyG6Ey5HC2p0NU1
pPxSH6AOXeSw7p1uTzXoQ04wv95vzi/86fbsm2zOGU+S3aChl4HYbS0ZhMz5MzET89lB
DlV762vDc8AR5+p5viccu7kNAYCfLWtmclk3I2BXYXGtbF2Z1imsLgyafBK0aX0JtgfT
2nBxWSUoY1Hv8UX2qoaJJJQ4QPzQd9s0vWNOiu04cebXqBaAjEnhgckVvcyMV9C0vajc
06sg==
X-Gm-Message-State: AMCzsaVOZmHN74NxZzx7g//M5OcuNM8qWErMF9cNcc1vhFoYp7ZiO+iE
6w7gq0PhYQoZSjccQrlkZs11Rw==
X-Google-Smtp-Source: AOwi7QCNEKHZFiy2zCkfo9jsba7aVd/yPchhVb4QNcN2xdXoWz0jrKalwfKCuDAISJcNXsZuMnhLrg==
X-Received: by 10.46.64.83 with SMTP id n80mr505779lja.165.1507274661844;
Fri, 06 Oct 2017 00:24:21 -0700 (PDT)
Received: from localhost (31-172-191-173.noc.fibertech.net.pl.
[31.172.191.173])
by smtp.gmail.com with ESMTPSA id 29sm145568lju.45.2017.10.06.00.24.20
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 06 Oct 2017 00:24:21 -0700 (PDT)
Date: Fri, 6 Oct 2017 09:24:20 +0200
From: Tomasz Duszynski <tdu@semihalf.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
"mw@semihalf.com" <mw@semihalf.com>, "dima@marvell.com" <dima@marvell.com>,
"nsamsono@marvell.com" <nsamsono@marvell.com>,
"Jianbo.liu@linaro.org" <Jianbo.liu@linaro.org>,
Jacek Siuda <jck@semihalf.com>
Message-ID: <20171006072420.GC11828@tdu>
References: <1506418805-12117-1-git-send-email-tdu@semihalf.com>
<1506594212-15803-1-git-send-email-tdu@semihalf.com>
<1506594212-15803-2-git-send-email-tdu@semihalf.com>
<E115CCD9D858EF4F90C690B0DCB4D8976CC2BE45@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2BE45@IRSMSX108.ger.corp.intel.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 1/4] crypto/mrvl: add mrvl crypto pmd
driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 07:24:22 -0000
On Thu, Oct 05, 2017 at 03:01:33PM +0000, De Lara Guarch, Pablo wrote:
> Hi Tomasz,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, September 28, 2017 11:23 AM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > Jianbo.liu@linaro.org; Tomasz Duszynski <tdu@semihalf.com>; Jacek Siuda
> > <jck@semihalf.com>
> > Subject: [dpdk-dev] [PATCH v2 1/4] crypto/mrvl: add mrvl crypto pmd
> > driver
> >
> > Add support for the Marvell Security Crypto Accelerator EIP197.
> > Driver is based on external, publicly available, Marvell MUSDK
> > library that provides access to the hardware with minimum overhead
> > and high performance.
> >
> > Driver comes with support for the following features:
> >
> > * Symmetric crypto
> > * Sym operation chaining
> > * AES CBC (128)
> > * AES CBC (192)
> > * AES CBC (256)
> > * AES CTR (128)
> > * AES CTR (192)
> > * AES CTR (256)
> > * 3DES CBC
> > * 3DES CTR
> > * MD5
> > * MD5 HMAC
> > * SHA1
> > * SHA1 HMAC
> > * SHA256
> > * SHA256 HMAC
> > * SHA384
> > * SHA384 HMAC
> > * SHA512
> > * SHA512 HMAC
> > * AES GCM (128)
> >
> > Driver was engineered cooperatively by Semihalf and Marvell teams.
> >
> > Semihalf:
> > Jacek Siuda <jck@semihalf.com>
> > Tomasz Duszynski <tdu@semihalf.com>
> >
> > Marvell:
> > Dmitri Epshtein <dima@marvell.com>
> > Natalie Samsonov <nsamsono@marvell.com>
> >
> > Signed-off-by: Jacek Siuda <jck@semihalf.com>
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>
> If the guys in Marvell has contributed with the code,
> they should sign off too. Up to you.
>
> There is a script to test compilation (devtools/test-build.sh).
> You should also modify it to include the dependency with LIBMUSDK.
>
ACK
> ...
>
> > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c
> > b/drivers/crypto/mrvl/rte_mrvl_pmd.c
> > new file mode 100644
> > index 0000000..63f8daa
> > --- /dev/null
> > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c
>
> ...
>
> > +
> > +/* Register the driver in constructor. */
> > +RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_MRVL_PMD,
> > cryptodev_mrvl_pmd_drv);
> > +RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_MRVL_PMD,
> > cryptodev_mrvl_pmd);
>
> You can remove this alias, as this is a new PMD,
> we should be using the primary convention "crypto_mrvl".
>
ACK
>
> > +RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD,
> > + "max_nb_queue_pairs=3D<int> "
> > + "max_nb_sessions=3D<int> "
> > + "socket_id=3D<int>");
> > +RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_mrvl_pmd_drv,
> > cryptodev_driver_id);
> > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c
> > b/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c
> > new file mode 100644
> > index 0000000..f7374f8
> > --- /dev/null
> > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd_ops.c
>
> ...
>
> > + */
> > +static const struct rte_cryptodev_capabilities
> > + mrvl_crypto_pmd_capabilities[] =3D {
> > + { /* MD5 HMAC */
> > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> > + {.sym =3D {
> > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH,
> > + {.auth =3D {
> > + .algo =3D RTE_CRYPTO_AUTH_MD5_HMAC,
> > + .block_size =3D 64,
> > + .key_size =3D {
> > + .min =3D 64,
> > + .max =3D 64,
> > + .increment =3D 0
> > + },
> > + .digest_size =3D {
> > + .min =3D 16,
> > + .max =3D 16,
> > + .increment =3D 0
> > + },
> > + .aad_size =3D { 0 }
>
> You can remove this aad_size, as it is only applicable to AEAD algorithms=
(GCM in your case).
>
ACK
> > + }, }
> > + }, }
> > + },
>
> ...
>
> > + { /* SHA1 HMAC */
> > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> > + {.sym =3D {
> > + .xform_type =3D
> > RTE_CRYPTO_SYM_XFORM_AUTH,
> > + {.auth =3D {
> > + .algo =3D
> > RTE_CRYPTO_AUTH_SHA1_HMAC,
> > + .block_size =3D 64,
> > + .key_size =3D {
> > + .min =3D 16,
> > + .max =3D 128,
> > + .increment =3D 0
>
> If min and max values are different, increment cannot be 0.
ACK
Thanks for comments.
--
- Tomasz Duszy=C5=84ski