From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id 62ECF1B225 for ; Fri, 6 Oct 2017 10:06:22 +0200 (CEST) Received: by mail-lf0-f51.google.com with SMTP id 90so11302199lfs.13 for ; Fri, 06 Oct 2017 01:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=IxyP2O5rBrLg6Hi4T8uGBYUpfKYaZZ4Ogrc/kOxOeUY=; b=YOhssdrOrrNY3/rsev6bpDrzjYnsFCIsDcWQ7wfuI2W3qKt/s57PkXYNFKStLgWSI7 vD/MjGJH6ZPNg16VLbaHu2WrQwQoN/9Ax9f57n/c57wpwcKjltuehxvHmWv8JAg8RJU6 LegqgV3FwHQZ9e/J/A7IFz2hTidwlpbKHbhIbSrNUwNImdH7REWwXYiuoAs0jHOTbvnD IsdQ7TVBep8VyEcPOOE0wcz20l5PjaMd7VpTA9HMawM4hdz5zINkpaGtwKcwz1jFCXoh IilW3zuGHocajAroYsZ0ayD3RqWADX3cEYTaHYerOR/4B7fAzQHdOYYK71/bDE/VVTT5 XQvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=IxyP2O5rBrLg6Hi4T8uGBYUpfKYaZZ4Ogrc/kOxOeUY=; b=H4XnMBzN8inZ4Nra/kGVK0NGmivTOcIRKX6g/gVKsUZURyDqnfKpexZMOtrIzgowpV VSp72q6m4Mo87HnUW4LXBmCobz9QzF18tl09S2dFza2xf+rrfJluXQRVb8qbELMr0AFH pH+LOMqSoDHBBe8xrNFirt4ZG1022ylwAek9dcQr9BeN4Irblzgo2dWA8wtCu0uTfv78 YvDIwkQypCXm5T+nVpsSBE+bMK6So9HJsj3HE8/TOIJyI8aoCwgWL37maVmOq8uCFvmK y14d0Dyqh+BoF3P1TexpIsn/pWbT3anxkKbiGqmjDaQG++zIGwLo0XK1lLkGYN6bHZak QtYg== X-Gm-Message-State: AMCzsaWICUyradlpKoo9q7R9Dfsq8IoyuNQZ92OiII6oUgMyiBFJkx98 ciZE16D6KeBBmlPZ9ZxDMrNzCQ== X-Google-Smtp-Source: AOwi7QAb/BuAhJgJa+XuDAr+FHkddM1qkKBl1ykIBp7YbBeOT2jHgKpmJ3ReQ8bIYqvq/5F/rfWzAA== X-Received: by 10.25.20.37 with SMTP id k37mr478040lfi.163.1507277182037; Fri, 06 Oct 2017 01:06:22 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id e12sm191958ljb.93.2017.10.06.01.06.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2017 01:06:21 -0700 (PDT) Date: Fri, 6 Oct 2017 10:06:20 +0200 From: Tomasz Duszynski To: "De Lara Guarch, Pablo" Cc: Tomasz Duszynski , "dev@dpdk.org" , "mw@semihalf.com" , "dima@marvell.com" , "nsamsono@marvell.com" , "Jianbo.liu@linaro.org" , Jacek Siuda Message-ID: <20171006080620.GD11828@tdu> References: <1506418805-12117-1-git-send-email-tdu@semihalf.com> <1506594212-15803-1-git-send-email-tdu@semihalf.com> <1506594212-15803-3-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 2/4] doc: add mrvl crypto pmd documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 08:06:22 -0000 On Thu, Oct 05, 2017 at 02:45:33PM +0000, De Lara Guarch, Pablo wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Thursday, September 28, 2017 11:24 AM > > To: dev@dpdk.org > > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com; > > Jianbo.liu@linaro.org; Tomasz Duszynski ; Jacek Siuda > > > > Subject: [dpdk-dev] [PATCH v2 2/4] doc: add mrvl crypto pmd > > documentation > > > > Add documentation for the MRVL CRYPTO PMD driver. > > You should add the pmd in the list of device types (devtype), > In doc/guides/tools/cryptoperf.rst. ACK > > Also, you should mention this new PMD in release notes. > ACK > > > > Signed-off-by: Jacek Siuda > > Signed-off-by: Tomasz Duszynski > > --- > > doc/guides/cryptodevs/features/mrvl.ini | 42 +++++++ > > doc/guides/cryptodevs/index.rst | 1 + > > doc/guides/cryptodevs/mrvl.rst | 198 > > ... > > > +++ b/doc/guides/cryptodevs/mrvl.rst > > @@ -0,0 +1,198 @@ > > ... > > > + > > + ./l2fwd-crypto -c 0x3 --vdev=3Deth_mrvl,iface=3Deth0 > > + --vdev=3Dcryptodev_mrvl_pmd > > I will make the comment also in the first patch, but you should use "cryp= to_mrvl". > The cryptodev_*_pmd convention is old and we are only maintaining it for = backward compatibility. > So, I would use "crypto_mrvl". ACK Thanks for comments. -- - Tomasz Duszy=C5=84ski