DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: virtio lsc hint
Date: Tue, 10 Oct 2017 10:38:59 +0800	[thread overview]
Message-ID: <20171010023859.GO1545@yliu-home> (raw)
In-Reply-To: <20171009035616.24482-1-zhiyong.yang@intel.com>

On Mon, Oct 09, 2017 at 11:56:16AM +0800, Zhiyong Yang wrote:
> Virtio PMD has already the ability to support link status change(lsc),
> but qemu 2.7.0 introduce the capability to detect vhost user
> disconnection. So, virtio PMD which works with qemu 2.7.0 and above
> can receive lsc when vhost user disconnects. The patch updates doc to
> let user know that.

Thanks for updating the doc.

> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> ---
>  doc/guides/nics/virtio.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index 4d6a83768..c6f4e0ed2 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -291,6 +291,10 @@ interrupt, Rx interrupts, and Tx interrupts. Config interrupt is used for
>  notification of device configuration changes, especially link status (lsc).
>  Interrupt mode is translated into Rx interrupts in the context of DPDK.
>  
> +Note: Virtio PMD which works with qemu 2.7.0 and above can support to receive lsc from qemu
> +when vhost user disconnection happens since qemu 2.7.0 introduces the new capability to detect
> +vhost user disconnection.

I think it needs rewording. Also, use ".. Note::" mark for notes.

	--yliu
> +
>  Prerequisites for Rx interrupts
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> -- 
> 2.13.3

  reply	other threads:[~2017-10-10  2:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09  3:56 Zhiyong Yang
2017-10-10  2:38 ` Yuanhan Liu [this message]
2017-10-10  4:51 ` [dpdk-dev] [PATCH v2] doc: add virtio lsc note Zhiyong Yang
2017-10-12 12:43   ` Mcnamara, John
2017-10-16  5:41   ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2017-10-16 19:10     ` Mcnamara, John
2017-10-20 11:50       ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010023859.GO1545@yliu-home \
    --to=yliu@fridaylinux.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=zhiyong.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).