From: Yuanhan Liu <yliu@fridaylinux.org>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Cc: dev@dpdk.org, Pawel Wodkowski <pawelx.wodkowski@intel.com>,
jfreimann@redhat.com, maxime.coquelin@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3] rte_vhost: added user callbacks for socket open/close
Date: Tue, 10 Oct 2017 11:14:14 +0800 [thread overview]
Message-ID: <20171010031414.GQ1545@yliu-home> (raw)
In-Reply-To: <1504090258-164350-1-git-send-email-dariuszx.stojaczyk@intel.com>
On Wed, Aug 30, 2017 at 12:50:58PM +0200, Dariusz Stojaczyk wrote:
> Added new callbacks to notify about socket connection status.
> As destroy_device is used for virtqueue processing *pause* as well as
> connection close, the user has no distinction between those.
>
> Consider the following scenario:
> rte_vhost: received SET_VRING_BASE message,
> calling destroy_device() as usual
>
> user: end-user asks to remove the device (together with socket file),
> OK, device is not *in use* - that's NOT the behavior we want
> calling rte_vhost_driver_unregister() etc.
>
> Instead of changing new_device/destroy_device callbacks and breaking
> the ABI, a set of new functions new_connection/destroy_connection
> has been added.
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---
> v3: improved err-handling path and updated commit msg
> v2: also updated vhost_lib.rst
The doc update is missing. I have cherry-picked it from v2.
Applied to dpdk-next-virtio.
Thanks.
--yliu
prev parent reply other threads:[~2017-10-10 3:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:34 [dpdk-dev] [PATCH] vhost: " Dariusz Stojaczyk
2017-08-21 15:00 ` Jens Freimann
2017-08-22 9:55 ` Stojaczyk, DariuszX
2017-08-22 11:58 ` Jens Freimann
2017-08-22 12:10 ` Jens Freimann
2017-08-22 16:24 ` [dpdk-dev] [PATCH v2] " Dariusz Stojaczyk
2017-08-25 9:22 ` Jens Freimann
2017-08-29 6:08 ` Stojaczyk, DariuszX
2017-08-30 6:33 ` Jens Freimann
2017-08-30 10:50 ` [dpdk-dev] [PATCH v3] rte_vhost: " Dariusz Stojaczyk
2017-10-10 3:14 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010031414.GQ1545@yliu-home \
--to=yliu@fridaylinux.org \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=pawelx.wodkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).