* [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
@ 2017-10-10 14:56 Pavan Nikhilesh
2017-10-10 18:04 ` Jerin Jacob
2017-10-10 19:33 ` Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Pavan Nikhilesh @ 2017-10-10 14:56 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Pavan Nikhilesh
Use the event device get attribute function to fetch the event
port and queue count
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index d41904f..1e72d65 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -1242,8 +1242,10 @@ octeontx_probe(struct rte_vdev_device *dev)
if (res < 0)
goto parse_error;
- qnum = rte_event_queue_count(evdev);
- pnum = rte_event_port_count(evdev);
+ rte_event_dev_attr_get(evdev, RTE_EVENT_DEV_ATTR_PORT_COUNT,
+ (uint32_t *)&pnum);
+ rte_event_dev_attr_get(evdev, RTE_EVENT_DEV_ATTR_QUEUE_COUNT,
+ (uint32_t *)&qnum);
if (pnum < qnum) {
octeontx_log_err("too few event ports (%d) for event_q(%d)",
pnum, qnum);
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
2017-10-10 14:56 [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count Pavan Nikhilesh
@ 2017-10-10 18:04 ` Jerin Jacob
2017-10-10 18:16 ` Ferruh Yigit
2017-10-10 19:33 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2017-10-10 18:04 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: ferruh.yigit, dev, thomas
-----Original Message-----
> Date: Tue, 10 Oct 2017 20:26:15 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: ferruh.yigit@intel.com
> CC: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get
> count
> X-Mailer: git-send-email 2.7.4
>
> Use the event device get attribute function to fetch the event
> port and queue count
Hi Ferruh, Thomas
The rte_event_queue_count()/rte_event_port_count() APIs are removed in
next-eventdev. If next-eventdev changes first goes to master then next-net
will have build issue. Request to squash this patch in next-next
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> drivers/net/octeontx/octeontx_ethdev.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
> index d41904f..1e72d65 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -1242,8 +1242,10 @@ octeontx_probe(struct rte_vdev_device *dev)
> if (res < 0)
> goto parse_error;
>
> - qnum = rte_event_queue_count(evdev);
> - pnum = rte_event_port_count(evdev);
> + rte_event_dev_attr_get(evdev, RTE_EVENT_DEV_ATTR_PORT_COUNT,
> + (uint32_t *)&pnum);
> + rte_event_dev_attr_get(evdev, RTE_EVENT_DEV_ATTR_QUEUE_COUNT,
> + (uint32_t *)&qnum);
> if (pnum < qnum) {
> octeontx_log_err("too few event ports (%d) for event_q(%d)",
> pnum, qnum);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
2017-10-10 18:04 ` Jerin Jacob
@ 2017-10-10 18:16 ` Ferruh Yigit
2017-10-10 19:38 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-10 18:16 UTC (permalink / raw)
To: Jerin Jacob, Pavan Nikhilesh; +Cc: dev, thomas
On 10/10/2017 7:04 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Tue, 10 Oct 2017 20:26:15 +0530
>> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> To: ferruh.yigit@intel.com
>> CC: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get
>> count
>> X-Mailer: git-send-email 2.7.4
>>
>> Use the event device get attribute function to fetch the event
>> port and queue count
>
>
> Hi Ferruh, Thomas
>
> The rte_event_queue_count()/rte_event_port_count() APIs are removed in
> next-eventdev. If next-eventdev changes first goes to master then next-net
> will have build issue. Request to squash this patch in next-next
Hi Jerin,
Thanks for heads up, I will get this into next-net before next-eventdev
merged into main repo.
Thanks,
ferruh
>
>
>
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
<...>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
2017-10-10 14:56 [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count Pavan Nikhilesh
2017-10-10 18:04 ` Jerin Jacob
@ 2017-10-10 19:33 ` Ferruh Yigit
2017-10-11 1:20 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-10 19:33 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev
On 10/10/2017 3:56 PM, Pavan Nikhilesh wrote:
> Use the event device get attribute function to fetch the event
> port and queue count
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
2017-10-10 18:16 ` Ferruh Yigit
@ 2017-10-10 19:38 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-10 19:38 UTC (permalink / raw)
To: Jerin Jacob, Pavan Nikhilesh; +Cc: dev, thomas
On 10/10/2017 7:16 PM, Ferruh Yigit wrote:
> On 10/10/2017 7:04 PM, Jerin Jacob wrote:
>> -----Original Message-----
>>> Date: Tue, 10 Oct 2017 20:26:15 +0530
>>> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>>> To: ferruh.yigit@intel.com
>>> CC: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>>> Subject: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get
>>> count
>>> X-Mailer: git-send-email 2.7.4
>>>
>>> Use the event device get attribute function to fetch the event
>>> port and queue count
>>
>>
>> Hi Ferruh, Thomas
>>
>> The rte_event_queue_count()/rte_event_port_count() APIs are removed in
>> next-eventdev. If next-eventdev changes first goes to master then next-net
>> will have build issue. Request to squash this patch in next-next
>
> Hi Jerin,
>
> Thanks for heads up, I will get this into next-net before next-eventdev
> merged into main repo.
No, rte_event_dev_attr_get() is not defined, I assume this will come
with next-eventdev. So I will wait next-evendev merged before getting this.
>
> Thanks,
> ferruh
>
>>
>>
>>
>>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> <...>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count
2017-10-10 19:33 ` Ferruh Yigit
@ 2017-10-11 1:20 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-10-11 1:20 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev
On 10/10/2017 8:33 PM, Ferruh Yigit wrote:
> On 10/10/2017 3:56 PM, Pavan Nikhilesh wrote:
>> Use the event device get attribute function to fetch the event
>> port and queue count
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Squashed into relevant commit in next-net, thanks.
Commit: 485c30ac8c39 ("net/octeontx: add net device probe and remove")
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-11 1:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 14:56 [dpdk-dev] [PATCH] net/octeontx: use eventdev attributes to get count Pavan Nikhilesh
2017-10-10 18:04 ` Jerin Jacob
2017-10-10 18:16 ` Ferruh Yigit
2017-10-10 19:38 ` Ferruh Yigit
2017-10-10 19:33 ` Ferruh Yigit
2017-10-11 1:20 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).