From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 9E0B31B1B1 for ; Wed, 11 Oct 2017 12:42:17 +0200 (CEST) Received: by mail-lf0-f49.google.com with SMTP id g70so1566702lfl.3 for ; Wed, 11 Oct 2017 03:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hmKwRPxItpJWq5p9XaYXsXx/qWdgWsDWG4cWTSjFhqo=; b=0j3jS5Cp/YYRfGGQGH1EdihIGyRkV8tJS5pI4gg4p6EoUfj/tNb2TJtze92VJRd2qs 5bk6her1TOrsISrjEYLTwLytpBcPrhTcXOvKWBAmXvaJhPbR+H7gwsShmInKxjs9N387 nAj8rr4qsjFibpvo62yiUKi+vKYgBeCWf9VcgGJkz57OJX3UygbZlnojHFvlwESH/hyD LaxqcASJeiqzf/i2WylLzs8XWGWd+olVSlEFk8f7mjJ3tH8Al5YflA6KGPwwmKFQQSAl 2qTIPVNzVkWttdiDPd32GffBMCkB7dypy0oRlVqsNYt773sSIJM24xup/IVvYVVxf0oX hQ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hmKwRPxItpJWq5p9XaYXsXx/qWdgWsDWG4cWTSjFhqo=; b=meOvafa81mK7EYasjXdya2A0HNM4O4W7gZVnMlP26jo+MaBchxwB9gMlxLsmI/DeMo RIq279HUw2mBrIYYg3DCGv9koqW6ClpmtTCFWsKWsurA+HzPBl9qLhZ9N1iOOR2WaH9f PI+O1naN5rRevPg/PH2mIgVzCSp+zqh2W9u13KtYRvUeN/QMmg4NqLtxAwfpEJaffzM2 CQuV7ahxmk4IVWg2LT0ITjc2Iueu+pN7Ec4Fhkc1KTGLRQqYqMeCl8kz+FCOiYbl6+h/ TzAp9QseQ5s4ek/zd/1/pq/sOdRKLAzDCsDsEgoIIBEe+EZM2v2FlA/3wtBNRuxdJwwD YkKg== X-Gm-Message-State: AMCzsaU42PVRSXLxRWKO8i8m4+T9DTP71Njz0d4+z5O89hKkirYU/JgV TZLOwH/psJWp9YYtV8ho5BuhTg== X-Google-Smtp-Source: AOwi7QDs5CMajL0BqpZthvlBJeEtKI5UagGNPIaP2xktWxa6MlE4AjmP39p3s/VIgkpxlvRJG1QHLg== X-Received: by 10.46.65.194 with SMTP id d63mr5826410ljf.136.1507718537136; Wed, 11 Oct 2017 03:42:17 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id t10sm3005760lja.47.2017.10.11.03.42.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 03:42:15 -0700 (PDT) Date: Wed, 11 Oct 2017 12:42:15 +0200 From: Tomasz Duszynski To: "De Lara Guarch, Pablo" Cc: "Richardson, Bruce" , Tomasz Duszynski , "dev@dpdk.org" Message-ID: <20171011104215.GA14608@tdu> References: <1507713940-12268-1-git-send-email-tdu@semihalf.com> <20171011095800.GA43968@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 10:42:17 -0000 On Wed, Oct 11, 2017 at 10:09:02AM +0000, De Lara Guarch, Pablo wrote: > Hi, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Wednesday, October 11, 2017 10:58 AM > > To: Tomasz Duszynski > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value corre= ctly > > > > On Wed, Oct 11, 2017 at 11:25:40AM +0200, Tomasz Duszynski wrote: > > > snprintf return value is the length of was encoded into destination > > > array excluding '\0'. Thus return value equal to the length of the > > > destination array or more means truncation. > > > > > > This commit fixes improper use of the return value. > > > > > > Signed-off-by: Tomasz Duszynski > > > --- > > Good catch. > > > > Acked-by: Bruce Richardson > > Since this is a fix, you should add Fixes lines (one per PMD), and CC sta= ble. > > Thanks! > Pablo > ACK -- - Tomasz Duszy=C5=84ski