From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 4AF67201 for ; Thu, 12 Oct 2017 08:51:05 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id r129so4819148lff.8 for ; Wed, 11 Oct 2017 23:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Bp0epRmjjIr3rXrhkze88Ml/HjMjEVg1AxkEagMJRuk=; b=pQApEFPsWks8KsjgTh31Q3DEAoirVNKuVMSK0f5n+qSo9a7VMtW7o/yAVfxgbBlvsv Vs4NLjm3dX2nMI0R/4Xl6HCdjFouTAdiEXAsLSEkQZNJR6yChOOuS/RkW5C/6zKeoYAa ufxyvQ0ynNCoaJhiAzVox242iWc1zroO9pP+pwtkhcF01WpOkxpSWUTxXQtN9yJI4Qar IqGNViagyB2eI/8kgRyFWyvxioz0ocswBUWr82MssgxvnMY4Z/2RAtkyNKFwe+FWrhcf yOvYAQHDmu1Bl2AXpMTdXTPwNKTCyRp3qZ3wgmbq0A43cc4PQAwKDmUVuVblddZIIl8c p58w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Bp0epRmjjIr3rXrhkze88Ml/HjMjEVg1AxkEagMJRuk=; b=KsfihEKi8AZJxqoEeHgpNfD9Hdd/C7ypzfZDz+e03Z9almc2kc4eECeTkT07RZeMH/ A/WflbT8IWC2Z/yvii31Q3tJWbWzYeo5Bs4akup67Wve54Y4a6MGb2MC/araVYAi+5Th 4zgMIrVL+1eM02d7LRaha2SBwXWik+t24tYbFG17sRG2l6AOeYk8XVnb+FHV0XwkliNa eMNtG5jWmu3xeZgMGaNa4E9AjhHyfRkmBfyyv867g17NL0qU90TDZqMIvh3LvxUYuWvk K0bcYjPNYgQPpfdwYyYvT+9R/DYyfYAIS+z8plsCMglQGzxxIuaPUebxxy8p6P51IgmZ g+JA== X-Gm-Message-State: AMCzsaV/t75sqAYSwgk70IVFn7032Pii5I0ml0rNpRtIXRtFngE/YGyE uObBOu8m6+fFnPmb6zwTd2kycNipii8= X-Google-Smtp-Source: AOwi7QCopQIX/Odw5RCj2sKtAJ7WfwceS0gsY92MEd7JOiAuys8fT5E28Y14DE+ZPsJakuDDRhtYag== X-Received: by 10.46.46.12 with SMTP id u12mr599509lju.117.1507791065569; Wed, 11 Oct 2017 23:51:05 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id o41sm2635779lfi.93.2017.10.11.23.51.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 23:51:04 -0700 (PDT) Date: Thu, 12 Oct 2017 08:51:04 +0200 From: Tomasz Duszynski To: Thomas Monjalon Cc: Tomasz Duszynski , dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org, Jacek Siuda Message-ID: <20171012065104.GC19106@tdu> References: <1507031500-11473-1-git-send-email-tdu@semihalf.com> <1507561244-20115-1-git-send-email-tdu@semihalf.com> <1507561244-20115-3-git-send-email-tdu@semihalf.com> <9041127.34t6OW5FrT@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <9041127.34t6OW5FrT@xps> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 06:51:06 -0000 On Wed, Oct 11, 2017 at 03:38:36PM +0200, Thomas Monjalon wrote: > Hi, > > 09/10/2017 17:00, Tomasz Duszynski: > > # > > +# Compile Marvell PMD driver > > +# > > +CONFIG_RTE_LIBRTE_MRVL_PMD=3Dn > > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=3Dn > > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=3D41943040 > > We are trying to remove build-time configurations and behave like > a true library. > > The DEBUG config options are now prohibited. > Where is it used in your code? > If it is used for logs, you should switch to the dynamic log config. > > What is MUSDK_DMA_MEMSIZE? > If the value cannot change, it must be a constant in the code. > If it can change, it should be a run-time driver option. It's up to the user what MUSDK_DMA_MEMSIZE is going to be. Currently it's set to value that should work it all cases. Except that, MUSDK_DMA_MEMSIZE is used as synchronization point for net and crypto (on condition they are used together i.e ipsec-secgw). Suppose we have two different MUSDK_DMA_MEMSIZE defined for net/crypto then dma memsize allocated will depend on driver probing sequence which might confuse user. If you have any better idea please share it with us. Thanks. > > Thank you and welcome -- - Tomasz Duszy=C5=84ski