From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 124501B235 for ; Thu, 12 Oct 2017 12:55:08 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id l68so12170423wmd.5 for ; Thu, 12 Oct 2017 03:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nPPzfWWPleci8YQnai5VVRH9+gkY7dTVTe0V9/O87ds=; b=cpWeu4L//BHTlKt7HyeRx29e7ZThWJw0gUOP2VuryfXsBgOyptmP3ETRbv7l0jLGug lqAT/vIA9MoueEn//IeW1zaHszDu7A3K5HN+WK6afUcwND9IY9OKwtrNDRLqPUP9me4N bWu0ZTSikHI99B8zb/jtQge3hIYwd/7nUAxSGsWHKYLJQsUR1Cid4izbIwU+pHJWXcsX e0WMwdyRzNI+nQREhq4MoRdy9Y0KuErs7sIC8+X2d7U9dDLVPSpyq6vAELfHWorGzJaw oIIVID4oUDRn/niEPkqxx3jkI8dCWMjxEVPvJqYXvixDOdwokT7Cf00Y5KgDp371Mc87 Usrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nPPzfWWPleci8YQnai5VVRH9+gkY7dTVTe0V9/O87ds=; b=JVSTjZlEgN1+tnLmVRpfdH7RN8rEly+N4RkFxA4nYX5jFiU8uhOMURxxO5FCWhbwcW J1Xm3m5NTcCvRqp11hr86zPSSydCNHWtjo80pwwwanm6OeS39FcGJFA314XxsMt58/0B 2ZV9SAHIiMSQ03jhnZxfK+pzy7Ze+PVBsV73zJH0dZ+mC1Ps9qSXh/qZ9KHlr2DKl3Lo 47c1pkzcgzs5WdTjN6OBTdz928IcL4fgMDuS86AvulYJcN8j82hh4I98e5+INh1geT5a SZdAID/BU8nhaDkwMNjc46J7uU+IjKfCQ1Bblj6FJg2Z8PnQvPltnKb6eVI9a1fXtVZE zo1w== X-Gm-Message-State: AMCzsaUsuMicrkZyId0CmPBDNtMaZap56PNovQqmzZ7sr30UyYKtbmUg +ye++eQGAnVMv5kI0AxIplT4ujGd X-Google-Smtp-Source: AOwi7QA1DKGjx24KG9s312Nibo2dw9yNg+51Ouu9MNl2EfuTXAvU5+YR+90iSB04BK4bPVkU7konjA== X-Received: by 10.28.173.131 with SMTP id w125mr1785920wme.126.1507805708098; Thu, 12 Oct 2017 03:55:08 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s18sm1701436wrg.87.2017.10.12.03.55.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 03:55:07 -0700 (PDT) Date: Thu, 12 Oct 2017 12:54:52 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: dev@dpdk.org Message-ID: <20171012105452.GA3408@bidouze.vm.6wind.com> References: <11d452f841b11e646d6b905b5ff40173ee7584a3.1507804944.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11d452f841b11e646d6b905b5ff40173ee7584a3.1507804944.git.gaetan.rivet@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 18/20] bus/pci: do not expose IOVA mode getter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 10:55:09 -0000 On Thu, Oct 12, 2017 at 12:45:45PM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > drivers/bus/pci/private.h | 10 ++++++++++ > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 - > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 - > 3 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index b91217b..2283f09 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -235,4 +235,14 @@ int > rte_pci_match(const struct rte_pci_driver *pci_drv, > const struct rte_pci_device *pci_dev); > > +/** > + * Get iommu class of PCI devices on the bus. > + * And return their preferred iova mapping mode. > + * > + * @return > + * - enum rte_iova_mode. > + */ > +enum rte_iova_mode > +rte_pci_get_iommu_class(void); > + Made a mistake here while rebasing. The function declaration should be removed from drivers/bus/pci/include/rte_bus_pci.h as well. > #endif /* _PCI_PRIVATE_H_ */ > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > index 1c18ca5..1d879a1 100644 > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > @@ -228,6 +228,5 @@ DPDK_17.11 { > rte_eal_iova_mode; > rte_eal_mbuf_default_mempool_ops; > rte_lcore_has_role; > - rte_pci_get_iommu_class; > > } DPDK_17.08; > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > index 827bcd4..1334433 100644 > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -232,6 +232,5 @@ DPDK_17.11 { > rte_eal_iova_mode; > rte_eal_mbuf_default_mempool_ops; > rte_lcore_has_role; > - rte_pci_get_iommu_class; > > } DPDK_17.08; > -- > 2.1.4 > -- Gaëtan Rivet 6WIND