From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9AB321B68E for ; Fri, 13 Oct 2017 11:43:54 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C58FD883C6; Fri, 13 Oct 2017 09:43:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C58FD883C6 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jfreimann@redhat.com Received: from localhost (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 391EE619A4; Fri, 13 Oct 2017 09:43:48 +0000 (UTC) Date: Fri, 13 Oct 2017 11:43:47 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, yliu@fridaylinux.org, lei.a.yao@intel.com, thomas@monjalon.net Message-ID: <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com> References: <20171013093021.3196-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20171013093021.3196-1-maxime.coquelin@redhat.com> User-Agent: NeoMutt/20170914 (1.9.0) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 13 Oct 2017 09:43:53 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fetch again ring_addrs address after NUMA reallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 09:43:54 -0000 On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote: >In case of NUMA reallocation, the virtqueue struct is reallocated >on another socket, meaning that its address changes. > >In translate_ring_addresses(), addr pointer was not fetched again >after the reallocation, so it pointed to freed memory. > >This patch just fetch again addr pointer after the reallocation. > >Reported-by: Yao, Lei A >Tested-by: Yao, Lei A >Signed-off-by: Maxime Coquelin >--- > lib/librte_vhost/vhost_user.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Jens Freimann