From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3F8FA1AEEB for ; Fri, 13 Oct 2017 13:23:23 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5B0A1293; Fri, 13 Oct 2017 11:23:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D5B0A1293 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jfreimann@redhat.com Received: from localhost (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACBC26EE30; Fri, 13 Oct 2017 11:23:15 +0000 (UTC) Date: Fri, 13 Oct 2017 13:23:14 +0200 From: Jens Freimann To: Maxime Coquelin Cc: yliu@fridaylinux.org, thomas@monjalon.net, dev@dpdk.org Message-ID: <20171013112314.3izkbzhavrjztut3@dhcp-192-218.str.redhat.com> References: <20171012153850.21837-1-maxime.coquelin@redhat.com> <20171012153850.21837-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20171012153850.21837-3-maxime.coquelin@redhat.com> User-Agent: NeoMutt/20170914 (1.9.0) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 13 Oct 2017 11:23:23 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix IOTLB on NUMA realloc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 11:23:24 -0000 On Thu, Oct 12, 2017 at 03:38:50PM +0000, Maxime Coquelin wrote: >In case of NUMA reallocation, virtqueue's iotlb list is broken, >has its head changes but first iotlb entry in the list still points >to the previous head pointer. > >Also, in case of reallocation, we want the IOTLB cache mempool to be >on the new socket. > >This patch perform a full re-init of the IOTLB cache when mempool >already exists, and calls the IOTLB cache init function in case >the virtqueue is being reallocated on a new socket. > >Signed-off-by: Maxime Coquelin >--- > lib/librte_vhost/iotlb.c | 1 - > lib/librte_vhost/vhost_user.c | 3 +++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c >index 05c278040..b74cc6a78 100644 >--- a/lib/librte_vhost/iotlb.c >+++ b/lib/librte_vhost/iotlb.c >@@ -309,7 +309,6 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index) > */ > vhost_user_iotlb_cache_remove_all(vq); > vhost_user_iotlb_pending_remove_all(vq); >- return 0; > } > > #ifdef RTE_LIBRTE_VHOST_NUMA Reviewed-by: Jens Freimann