From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 68A0D1B612
 for <dev@dpdk.org>; Mon, 16 Oct 2017 13:17:49 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id i124so2042754wmf.3
 for <dev@dpdk.org>; Mon, 16 Oct 2017 04:17:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:content-transfer-encoding:in-reply-to
 :user-agent; bh=dNhRjRB+lk+c/CA7xLyEZsHCFjbnX0kJosS3Be93C7k=;
 b=jRNUsldAa2IyQ6tVi/eoLvJqArwnVCX6m6IejzPs88Il7126IabKq4cbTwBkLMcLYm
 Zz3m3b9V75q7BnnDkWpk3ooHbaaIDNzE92hs21iwJj3Ln+4k3w+gyhZQAi8FULvPv+AH
 nwVVTGV5D1LU9VQ+BDlyaroJdUNE7Hr/Fb4KjTlHh/WGJIxDahwuxSyajn2z5lrhj4tr
 vegdAvMFPveUmdB8dvpMX4iMyyrEKPw1U945MAs9bYB+Um1pzsBbrAvtHNA5937KMRht
 MaH5A0f70q554Q0ot+2pvcIbKow8OTHyd8k+QJzEIZmioCbiqOIWR4MNY6pY/jJCCSav
 jZWQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:content-transfer-encoding
 :in-reply-to:user-agent;
 bh=dNhRjRB+lk+c/CA7xLyEZsHCFjbnX0kJosS3Be93C7k=;
 b=b2uFyxRXgxTRN03YBxw3wKt8AvJyZI4JgArXto1aQ0ApxBJaCribfgWohWigSoe5Xe
 9XVPdEIsvGBPFZIH4rPICpzQfkAr/1qQqg2JrZb3QDIlp4wyiHgW0WB2fSXTwIlAbkq+
 i7qz+lSN0LO/eqfEM0lOjA/HhQBg5naB0uru7Np1WY5YUkceA0xC8M4pHJJFjwS8HANK
 yT8nEt0CWfrMb0W1srvroEzlOUdpHVi3Wi0yjN8cyPVcdwnIwR8tXVER/ujJZKPYP0V/
 /jG1RZIfMDIgrP/fmBPX08pPw4h8P+IxtMO/KgL11Pdn9eZyWABVlAgZZh65dgMo8TUc
 8nqQ==
X-Gm-Message-State: AMCzsaVE2Tmf9UP7MhSxC4zOPZ73XeSpEuHkXDTIdFyTZtMMwUWTC9VG
 O568BFepDkchpWE0aEfoeR2DSWaAfw==
X-Google-Smtp-Source: ABhQp+Sa9ApRN/IqWtub+79VwYrf0g11nW9uZpDTWtyxecTXGQtIMOHL91RwWAH5PptHCQl1fLMfVA==
X-Received: by 10.28.191.131 with SMTP id o3mr528831wmi.113.1508152668923;
 Mon, 16 Oct 2017 04:17:48 -0700 (PDT)
Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com.
 [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id o24sm9792699wmi.39.2017.10.16.04.17.48
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 16 Oct 2017 04:17:48 -0700 (PDT)
Date: Mon, 16 Oct 2017 13:17:42 +0200
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Ori Kam <orika@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org
Message-ID: <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm>
References: <1508142759-24829-1-git-send-email-orika@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1508142759-24829-1-git-send-email-orika@mellanox.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 11:17:49 -0000

On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote:
> Signed-off-by: Ori Kam <orika@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  doc/guides/nics/mlx5.rst |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index d24941a..7da5c87 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -104,7 +104,8 @@ Limitations
>  -----------
>  
>  - Inner RSS for VXLAN frames is not supported yet.
> -- Port statistics through software counters only.
> +- Port statistics through software counters only. Flow statistics are
> +  supported by hardware counters.
>  - Hardware checksum RX offloads for VXLAN inner header are not supported yet.
>  - Forked secondary process not supported.
>  - Flow pattern without any specific vlan will match for vlan packets as well:
> @@ -127,6 +128,8 @@ Limitations
>  - A multi segment packet must have less than 6 segments in case the Tx burst function
>    is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have
>    less than 50 segments.
> +- Count action for RTE flow is only supported in OFED 4.2.
> +- Two identical rules with count action are not supported.

This last line does not bring anything, having two identical rules
already create a collision which is not defined by the flow API.
In PMD situation is is even worse, as it will match both rules and
thus it will duplicate a packet.

There is no need to add a limit on an undefined behavior by the
API itself.

Thanks,

PS: when you send a new revision, please use the --thread and
--in-reply-to to link it with the previous one.

-- 
Nélio Laranjeiro
6WIND