From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <nelio.laranjeiro@6wind.com> Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 920A61B669 for <dev@dpdk.org>; Mon, 16 Oct 2017 14:36:32 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id m72so2804587wmc.1 for <dev@dpdk.org>; Mon, 16 Oct 2017 05:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ojJMKCDfW36jYlftCwrg8QJ/8TjFS4+PQ7zra+lrOpA=; b=gOSk6PNwPf6KGeFg1MxTcTg/zCzTgLvc0QIQ5UIDwMzVQZ7He0g2c47B7IHQG/9aMu 0jgmlm5TeFgfmarjeHMb6Sa2l8Nz96JgIi9HeBcNjzX+qWgvbNaY215bvbmmjvSn4Vqd uvLTP2G9zAABvqKpAjFDXJrQllS2DB+3td3+AbYX7oSWKPj+mpgyMf/c9dlASJZ7cvFj gqKigdsw07M24iq2ac4VY2HblcWHm7zim49mHdJB60bEMpWsqBRPZ+1bOiCeoUr7bFx6 5Is9wAVIoXrWrTe98Pkj1knj7p2y9akbh5OybFRgr5n9KpiwtA6uuHmYjCBjzPelxAjv BYOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ojJMKCDfW36jYlftCwrg8QJ/8TjFS4+PQ7zra+lrOpA=; b=tUqqA+pRPeIzrmD3iSY1+bFE+Fff9u6dUgO0J59iaRe3hggQCHC56mbC3R7NWHuVoc 46UgMmYL6OLRamXs24DrnzivfP7JlO/Ov2m4Tzw/Dy9sOWHfgsin4s9tCK5F1A6rgvC1 JY7JBbFt7QlLnzZkDYoRRV5cTD+ZHPSReKCrqBA8kbl0P68jwZDZniWYwGecyvWDI+uk 0bGT9S42aJZF97/eJDpHE1qx3nePDq0rGeth7R0y9MdOc3sjpWIBnc9L6MTzSY4Qy4nB H7V887AW0fhf6VZz5CefiE+RUMU/EkA11uBYPE/HIMXwqGrBDXBWrZUbyjWbf3WwFFIl ZLjg== X-Gm-Message-State: AMCzsaWjNihEFzEVcc0jwJ5ODbSIoksVygbjktVxwK0YI2KvKcDZErsZ 79txmRvujUyvrKuppEnFFzid X-Google-Smtp-Source: ABhQp+QcBnmEgO3od492/xB+7P8m2d5x8hVeo76rqNYuIwEYJ7+6urxd/TlfeGFVjK8yDuq2DDEF1g== X-Received: by 10.223.146.101 with SMTP id 92mr433876wrj.21.1508157392277; Mon, 16 Oct 2017 05:36:32 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u18sm9492561wrg.94.2017.10.16.05.36.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Oct 2017 05:36:31 -0700 (PDT) Date: Mon, 16 Oct 2017 14:36:25 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com> To: Ori Kam <orika@mellanox.com> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> Message-ID: <20171016123625.pjm7kvrfdfqxobiz@laranjeiro-vm> References: <1508142759-24829-1-git-send-email-orika@mellanox.com> <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> <AM4PR05MB3202C026EC42DD57B30B45F2DB4F0@AM4PR05MB3202.eurprd05.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <AM4PR05MB3202C026EC42DD57B30B45F2DB4F0@AM4PR05MB3202.eurprd05.prod.outlook.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 16 Oct 2017 12:36:32 -0000 On Mon, Oct 16, 2017 at 11:31:32AM +0000, Ori Kam wrote: > Please see my comments, > > > -----Original Message----- > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Monday, October 16, 2017 2:18 PM > > To: Ori Kam <orika@mellanox.com> > > Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Yongseok Koh > > <yskoh@mellanox.com>; dev@dpdk.org > > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations > > > > On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote: > > > Signed-off-by: Ori Kam <orika@mellanox.com> > > > Acked-by: Shahaf Shuler <shahafs@mellanox.com> > > > --- > > > doc/guides/nics/mlx5.rst | 5 ++++- > > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > > > d24941a..7da5c87 100644 > > > --- a/doc/guides/nics/mlx5.rst > > > +++ b/doc/guides/nics/mlx5.rst > > > @@ -104,7 +104,8 @@ Limitations > > > ----------- > > > > > > - Inner RSS for VXLAN frames is not supported yet. > > > -- Port statistics through software counters only. > > > +- Port statistics through software counters only. Flow statistics are > > > + supported by hardware counters. > > > - Hardware checksum RX offloads for VXLAN inner header are not > > supported yet. > > > - Forked secondary process not supported. > > > - Flow pattern without any specific vlan will match for vlan packets as well: > > > @@ -127,6 +128,8 @@ Limitations > > > - A multi segment packet must have less than 6 segments in case the Tx > > burst function > > > is set to multi-packet send or Enhanced multi-packet send. Otherwise it > > must have > > > less than 50 segments. > > > +- Count action for RTE flow is only supported in OFED 4.2. > > > +- Two identical rules with count action are not supported. > > > > This last line does not bring anything, having two identical rules already > > create a collision which is not defined by the flow API. > > In PMD situation is is even worse, as it will match both rules and thus it will > > duplicate a packet. > > > > There is no need to add a limit on an undefined behavior by the API itself. > > > > The thing is that when you try adding duplicate rules without the count it works > without any error while if you add the count action then for the second rule you get an error. > This line address this inconsistency. According to Flow API documentation [1] "If a packet is matched by several rules of a given group for a given priority level, the outcome is undefined. It can take any path, may be duplicated or even cause unrecoverable errors." This is already documented and application makers should avoid it. There is no need to duplicate this information. > > Thanks, > > > > PS: when you send a new revision, please use the --thread and --in-reply-to > > to link it with the previous one. > > > > > My bad, > > > -- > > Nélio Laranjeiro > > 6WIND > > Regards, > Ori Kam Thanks, [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html -- Nélio Laranjeiro 6WIND