DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: lei.a.yao@intel.com, dev@dpdk.org, jfreiman@redhat.com,
	thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2] vhost: translate addrs in set_vring_addr if ring already enabled
Date: Tue, 17 Oct 2017 21:13:54 +0800	[thread overview]
Message-ID: <20171017131354.GW1545@yliu-home> (raw)
In-Reply-To: <20171016145627.19990-1-maxime.coquelin@redhat.com>

On Mon, Oct 16, 2017 at 04:56:27PM +0200, Maxime Coquelin wrote:
> Commit 3ea7052f4b1b ("vhost: postpone rings addresses translation")
> moves rings addresses translation at either vring kick or enable
> time, depending on whether protocol features are enabled or not.
> This is done not interpret ring information as long as the vring
> is not fully initialized.
> 
> The problem is that with old QEMU versions, like v2.5, the ring
> is enabled before addresses are sent, so addresses are never
> translated.
> 
> This patch fixes the issue by doing the translation in
> VHOST_USER_SET_VRING_ADDR handling if ring is already enabled.
> 
> Fixes: 3ea7052f4b1b ("vhost: postpone rings addresses translation")
> 
> Reported-by: Lei Yao <lei.a.yao@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> v2: Fixed commit informations (Fixes:, Reported-by:)

Applied to dpdk-next-virtio.

Thanks.

	--yliu

      reply	other threads:[~2017-10-17 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 14:22 [dpdk-dev] [PATCH] " Maxime Coquelin
2017-10-16 14:56 ` [dpdk-dev] [PATCH v2] " Maxime Coquelin
2017-10-17 13:13   ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017131354.GW1545@yliu-home \
    --to=yliu@fridaylinux.org \
    --cc=dev@dpdk.org \
    --cc=jfreiman@redhat.com \
    --cc=lei.a.yao@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).