From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id CADD21B74E for ; Tue, 17 Oct 2017 15:14:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 3A4DFADA; Tue, 17 Oct 2017 09:14:00 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 17 Oct 2017 09:14:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=5niB46q/GGDIQXq2RRs7SCGW0PVyP7eiAjv0G09aP2I=; b=MGCOa+xl on/QfcBG5Npy1BXCfP2uetRIhM/uNS5l9nKDq+wcepTjNXhJUCIf6GogPMu00hWB IZbwhC0PvRR3FWJy2DDAooSmLtqK/bf/rnDokTkfBfTvP54jsEe96MVsUtGV35F3 U813d76/uwv8GPwFdgsHO7UWCMcIR4dgRVnkF5Sx530ZNPizkphAIqw7VQeb2H+z ZHb05IHz1J2qbx8nyUBKiaEd4tXB9BXcWFa6inZzGj/2VZJ7LpsxnyiOVGPDSA+Q nGjDbUaXK15rsplZ66lozgjZOkH7xu1ThOPOcaF40YTnIu2Xghg2N7zNjVnjJd5g JdiyABhsXAhQAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=5niB46q/GGDIQXq2RRs7SCGW0PVyP 7eiAjv0G09aP2I=; b=jhTKct1k7ASf/FNPgQORH6zvjRB0PA9v3MX7ijFfTLeg5 RS8pvc/UeUSLROHA5u7O3o9FKuMrE68lVrt3tx+50708aJpdM0vNubFz+DX+GOPl XOVqjqknThb9RT7XvUt8YtEdeT3EUJRwVQJNJWLnZ5cuLox/OnJEgtW//VoxN0eT qu2cyP55QFF9Z7355DY/5GonN7S4gqvSvJaOLUBKfsN8UO1KSZRJSCB8PqLnLOsV CzFrhqyHBbsaJmmOp66E2za9xR+pZwZmfsX0Hirw4sMmT9HD8gFB88JIRRGlsGFZ 2eedHOPEqEYhDheN67ZgmMEWgBsbPDCcdsF/0g9Bg== X-ME-Sender: Received: from yliu-home (unknown [124.79.168.36]) by mail.messagingengine.com (Postfix) with ESMTPA id E807B7F961; Tue, 17 Oct 2017 09:13:58 -0400 (EDT) Date: Tue, 17 Oct 2017 21:13:54 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: lei.a.yao@intel.com, dev@dpdk.org, jfreiman@redhat.com, thomas@monjalon.net Message-ID: <20171017131354.GW1545@yliu-home> References: <20171016142217.19646-1-maxime.coquelin@redhat.com> <20171016145627.19990-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016145627.19990-1-maxime.coquelin@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] vhost: translate addrs in set_vring_addr if ring already enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 13:14:01 -0000 On Mon, Oct 16, 2017 at 04:56:27PM +0200, Maxime Coquelin wrote: > Commit 3ea7052f4b1b ("vhost: postpone rings addresses translation") > moves rings addresses translation at either vring kick or enable > time, depending on whether protocol features are enabled or not. > This is done not interpret ring information as long as the vring > is not fully initialized. > > The problem is that with old QEMU versions, like v2.5, the ring > is enabled before addresses are sent, so addresses are never > translated. > > This patch fixes the issue by doing the translation in > VHOST_USER_SET_VRING_ADDR handling if ring is already enabled. > > Fixes: 3ea7052f4b1b ("vhost: postpone rings addresses translation") > > Reported-by: Lei Yao > Signed-off-by: Maxime Coquelin > --- > v2: Fixed commit informations (Fixes:, Reported-by:) Applied to dpdk-next-virtio. Thanks. --yliu