From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] event/octeontx: add support for event Rx adapter
Date: Wed, 18 Oct 2017 13:42:20 +0530 [thread overview]
Message-ID: <20171018081219.GA15923@PBHAGAVATULA-LT> (raw)
In-Reply-To: <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com>
On Tue, Oct 17, 2017 at 04:41:44PM +0530, Rao, Nikhil wrote:
<snip>
> > static __rte_always_inline uint16_t
> > ssows_get_work(struct ssows *ws, struct rte_event *ev)
> > {
> >@@ -62,9 +86,10 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev)
> > ws->cur_tt = sched_type_queue & 0x3;
> > ws->cur_grp = sched_type_queue >> 2;
> > sched_type_queue = sched_type_queue << 38;
> >-
> > ev->event = sched_type_queue | (get_work0 & 0xffffffff);
> >- ev->u64 = get_work1;
> >+ ev->u64 = get_work1 && !ev->event_type ?
>
> I think the code readability would be better if you compared event_type to
> RTE_EVENT_TYPE_ETHDEV.
>
Agreed,
Will send out a v2.
Thanks,
Pavan.
> Reviewed by: Nikhil Rao <nikhil.rao@intel.com>
next prev parent reply other threads:[~2017-10-18 8:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 8:53 [dpdk-dev] [PATCH 1/3] net/octeontx: " Pavan Nikhilesh
2017-10-17 8:53 ` [dpdk-dev] [PATCH 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-17 11:11 ` Rao, Nikhil
2017-10-18 8:12 ` Pavan Nikhilesh Bhagavatula [this message]
2017-10-24 14:27 ` Jerin Jacob
2017-10-17 8:53 ` [dpdk-dev] [PATCH 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-18 8:48 ` Mcnamara, John
2017-10-18 9:06 ` Pavan Nikhilesh Bhagavatula
2017-10-17 9:29 ` [dpdk-dev] [PATCH 1/3] net/octeontx: add support for event Rx adapter Bhagavatula, Pavan
2017-10-18 8:45 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-10-18 8:45 ` [dpdk-dev] [PATCH v2 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-18 8:45 ` [dpdk-dev] [PATCH v2 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-18 8:52 ` Mcnamara, John
2017-10-23 18:09 ` [dpdk-dev] [PATCH v2 1/3] net/octeontx: add support for event Rx adapter Jerin Jacob
2017-10-24 6:56 ` Pavan Nikhilesh Bhagavatula
2017-10-24 8:10 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2017-10-24 8:10 ` [dpdk-dev] [PATCH v3 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-24 8:10 ` [dpdk-dev] [PATCH v3 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-24 13:00 ` [dpdk-dev] [PATCH v4 1/3] net/octeontx: add support for event Rx adapter Pavan Nikhilesh
2017-10-24 13:00 ` [dpdk-dev] [PATCH v4 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-24 13:00 ` [dpdk-dev] [PATCH v4 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-24 14:21 ` [dpdk-dev] [PATCH v4 1/3] net/octeontx: add support for event Rx adapter Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018081219.GA15923@PBHAGAVATULA-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).