From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0060.outbound.protection.outlook.com [104.47.38.60]) by dpdk.org (Postfix) with ESMTP id E09BD1B5FE for ; Wed, 18 Oct 2017 10:12:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UmWvQaO5hzTwCZSYlsNDRH1QQU3pLFQY85/QnRXy20g=; b=JcMP2T8PRA9WzEk/XO0zBw5XgXnsFOCeyfghQ0vwHV36HqWHHkHkexLtJmOKc69doLgE+jM8Y0vRTcvtoHm5HwLFcsKdu05i34Z17f0tvcQqIPg8/xqxE+b1dbz6usRBWF0kZSheasHU/IFFjQGSJWH0usDVGmOgr23XgDLINLI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from PBHAGAVATULA-LT (111.93.218.67) by BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 18 Oct 2017 08:12:40 +0000 Date: Wed, 18 Oct 2017 13:42:20 +0530 From: Pavan Nikhilesh Bhagavatula To: "Rao, Nikhil" Cc: dev@dpdk.org Message-ID: <20171018081219.GA15923@PBHAGAVATULA-LT> References: <1508230393-27018-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508230393-27018-2-git-send-email-pbhagavatula@caviumnetworks.com> <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0033.INDPRD01.PROD.OUTLOOK.COM (10.174.214.19) To BN6PR07MB3460.namprd07.prod.outlook.com (10.161.153.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79adeac2-24ec-4e79-052c-08d5160000c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:BN6PR07MB3460; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 3:64PIJRzuaPodkxPo9ejXge/uFx1ZHbbSJm8eblsY2zwRJ9ArjhuVEvmIVAymfZ7mMYjGeEtqWc72k5w8j1qE3meTfBVk3vITdqD9vHxubQQVtmC6nn7nSjI21pex1kksJU5IWO1LwhAdo+BZ67MbDaQ0V5mVTkRhcqAL+C31HTYX34E8kyXf60qpiX04PkJnGRQlBP4ke0NadjqxG8iOl+n3oqBd3uCmU+K20SAKWF3iGjdvs+seE6XT3tIbdSek; 25:cTMRBoQ2qvNu37VJdvQXTN+0/FX+qKdYo3XHg48Bai4L9N8+53+XGnMt0SupyHTsE85dY+tGYUBrI3249vMSR/DR2kMz/UD62Q9/y+kUocs8Fuzi363FEgvYDjnXujbTJlGbdKulYwah5z9j80SyOdT4OAndGLHE8hQ7vk5tAquFZuwYdfxGZbcJWobEUWh/THxlaJSO99fBpqWFwDbJyAkn9PnV8nMkQm3MnJvVRWf/pIqolK5KFm2tjz4/JPD/fKzV1O8s9QUWT/a8uaYiifMok7nwQoNh7K+G1T9Ii1pcSovtUG759TeitKpSxzshdPxBZV6/yvol1MGxVQXEfA==; 31:tSjeSpif0rfRHz4xjiFMKTSQg3A1V/NuN5lBeO3FKu255D6wbPPGL7hi9YSU+ZyfDX+dyw2yiuMFNEXWU8ePl/hy2KfJEzbo5UOMUot6pdQNrCQHj0RHWCHupfAQ6EvfwjXhs4OpY+igYRBZHMHaIAwhBpepm8OD758/ID8bWhfpopjffbTLLW5gD3zoJG7BLLgEW8ySuu5JKTU3DOgdxDQ7kgqaIVOImeVxUdxTWGI= X-MS-TrafficTypeDiagnostic: BN6PR07MB3460: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 20:wqUQExD0ocPOcNdDjjvA6Tj5UzU2uP5h7+gc9u6CH8y9YE53ro9J1oHefAvRVqB0UyTYI8Ouo4NktxdzcaYYUODipGloMGbAALYrWVFr2jiuDZBy5x/FAeAEmKgfZxdnQYB0fM79TmYZNfYrXrPwXrAbvetB16w7acXaIJN1L8b6Y+Y/2+95ioGpAQMjqGcD0l5/F7v6Uz9S315Dl9BN9dQUtYGsTv54Mr+zO70I6PNA6pVbonCGH42begqbm2jHmLnF03XH8M+njQhQBTKUqS1pkg4rtbt6Gxw+nCZ0quZc2Wye1BrqybBVd0B1/uWeXs76UMfgZQ3KyB5IH3nWyQdBqYn/BRIUdSgIka/D6qYemEwZMxkSaBjKZuErk7gnK4QDM6F4VdfG9UhNRyXWyWdghgZiwUuIEoNvH7cWwM2nwB2IoKvJxSOehPAL/4ZJ1CMKH2gI36biP8uOB8908Bo9RM8s2jpv7XwYpqC+JovFqU7Ppp8vuv3RyWgA51EMy1JY0lHxXn1+LySOKTwtTtMrXsx2cR1DbC4LM/Sku6PLjGxxRLiAwFomQZuVd91DOTaWIJNQSvzIYc9mSDTZajSiV+hhsZ39J7iYVQZyyVc=; 4:ihDzI3ewNTnVRnv4RRY/UIEKFCBf5Apt7ffOzEMmwCYp/zVC1avl6AfbxbNwcsWnNHT8vg2WtV2t5kApZ8/l0+1WcOWUA9Z8AEPpZDo1edaC5t3b/c0oj5ClAZaNDlxd2+WtivOh8ZEj+w9KKPLomUnm4yTe5HPWoHx9OhcKHfGuo4rQ/DQSZiKr+krkVUYbsa871c8o2ViiPvW/jRIs7Mof/zdVtl/oo4BX1MAak3fjrw3uL3jBFWdot0Higv/NKqebjLoWUMS9h4NjypWMhbDVy2nAfla3FrEnVCDgj98= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(100000703101)(100105400095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR07MB3460; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR07MB3460; X-Forefront-PRVS: 0464DBBBC4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(24454002)(199003)(189002)(83506001)(23726003)(72206003)(4326008)(2906002)(66066001)(81156014)(3846002)(16526018)(81166006)(6116002)(50466002)(189998001)(305945005)(33716001)(47776003)(229853002)(1076002)(8936002)(97736004)(6666003)(25786009)(478600001)(106356001)(8676002)(58126008)(42882006)(6916009)(33656002)(9686003)(2950100002)(105586002)(101416001)(6246003)(6496005)(16586007)(68736007)(53936002)(5009440100003)(76176999)(54356999)(50986999)(5660300001)(55016002)(7736002)(316002)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3460; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3460; 23:1imAK1zKRgJbzMiVYgLKqshErMqLME9PGrYmv2d8q?= =?us-ascii?Q?pTCDpES6a8cWU1/p/KavAXy/7gxOzWi9AVqiumJAOWAHLuR621u5ZIsavlTp?= =?us-ascii?Q?lCTVbKnMJTVCBaXQ2s+1qmCRcnjeboRsCcTaHcmXV7nYumQf1xTsVF5KiP9k?= =?us-ascii?Q?/d6T5AawC3Acjq0nx3iqsZo7j+9KlXoTWjC1vDsbvWK5KiT3PCxnervW6t4b?= =?us-ascii?Q?pm/sYrf09Sa6pe6FsK0E8bYbWHS5oHsuqA6AgI9pBT/bsE67xQiFBF+pgLJY?= =?us-ascii?Q?YiMjrJPcgD/Loftog656hD1Be4sg10MiBlqCwfKOlB6UOJ5OIb0fZ6017pzq?= =?us-ascii?Q?zf7yXGQtgzQ0tw4gQfvtFK/DuUxIRxdZ7BnHy9bBBbnZMilksiDN4F/4A1Xg?= =?us-ascii?Q?kBWbHBAALC7/tSc/8TjCfXGVBknWTNtBKb96OeRalUCFcMXrY9DxrASc5RXW?= =?us-ascii?Q?VTCb02BXKBAA7i52dvDZ1O9XZ0Ue30Js34L3paeZwnQa0Z4qMHiZ5+Tc30S4?= =?us-ascii?Q?WZaAhnW8WeOvinXbXgTTW33ykda/ptlbIYAPxuDq7gsN6nuZWMcF5IFYEw43?= =?us-ascii?Q?ECstZDC7Q1AlVqO+devBeHj0uMhkDyLxIh9fnV1bbxiZ7zil9Hk3u9RGaqth?= =?us-ascii?Q?0A502iH92O1G/+OIqbc9mqHAUedlUqbyxvl2GobjMl3/75b/wY/KUe1FrZAb?= =?us-ascii?Q?7zRKwX+/isN7+h7UXs2nrBoB94npB6JAjCJgmE/Fog/RTKEJ1FpJBTk8OLlF?= =?us-ascii?Q?Cw1c9mYNiriqKGyxZKHhJTLjLbVVaoWdNAlL2drVraApu3XmrFFsXFcUn4Kl?= =?us-ascii?Q?lrpkx/Lgh9HmeYNKwpfllCYjU6fhohmJw1v0vXcBc32PIWPrzEn9rE1wo6ve?= =?us-ascii?Q?INpM8bBuX55l2O9bjS8FOOXvMOPrTQpI5FTG92Jf8uPRIJVpgF3zIvqbG2nl?= =?us-ascii?Q?v1vFZetGKQMVGDTIlaNJrj3A0Kbc+9e4KlnCOgkBNQqogSLrRurtyXMRRoSI?= =?us-ascii?Q?6C/WqfcPDVBdqY5bvatDjAjolPMagQz32bEiBhnKRql/an8EY9EvwPlujlAl?= =?us-ascii?Q?Oa729I+WuUkFAPFnmxPUiY7UvlS/BQnvZbb/s4+ojoU4XWkM95eb3JJiZKJd?= =?us-ascii?Q?DKf+3r2RYu2JU7sJxX6br5eA4HujZ/tuDtFMKNot1BzZv8SIoRXQyy9qRMvC?= =?us-ascii?Q?dnmIOLLnAlpzg4HURLz0Pzl4Lh+Ol+fZD9P9Y0Pn0BPQ1/ne+2qX2+2Kuixz?= =?us-ascii?Q?Qam2gWrMpOpFdqGYC8=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 6:aZL97IROYbjK5O0Z2sRHkN2EB3m1nn+3bngd8Sk0oy0Y0t6mvs9gSprVsVh6dnQjUg8iLjSlAlrOtv/BzzN9EFYBOW3nB0AcBwyf5HPViI6Fa/tGnuQ9FZhCi8ZnOSN2N103IvUc4Rwckgye4r1sQscuU22sp47GdYjbJqYfC11Ww5NHayhSSYXhHtjTS+rPGypfVMbMfRqOKS2R8Zu1Lk/g9QvqJV7NtF1eDLd/aEqPpRJiUyKnd0CziPr4eOmVZDm/FgMBRYay/GNvO+SKa47e7Dk0ChYb0GVxz0IUAEcnKSK5df6MIpWae9suMdYmAqYdri1ACEZtNaOrGrVFTw==; 5:M2O7Om0HWTmvDEJPez0J9CE+kaWIFg2sNPFNc9UE6Js9QPXu5UiPZuk3nnMQ4nXEyifsNeDDGLUcHIvGpUYm6+DqbUMLq9R/0KW9bOg6i5rj+HvuwxCta+lbP1VFwPWz6k5/b7Hm6yrAYr3+Ffowmw==; 24:jz/tNpmXU8VfdrEyotJsNss/gQIoSija37MzfUasMyU3N9rdwB/70flBD1fDUuYOFvy6ZIXIclPjOYNCBF+HyO/FzZ/3+CdGK+lg3N4qkUc=; 7:rHC2ee3B/O/Nm9B8KXwhJc2KeDg/0sQAh0kXehRlKe7E4+c+Eluiv6bIKAY5D7BuJTQZvffvrvN/1UvaOcJ9FSAUSvqrGy8lSyTHcmLj3p7phSI7TIHGp+x0WfZe71l+G4db+BTbUbgcCvdOR5EL6mrnXFpdbFK4Bg37yB5DSOt1nE2uoCEOHE7tj36pGVH0XEnThnlhJObm5OKEW4gzyDLBcw9idgkKxIIhV+VERvc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2017 08:12:40.2025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3460 Subject: Re: [dpdk-dev] [PATCH 2/3] event/octeontx: add support for event Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 08:12:43 -0000 On Tue, Oct 17, 2017 at 04:41:44PM +0530, Rao, Nikhil wrote: > > static __rte_always_inline uint16_t > > ssows_get_work(struct ssows *ws, struct rte_event *ev) > > { > >@@ -62,9 +86,10 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev) > > ws->cur_tt = sched_type_queue & 0x3; > > ws->cur_grp = sched_type_queue >> 2; > > sched_type_queue = sched_type_queue << 38; > >- > > ev->event = sched_type_queue | (get_work0 & 0xffffffff); > >- ev->u64 = get_work1; > >+ ev->u64 = get_work1 && !ev->event_type ? > > I think the code readability would be better if you compared event_type to > RTE_EVENT_TYPE_ETHDEV. > Agreed, Will send out a v2. Thanks, Pavan. > Reviewed by: Nikhil Rao