From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 1B5221B1F4; Thu, 19 Oct 2017 16:04:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id F411C109F; Thu, 19 Oct 2017 10:03:58 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 19 Oct 2017 10:03:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oCNSea+IpJ1MJ1QJR fLBgwjL0bUm4mjp5PclZ/v68Q8=; b=GXeoC4qT/4FFTNikQhyYkwOjjyUb3rLr7 1jWD09jafK5Xj4bAw30F6Idwx495070Kc6lAEI04+f1aD/dbkKSFpXEruzAMfxLQ e+Y2y8E99E8T6Mz6lTcXf83fmunfxsE6MMQ60OmzqfVUKkXvgLXZim6Z6PHpaxaP qA3eCncf5ftlaCr9Qy37ERlICHVApbC0IB0opW3FTZPa6ce2+G75DkTSHB0fESot ggayGZkDj56njtIsl9QmCKNi9bj9fLuvYXxgRTM5WHJBuJWqxKyC/tEvO0IjPj+j LZojdD4U5SJTrZzycCRTgX3tXMpPVZ4iwrMw/BnlIYj8LnpfYYrwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oCNSea +IpJ1MJ1QJRfLBgwjL0bUm4mjp5PclZ/v68Q8=; b=gCxRRkd5pXtqfZ9m3mzg7u Ubx6aDYLidNdtMMakWxCpGR9ORXD1Evt8yp4kcR129gBobJU1wjXGMUry/IrZr3M q55KtucwXY6nCf1YWcs0N4cUyKZJxrwee63O7S21KmxWc//uKFJq0NTg3Iq6nS1O rehP5e4zZg71RHto8499FeOuS6/3yP/jyMsaGpw3G5RqUgylmJsCcz3X34w0S032 TV2LxdJS/6EVV+nxzCaK7IKhr29uwGE6OLLNKW9bvgy/X0uy2QhQCO7qq602cPEN n4m04QK53oHo0TDyx411vuJSgafEBrCn19SJ0VR5/2zj4WlCmwfUIbPXzhv8YkIQ == X-ME-Sender: Received: from yliu-home (unknown [124.79.168.36]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D37D7E3E0; Thu, 19 Oct 2017 10:03:56 -0400 (EDT) Date: Thu, 19 Oct 2017 22:03:53 +0800 From: Yuanhan Liu To: Aaron Conole Cc: dev@dpdk.org, stable@dpdk.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Jingjing Wu , Luca Boccassi Message-ID: <20171019140352.GC1545@yliu-home> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 14:04:00 -0000 On Thu, Oct 19, 2017 at 09:22:30AM -0400, Aaron Conole wrote: > From: Michał Mirosław > > Signed-off-by: Michał Mirosław > Reviewed-by: Jingjing Wu > --- > This is cherry picked from commit d75547718c87 ("net/i40e: return errno > when interrupt setup fails") and applies cleanly. This is just a > backport request. Thanks for the backport! A minor note is that for backport commits, we'd like to add something like following in the commit log, for back-tracking where the backport commit comes from: [ backported from upstream commit d75547718c873899b7f26616c50df7936a8f45e8 ] But no worry, I think Luca could handle that while apply. Luca will start maintain 16.11 LTS since now (v16.11.4). --yliu > > drivers/net/i40e/i40e_ethdev.c | 5 +++-- > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 65e10f3..191e858 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1704,8 +1704,9 @@ i40e_dev_start(struct rte_eth_dev *dev) > !RTE_ETH_DEV_SRIOV(dev).active) && > dev->data->dev_conf.intr_conf.rxq != 0) { > intr_vector = dev->data->nb_rx_queues; > - if (rte_intr_efd_enable(intr_handle, intr_vector)) > - return -1; > + ret = rte_intr_efd_enable(intr_handle, intr_vector); > + if (ret) > + return ret; > } > > if (rte_intr_dp_is_en(intr_handle) && !intr_handle->intr_vec) { > diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c > index 368863f..25797e4 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c > +++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c > @@ -1157,7 +1157,7 @@ rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd) > RTE_LOG(ERR, EAL, > "can't setup eventfd, error %i (%s)\n", > errno, strerror(errno)); > - return -1; > + return -errno; > } > intr_handle->efds[i] = fd; > } > -- > 2.9.5