DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
@ 2017-10-20 15:39 Santosh Shukla
  2017-10-21  9:43 ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Santosh Shukla @ 2017-10-20 15:39 UTC (permalink / raw)
  To: dev; +Cc: thomas, jerin.jacob, Santosh Shukla

Coverity Issue: 195000
Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")

Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
 drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index 6bdfc0339..cd36a195d 100644
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
 	RTE_ASSERT(gpool < FPA_VF_MAX);
 
 	res = &fpadev.pool[gpool];
-	if (unlikely(res == NULL))
-		return 0;
-
 	return (uintptr_t)res->bar0 | gpool;
 }
 
-- 
2.13.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
  2017-10-20 15:39 [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle Santosh Shukla
@ 2017-10-21  9:43 ` Jerin Jacob
  2017-10-23 14:32   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2017-10-21  9:43 UTC (permalink / raw)
  To: Santosh Shukla; +Cc: dev, thomas

-----Original Message-----
> Date: Fri, 20 Oct 2017 15:39:58 +0000
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla
>  <santosh.shukla@caviumnetworks.com>
> Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
> X-Mailer: git-send-email 2.13.0
> 
> Coverity Issue: 195000
> Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index 6bdfc0339..cd36a195d 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
>  	RTE_ASSERT(gpool < FPA_VF_MAX);
>  
>  	res = &fpadev.pool[gpool];
> -	if (unlikely(res == NULL))
> -		return 0;
> -
>  	return (uintptr_t)res->bar0 | gpool;
>  }
>  
> -- 
> 2.13.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
  2017-10-21  9:43 ` Jerin Jacob
@ 2017-10-23 14:32   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-10-23 14:32 UTC (permalink / raw)
  To: Santosh Shukla; +Cc: dev, Jerin Jacob

> > Coverity Issue: 195000
> > Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> > 
> > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-23 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-20 15:39 [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle Santosh Shukla
2017-10-21  9:43 ` Jerin Jacob
2017-10-23 14:32   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).