From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0049.outbound.protection.outlook.com [104.47.33.49])
 by dpdk.org (Postfix) with ESMTP id C2C761B2B9
 for <dev@dpdk.org>; Sat, 21 Oct 2017 11:43:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=eeWtK637+idk3g2GPtNHcFUdx9i4QwX/N9wtc9Hb2yM=;
 b=knY5I/AkKKxd8VEe7ldkgXqv/PI+TCItUYmqFP1Va8tDcixecQVVYpaorYEo2URh1/nAWIuHjzwBSQRrVNn42o80OYVgCvLUpQYQSWD8WhquETYfD7WV2f/BmzPO7CUGjuapZ1uTyWI2SSpgB3zUmj4CBh863kRXRCbVgSdt9Fo=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; 
Received: from jerin (171.76.118.225) by
 SN2PR07MB2528.namprd07.prod.outlook.com (2603:10b6:804:7::6) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 21 Oct
 2017 09:43:53 +0000
Date: Sat, 21 Oct 2017 15:13:30 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Message-ID: <20171021094329.GA14930@jerin>
References: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Originating-IP: [171.76.118.225]
X-ClientProxiedBy: PN1PR0101CA0014.INDPRD01.PROD.OUTLOOK.COM
 (2603:1096:c00:e::24) To SN2PR07MB2528.namprd07.prod.outlook.com
 (2603:10b6:804:7::6)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: db21a598-750e-4908-60df-08d518683eaa
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);
 SRVR:SN2PR07MB2528; 
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528;
 3:em8y1NN1kDDa0tYbzYoISG/c9fEaUFFWnXBmVthWPBFDlGWaVv8NfBewkXyGu7bDQc9iHB/Z7+ZwWkAUgQU0nTbkIL7IvU1ibkEJScZlp/8gSm+kCbBA78M75Jz+NwQ4iE1Qgbl3O6EObAMXCwB+et9lWZz5/dOdC0Lr3VW35CeI+6Ofe/okeLjNl6scbFM9vVetz47cFlawRxj3Xxd7SN0UJKzYshu1AzRNHWi12Hs0USnVOSlJ8JEIM1GNRhRh;
 25:GlmudggAd5hOvyP7tK2u2jK/803MkcbEaqF91eOq4aACF3K3FvyB5xZo35nL/QUz7Qi2LrYEXEziOfuzgUtFOssC9khCHEU7egs45Oy1bI0JgnfqH3qMdS++md0yxg3+0aEzfZY31CN2Nzh0j8HJpLk1o5F0m1EzqI1jATnWLAMSj6RGnM26veb/AbajdHEOXDHjbp5rB9APmHtFsldA5hbZIu+vFAK5QI/ZEPi60K2ARJ29J9ra8zU3sZoeGv6HO9tZvAZ1WNH/JLz9Wt4YtEgXyKm49GkKxC4aJjhTx++RmiHh2vMCbqGf69jDMzcUGwnZSq+1Smdy4WWkZwyb+Q==;
 31:xY9VtjPfo9c9HW47zchQRJ+zKEYlMNLt9A8olqu5b0DVhhdisakyP05eD3oU1lVVemkL9Q+PIWpqx9zpoFVFammdSR0vaxOTvIM9VEJEDJNsoZsQ794dswS5Y4mMp+Tn5Sblcai77iHufKcxPEO36KWm53SIQyjc2MeFtFVarMwKOutBmzbnQNuzLPwdbNFG9FWvkwvWbguQfJGyVwzSV8LW0859lES8nFkSRioQXF4=
X-MS-TrafficTypeDiagnostic: SN2PR07MB2528:
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528;
 20:8/M7mCLNNa7l9IFTbmJJS6z4IXEaeb9EDgoo79caAwRcsnWPYEtwnqbiXQ1lzVvcsNhaCRM+n9qgyZg62K+xqTnmRfcMPETQaQ66Zr4C1291ZUDtpYrm5VpFGLrraLrWRDKhsRHI4uTF9a7NQoodIbZ9r2B7ELF/gSYOueC19mE3WLyVObA1Zp1yVG8yqjC4T9pi6pItFSD9gPzz+SnM4dwfhJYArTsyL5f+8vD25s6S3j/QDYcyO8/EnqLZqo24aT5Ja2YX+figHxHdTY2GuzgVfBBATgQ1X2OVTHfxZuyK2QolhcxdPJWm8hYCn/pHbyUxsJlFfcqP6rA/AVEYLcUsQFd+w0hL0O0DxCo05Rw60XrGmVwJwdgXog5FPMEhCV3nZY1ce6TrRDggX9Uk+kmQP6tq7nXGiTzu8T3IqClp8DFBIzkQSqu+BRLAt3PfKGQnJM4JJt4O23ZZYICKnpY9XkFPhDG7rkEb+kOMl4qTtmzbExexfAAJ5g5mbEHlq+aBYfSwQc0dKBfbfBtr+be7eptlmtOO3zP55A6or1bAmUiFCVrBR++ID/wkJ1A1tgBLmRWv9YOatFtH7p9krAuAU4vkDEOLQIw3f4NrBrI=;
 4:tGk1NdKAdbid4W6eVTiLHffiYkT1Rx8S3+rnjio7HLfC3ZGen891Pbtajf7kdg33pRqciibjSRXnJqk5q9ONnzmOLMGT/N8u6GP4S3pB92/ZEy8vrhhgDhOQ0xPPElB+n2+3AZ6aDVpfQCbdrdZ5BdlWHe7HYOHReWfXHWWZo0v1M79Wbz6PIXTxj9Yi+3y8NKXTXoMSswbTtEIAqmN2StPuyhG70wOcve1jl2wEXjG2mxo4QsC3hv8VW6YfUgF3
X-Exchange-Antispam-Report-Test: UriScan:;
X-Microsoft-Antispam-PRVS: <SN2PR07MB252850DC43F675F343837E10E3400@SN2PR07MB2528.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(3002001)(10201501046)(3231020)(6041248)(20161123564025)(20161123562025)(201703131423075)(201703061421075)(20161123555025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
 SRVR:SN2PR07MB2528; BCL:0; PCL:0;
 RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
 SRVR:SN2PR07MB2528; 
X-Forefront-PRVS: 046753C63C
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(6009001)(376002)(346002)(189002)(13464003)(199003)(5660300001)(4326008)(16526018)(81166006)(106356001)(6116002)(2906002)(50466002)(25786009)(23726003)(3846002)(72206003)(53936002)(68736007)(9686003)(2950100002)(1076002)(8936002)(81156014)(42882006)(33656002)(55016002)(508600001)(305945005)(47776003)(7736002)(8676002)(50986999)(6496005)(6246003)(229853002)(6862004)(105586002)(97736004)(189998001)(54356999)(101416001)(33716001)(76176999)(6636002)(58126008)(16586007)(66066001)(6666003)(83506002)(18370500001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:jerin; FPR:; SPF:None;
 PTR:InfoNoRecords; MX:1; A:1; LANG:en; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2528;
 23:tSa+os5c5k/xYBbIKX7C1t3Ei6u9+QMKtQc1Z6CwH?=
 =?us-ascii?Q?7BymKaZ9rJy2NUwUPBDqnzuMzqldEkJ80ER3hvH4k2lywBFr8jWrgPq/28mz?=
 =?us-ascii?Q?An0RJdrFi8vULphBhu1pGaLiy/01b3NBTPQ+A26ANiFjjDpSBjxxStmuyvYM?=
 =?us-ascii?Q?6IMhPSUaP5rRex33FDJ7UDQkfOP1kjK8F8iuP05DzDG9rMq3sgVG9YUgMfY0?=
 =?us-ascii?Q?It6MFvdNgbDAkYlpDxe9ZH8EHNqoDHM+qKIIg9UaaA43VGgve4itCOqNLNL1?=
 =?us-ascii?Q?jrx6LMaz9LVrXiSC3byrycKDGhYEt+ZbBtciPRb5NXLC2s8O7iMFzA4Y0CRv?=
 =?us-ascii?Q?XnU6mSqV+nLyF/mGTOkIk2EKl8m18lgr8KNxgcPCZrrQ/cnByrF/G82KsHbL?=
 =?us-ascii?Q?hJ9H0l8ZyKTZTJNzH7RJ15wRZLaJjokT5lwbt5ap1TJoiyJ6NaUKhd4AJe/x?=
 =?us-ascii?Q?t4lhvR7IfViqVL5lU3H7Kd79sfbfixYKH3mDUOt50tU0HOsJLJ7phfuboDRN?=
 =?us-ascii?Q?sVkQnpWPS3DnbkP4q0iPvrnJB6kF0QfLk6Ra23Xmyd3gIQXIxPyeo/OsX4OI?=
 =?us-ascii?Q?kwmsxMR9/RMZ2ZAGmnaUFrl6shdGdG3PSb1RVa53sIncM4lIlUFMTsl62GLE?=
 =?us-ascii?Q?bMZnYLq8jGi4XPuR01AjYYuZ8AcPfRpCaZjMonyUw8YdzzgH1KxYxQix85A3?=
 =?us-ascii?Q?mNlScmnp+5eG3UXt7CgxBEZCsbKOz3lK93B8SADn00zfbajawnNs9U0AEXb2?=
 =?us-ascii?Q?jRbbxvpziiJHV3SA4DGGKizpti/oYg+LszVgzEV4qWs8amH1/bH+4B3CokbK?=
 =?us-ascii?Q?EjJwEEZLk31Ld+0BHBaND348jQmM33e87v9QEYdHwI7JjhpBtSuBuoQhH2Dc?=
 =?us-ascii?Q?OScp5Y2+Ao7W4m6QJ7GstTC1hc113J647nYi72/lIqVumeDY0HwjSsLH4iaI?=
 =?us-ascii?Q?SyUpxTGH9S4zE65qxc1mftySlreaeKuan6r5HVwDu+4ueQLBjeU1hEledkI/?=
 =?us-ascii?Q?C+A0X7Pg4rPXm1mtjILYBwO8rOPC1sYoIqnpcYWGEEwb1qYk3hRCM0t1mIQh?=
 =?us-ascii?Q?HhM/fGySVN+wqBKAyTN0dWfNMT8afHw5tw8o3y6IRTF/FSrZDm+KUpOXEHxZ?=
 =?us-ascii?Q?ZRWBLhN/GdEvvKLOpo/gOdS8LABrOV0a9x8INs3mW3AQQGhHqUzxlusVJu8F?=
 =?us-ascii?Q?jwKw4LpSW8/HDJrn3g/klSFUQWp7dmHLQ7+?=
X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528;
 6:6/X1J54FbBoIcwBjdjnkRtRJZoMbQ1/S+oAr2Y3UL3crsBRkBfybax/gtN38jbNbzjarh6UQU6UWowoV8qMAnCuvq4pBN4i7eQHr9bhbN78Sgoa0SiGfdALComr45/qo4XFvtKoAbTYfQpQ5kEs1H7Vbad2FmsyxSCX+jwA7CVa1Iqo9Jj787Yp2OTZ+Op6y3jN+GiJ92bWgCKJLOopzdLMy4f+qsqAk3aKeXL+9nY7qE/qMDXoVQBuR1QWARECWHY8808hWDuDEC0rEj/CpAwNe/lm3ieXKwSdjSpUilVidXTlvHUs0zsMHaXBckrJKE5xofX1vQeoqoS/zXL4BeA==;
 5:oNrWSeT+ywTrYjBbyeZFLS+n4iBnKEav7pXbbJlsk8gupmkmVzV2RBa/18vmPZIDNftgDWK2JBq02SdlGnRgawYMzOZtmFQXp0J8tir4kXgM3kIm7ybu/aRmLt0DFeb9bIWYUKdYBOeLXr1xKFYWwA==;
 24:9pf21oyxK6v+rHvKCMPMwc15+PWJIfQU6HVZSRg72CcFZB/5DuoN1EYuWJb/Ii/iKMftBOuuI5j7vk26QOMCFwgfHcWtRvk+cV7qjgtjER4=;
 7:uetYgs5DyBGwvdQNVew7KZ6Z4fRSLgZ7qyQn0ZNpsDwrrvYj065KWYifRLc6Q2wrW1jP7HUr22XLVF+Z8UEZYJvSgnYMdP6aOhjGl9/cKiNv1eU15XGVVg5MNL89+oCaYnko5fXklHgpOcsoZfoBcFgUEQ9VQYT1yc0AxO0Y/UOffRHzRBAkXeVY7gMCO6bvvE05hdaIFfzfY+/H0pP9B3KtX3CeoHLg07pzaosWmuI=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2017 09:43:53.4499 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528
Subject: Re: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from
	gpool2handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Oct 2017 09:43:57 -0000

-----Original Message-----
> Date: Fri, 20 Oct 2017 15:39:58 +0000
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla
>  <santosh.shukla@caviumnetworks.com>
> Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
> X-Mailer: git-send-email 2.13.0
> 
> Coverity Issue: 195000
> Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index 6bdfc0339..cd36a195d 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
>  	RTE_ASSERT(gpool < FPA_VF_MAX);
>  
>  	res = &fpadev.pool[gpool];
> -	if (unlikely(res == NULL))
> -		return 0;
> -
>  	return (uintptr_t)res->bar0 | gpool;
>  }
>  
> -- 
> 2.13.0
>