From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0042.outbound.protection.outlook.com [104.47.38.42]) by dpdk.org (Postfix) with ESMTP id 10A0C1B685 for ; Mon, 23 Oct 2017 20:10:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ReO8viBdrgYEJ/pk/fbJC4hru5ODoizdCbiHZZpK0ik=; b=NJ82Jraa+F7OEdaB7Gha5zkVrr3OjXmJVXbCWXWbM6ySRIPR4izhV5HYYlbn1EFIX/EdGHDCO7vMAlkUTaAPm2QHLl+OvYXYmxYSvVl9ueXyxpU5RZQlRmTdi0zglqiQWcFMqDA6QUIsBx/Wj77xY1dtFmMuyg7NJa5FHuYl60s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.118.225) by SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Mon, 23 Oct 2017 18:10:01 +0000 Date: Mon, 23 Oct 2017 23:39:42 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: santosh.shukla@caviumnetworks.com, nikhil.rao@intel.com, dev@dpdk.org Message-ID: <20171023180941.GA22149@jerin> References: <1508230393-27018-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508316342-17781-1-git-send-email-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1508316342-17781-1-git-send-email-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [171.76.118.225] X-ClientProxiedBy: MA1PR0101CA0065.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::27) To SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b98fbaae-ac45-4e04-a5b5-08d51a41489d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:0fA4kv0zbVCd43yDELDgB9I95xE6MXxWt2Q06xtY4wMOD7fQRgnxkFuV/BB/ezpmb8raafEypOpSqpqLmIrIY8Z745NajwXYVBCxr6j7eHXfQn4MISEi6p332Twdw7q3bHpqXG09lTDREQJgYWmw6Easqb92S0XDqysClLLbxGeKA+VJs3QP7JwX73Qes4kZBgGAX/7DnKr2uEuDd5HoMDbzCnKn6Ez/7I2f3hZufkvgw7X70tX4CxWH4kzM91IC; 25:3aXgBumOsDMvr8N3QZD8FOYsX/QnX8d3URaEfKX1d2zr1GE4Gb+0538M5LsmLGX1tZna8gjc0zivaFvrwQy/miAPsHwOz1BVtveWaK1bkjxp8Ocma+N5GRO0MHwoftj8OKVpFng8CzYunbnvyWA2IjyyQjLcL0TtbCOJv9awQeVT9HUZ9f+ovGacy5AL/atuq0H01KmEcBU6h+e7Kn7Gjh9uan6ZCcGon2VX5bypGyIyyZqt72+OD3AQSdhA14+VGN+0QglhLyQqFFvk8IaDOgSkTNejXVagp0pa9xJWDI3PNOz7Ohu7lZ65GPImXZzrwbWSypnnGe4ihHmRyGhweg==; 31:VXxSdm18x/z1gWlYIIMMQddMN1+bfd7VAx3COBdu7pOhkdEB97u5xjRgbiz5v98+ERXr18L8lPB48bEzBiojHKWu/dCAKQUqxUW3bNYOKMicvpwxCXnzzqFg6mNbVE4J7Kinrd5YHAARZTtB56nWJhCDumst19p4DVpoXlDDJ/js6bZ7pmprZ0ihreyn4cwnpXca43tjELK70DSVev6ZfZXBQGZqOd7qREZ3S4Kj/R4= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:AXjACrImE91CCIu4djVT9jQwbM51RmayGq0jeThSO5VWkfHisL5j0grrC0HUwft4IrGLd3sdEsHkTl+ugIdmPs/GXGxuej6mZ+hDeYul9vMh8Wy/8CE6+isg5vDjqqGYE5Gr2pa1LhmTjqD/UsQR36TIBSkAdd9mTkIes0ikdNuUDWXxGzcHjOV/cTfR/MLJ4McXmQV4dtqqOKvFpkP2p29mYqilJx+qQgI8lLEm+NYtPLMUOpCEU3q+8PIuAFo9y9y+IfGCwzBEr70k10z8P9N1quaGlWidhdktSzJiN2/kZoRM+N/2W+oxjrACSfXSRK69WMynnEe4IqdWjk6yLEupQFw/E8SkoGoBUo8MxRM5657+2FoVGmMD6MW00xBt3azobNixZGH29e6lZsWhr/uA4IdX7LnoIvbHBh7l/OxUIRm/pqKKKFpW4E4aDHPKLPK0nHedG0ZdjR0n8A7CvaF6/bw7oNlpwVp6+hxaH3L3FUasZgWztdSC3nvk4QO3AzGvZ5RkxTVlF8kU5rjSylF1YJEI2+GCxSwwHLQ4zLvN4V6twmBWV62FNOSkxmuVKkV4WiSIAllWiaTFhA8LpyLrm3YsaVY1MpJhuWBB2Ys=; 4:K00xAh6KEuEGujfyLtJzCzYXMrr50as+SxixGYsmu+mJai6Lv97f5EtZ7Ay7tAj1vysuHdVWOzNmIVmYN3zKKVL+FTux0STrct5luKtTn0FIekMrI/YM/b4cYQFHgCiKF73xDqBe4ORfGb+eFy0gXrmD3o3wQOgIMQlMGSGTeZsqlqVtDMZobk6DsQKyD+bqW5ga2NE0Z3Sm5uvh0+vVIcjuweXwaLuygSpA6DS5tFnKbhR0wu+EVwZALlDeCCQvORwIhy0+gPz3P6qdKwAwlQyXXMUJ7EtMPeEi+aAR5y8= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(6041248)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN2PR07MB2527; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(13464003)(199003)(6306002)(53936002)(33656002)(54356999)(50986999)(76176999)(53376002)(2870700001)(6496005)(6246003)(305945005)(105586002)(106356001)(81156014)(7736002)(1720100001)(81166006)(23676002)(8936002)(9686003)(6862004)(50466002)(55016002)(8676002)(6116002)(6636002)(3846002)(1076002)(66066001)(42882006)(2950100002)(25786009)(68736007)(72206003)(2906002)(97736004)(316002)(58126008)(229853002)(16526018)(966005)(189998001)(47776003)(33716001)(4326008)(5660300001)(101416001)(6666003)(478600001)(83506002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjA3TUIyNTI3OzIzOjFndFZXdjhOaXFFMEZtSFlIT1psRnkxa2Y1?= =?utf-8?B?K1E1aE5zYVdRR0dXWGZ4SHNhYmxYZTFpSnlpRXhyTW9mdGw4WnRHSk5ocksr?= =?utf-8?B?SHUzcFl0N1Naek9lbnllbXdHc2pIVWxjcE9aWWw2QURvVVFyWmVqYm9xRW9x?= =?utf-8?B?aEFOem1mT0lZMDRCZVZUQ1FGTlFsTzdGMkxIZjVJek9NeUtDM01UNkU5TnEz?= =?utf-8?B?TmoydHhORnQzMWVnbWt6QWRKMTB1L1dUNU9yd3JmditaNXdNUkxrTndkTHRM?= =?utf-8?B?ZVdYMzgyRU1TRFlvRldlTzduTW5acDdndk9UYmpuME5YVTFJRjJURGdjbkFY?= =?utf-8?B?V1dPWUt5WFR4SnZLeFBXSTZZVklTZ3VnSmxNbk9BQWh4TGVoNUgzUk1Tb0Jr?= =?utf-8?B?ZE55aDIwT1FFYXF6WkRRV0NZb29JVU1OZy9pQTIzSWJvTGo1YzRlUXluM3BP?= =?utf-8?B?Zy9ZZUFJaHhkSmw4U0lOaTNIYVVjN3N6NzJTZ2toaGJlYmJna0lrQ1ZraE9T?= =?utf-8?B?c2g5TUNmTVIzdFcrYVU5UkUwd05XRnVxbVdOeUlDRFlMei9TZ2FlQXVmaWlo?= =?utf-8?B?MCtWeE8xdVFlZnRqSFFES1B0WnJtNmduY0d0bmFhRDhzQVVUNC93cWtUWFc5?= =?utf-8?B?ZVc0MFF6U0hpSjIzMGpHYVkyOStrVm1ycXZ2djg3YW51d2pEN2lBRmxHdmhS?= =?utf-8?B?VWN5cy9zSVVyQUplazFpcWhDMllrUXVpdml1ek5tdk1MUkxMUjBKWHJqaVFF?= =?utf-8?B?Zk1ObW54d2cwS3NaSHFHVEs3UEY5UzROSzlpUGNaZ00xWlFhcC8yS1NVVjlh?= =?utf-8?B?QmlEbHBpdUtSU01GbGdoQzB4K3BrcU8ydDJTTllKTDJwZHd5Mk5wZTVCTVlu?= =?utf-8?B?SlZSV2w5YkRicmtQS0RISHVZSW1VYTNSYTJ1K0RlSTlSQ0YvQmlHd21WQVdE?= =?utf-8?B?UWVGTlV3eXpBdmVNUjJOWFBQYUdaTWhkQ3NFVjdVNUU2bkpsRHJTbEJUUG00?= =?utf-8?B?QllPTzVnaHdYUW11ZHV2Rzg1UXJrT1BEeVpIWG9IZUJPQzdYZzFJQkhRRE9t?= =?utf-8?B?Q1NtYlo2K1hJWHV0QW0rSEVVa1RFR3A0c0I3QktQcUFKVlR6ZWpTQmhnUWRC?= =?utf-8?B?NjJwR1JMT2RhbVZjOEs2QnZJVnE5bllITUIrVFBvNzQyMlYyZUM1UGQyNUZE?= =?utf-8?B?R1hKQlpybStSbkFtTW13ZnpsRko1MnFZSWJHa09aS2JLS01UYXdsNWo1cnND?= =?utf-8?B?bzBheHpXNG9aeEd6cWlocityZGV2Y05rL29ESHE3R2hVYWVuTlJUbmorQSt5?= =?utf-8?B?MlBPbXo5ckFVRlhSMUduSTZ2MllpWDY3UEFXUU02aXIzYVlWV2xsbWg1NnFW?= =?utf-8?B?dzdTTjZ6WFhMUkFGdkpRbS9rVlVQa09RZEZxcVFTUHlzSzlwOUFHK1Y0WkJv?= =?utf-8?B?czc5cmkrdDU2ODRPK1pPV1dOeGY1SWlORU5zbk5SaDJTRHVvd1N5N2IzOFhh?= =?utf-8?B?bnFKUkltNEI2MVVQcW4wc2xjcHZSay9FUS9oYnRlNTNlN055cUVuZC9PZU5o?= =?utf-8?B?ZjhGUldKaUNyTFNjTTF0NW04c3pIcFZrNFd0cHN4OGxBZHJWckRaekx1Q1Mx?= =?utf-8?B?SCtFOWMwVnBnTEF4ZzlxbGtMSUVGQTdmMlFRV3Y2Q2NScjhUZkF3OHRxcUtz?= =?utf-8?B?MFFsRGJOTXl5eEZ3V21VZGc1ekNsYkptYWNzZlNqazJKZU8vd0llT1VCVklY?= =?utf-8?Q?1SQWsuMPB2N3exb3uFBuPIsg9NhF7haC7etsA=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:RA21DYoLbS+Xfyqp2RvPmtUadtiS6Mbnbrk56qMpj5GDlH60pyGNAakm1Axo+gvrtd0+J0aEG/CjMbufmQnoo2UVXve5A3QETg2SzYQalfpPKkqQ2NVcwZbpHihOaDM3lmcQLXKqaPSvnaOn34nO1d749Qdg2m8ZqVxmEfhYRfsgivQWvFZyKIbySD/+uote4khG7jC0nyJG7A4QLMkbuIm1x618L/xwWS2tLRwH0pcf2u+qems3X+pUt6v5zJ11N2XqN0wSGc0Gbek6xqY/kLVvpsEz70+EXLf1JZxFS19fQGLpLJGAF4G7ilLT850znnTUc2KNRp4DAsb8GvfNiQ==; 5:Tf6a+o1lKmeelCgnS05H8CqK43jZr+TqDQI7u3iVSKNHHOCCrKwVh5H/AxNIFPAE5tdiuq/udeEwLXNmwuFkdgJurjSo8o6GIvE3+KA8hVtBUKL/IJ6nOpLakxK7WEKy1Lk+d58u9gRHsO5umdAQmw==; 24:C4K4rVqxtdhU6/2GpZF0f5283c8OwC/uT2AReV6/QzP+zMFJWvV0x3HrHYaLRnTvxXXrpe6V8L1HMPwrD7xI/hWT1UaBHXNpgg2/7yOtSb4=; 7:LbXFgaaGk+EKD2nG3KcfQCHRsUjGTVlTlAdGZhdUREVPS4DO/kw24e316INFfcPKF6LVUd87rvw7W2bnQ2chH+OjTOMb+vwiyGLdTC1rCpRoJFWiBEbXkIqFq4IRUgsii5dNyVixHZ/hx49U1MzW6R4ZzXDslW56KLrY15tGtX5G5pmqUf3O/jjvqwGEh+KrS5QDAjifdS4MpE5CZdzzBq1foJgEnVVtCknO4IaYWbI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 18:10:01.7686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b98fbaae-ac45-4e04-a5b5-08d51a41489d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/octeontx: add support for event Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 18:10:05 -0000 -----Original Message----- > Date: Wed, 18 Oct 2017 14:15:40 +0530 > From: Pavan Nikhilesh > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, > nikhil.rao@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2 1/3] net/octeontx: add support for event Rx > adapter > X-Mailer: git-send-email 2.7.4 > > Add functions to modify and delete qos responsible for mapping eth queues > to event queues used for configuring event Rx adapter. > The mbox functions have been moved from octeontx_pkivf.c to > octeontx_pkivf.h to allow event_octeontx to access them. > > Signed-off-by: Pavan Nikhilesh > --- > > v2 changes: > - Improve conditional statement readability (Nikhil). > > This series depends on http://dpdk.org/dev/patchwork/patch/30430 > > > static __rte_always_inline uint16_t __hot > __octeontx_xmit_pkts(void *lmtline_va, void *ioreg_va, int64_t *fc_status_va, > @@ -195,10 +107,8 @@ octeontx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > uint16_t __hot > octeontx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) > { > - struct rte_mbuf *mbuf; > struct octeontx_rxq *rxq; > struct rte_event ev; > - octtx_wqe_t *wqe; > size_t count; > uint16_t valid_event; > > @@ -210,23 +120,7 @@ octeontx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) > 1, 0); > if (!valid_event) > break; > - > - wqe = (octtx_wqe_t *)(uintptr_t)ev.u64; > - rte_prefetch_non_temporal(wqe); > - > - /* Get mbuf from wqe */ > - mbuf = (struct rte_mbuf *)((uintptr_t)wqe - > - OCTTX_PACKET_WQE_SKIP); > - mbuf->packet_type = > - ptype_table[wqe->s.w2.lcty][wqe->s.w2.lety][wqe->s.w2.lfty]; > - mbuf->data_off = RTE_PTR_DIFF(wqe->s.w3.addr, mbuf->buf_addr); > - mbuf->pkt_len = wqe->s.w1.len; > - mbuf->data_len = mbuf->pkt_len; > - mbuf->nb_segs = 1; > - mbuf->ol_flags = 0; > - mbuf->port = rxq->port_id; IMO, You don't need to move the mbuf conversion inline function to 2/3, Instead if we do in 1/3.It will functionality correct at 1/3. > - rte_mbuf_refcnt_set(mbuf, 1); > - rx_pkts[count++] = mbuf; > + rx_pkts[count++] = (struct rte_mbuf *)ev.u64; This will create build error on 32bit. You can avoid the typecast by changing to ev.mbuf. /export/dpdk-next-eventdev/drivers/net/octeontx/octeontx_rxtx.c: In function ‘octeontx_recv_pkts’: /export/dpdk-next-eventdev/drivers/net/octeontx/octeontx_rxtx.c:123:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] rx_pkts[count++] = (struct rte_mbuf *)ev.u64; ^ cc1: all warnings being treated as errors