From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 530F51B76E
 for <dev@dpdk.org>; Tue, 24 Oct 2017 11:48:07 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Oct 2017 02:48:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="913108954"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.32])
 by FMSMGA003.fm.intel.com with SMTP; 24 Oct 2017 02:48:05 -0700
Received: by  (sSMTP sendmail emulation); Tue, 24 Oct 2017 10:48:03 +0100
Date: Tue, 24 Oct 2017 10:48:03 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Message-ID: <20171024094803.GA28136@bricha3-MOBL3.ger.corp.intel.com>
References: <20171019163629.28618-1-bruce.richardson@intel.com>
 <20171019163629.28618-6-bruce.richardson@intel.com>
 <1544893.XYOyShJzD1@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1544893.XYOyShJzD1@xps>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.9.1 (2017-09-22)
Subject: Re: [dpdk-dev] [PATCH 5/5] eal: use a single version map file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 09:48:08 -0000

On Tue, Oct 24, 2017 at 01:21:39AM +0200, Thomas Monjalon wrote:
> 19/10/2017 18:36, Bruce Richardson:
> > Since the functions exported by DPDK EAL on all OS's should be
> > identical, we should not need separate function version files for each
> > OS. Therefore move existing version files to the top-level EAL
> > directory.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> This small change is missing and added when applying:
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -88,6 +88,7 @@ EAL API and common code
>  F: lib/librte_eal/common/*
>  F: lib/librte_eal/common/include/*
>  F: lib/librte_eal/common/include/generic/
> +F: lib/librte_eal/rte_eal_version.map
>  F: doc/guides/prog_guide/env_abstraction_layer.rst
>  F: test/test/test_alarm.c
>  F: test/test/test_atomic.c
> 

Thanks, good catch.