From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0077.outbound.protection.outlook.com [104.47.2.77]) by dpdk.org (Postfix) with ESMTP id 7B6431B800 for ; Tue, 24 Oct 2017 15:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5BPII64nDSEBSd0ylOyy+TfEfBQjI1WLxZYDaDS8ytE=; b=fZt6ovO5OwPc06p6lpf5TviGJ1CH6qv+egqz3TmSxidzJCG8GB8b+oywCsV9mxLVql7KTJhUEpDGL7HfHfndvmt+cjZURyxFjwGw3zKhvw5lI/Hs6mq7bcKgtM486GpA812EVMlsFnE/+zYCLynkSmgcS32IaNGg1qt4yeJnxnQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from yongseok-MBP.local (73.222.116.174) by DB6PR0501MB2038.eurprd05.prod.outlook.com (2603:10a6:4:6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 13:41:18 +0000 Date: Tue, 24 Oct 2017 06:41:07 -0700 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20171024134106.GA19843@yongseok-MBP.local> References: <20171023192544.GA19386@yongseok-MBP.local> <20171024071142.3wsybjacfoa6i453@laranjeiro-vm> <20171024073434.5cbsrnzw7pjrjswm@laranjeiro-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171024073434.5cbsrnzw7pjrjswm@laranjeiro-vm> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [73.222.116.174] X-ClientProxiedBy: BN6PR11CA0012.namprd11.prod.outlook.com (2603:10b6:405:2::22) To DB6PR0501MB2038.eurprd05.prod.outlook.com (2603:10a6:4:6::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a08f5ca-812a-4423-dd2d-08d51ae4e871 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:DB6PR0501MB2038; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 3:mqEm1wLorIwIKa9liGr1DEYGa10czhgE135MXiyJ2291a8iXy4rxrwIDpPMuSLl7UHg7SiKG2MxzbdKy2yVcl351WzvYZ+evm6P9P2wHzoUFPuIL44MDDjD6xkigpMC5BroEhWLvJo3dtADWt5oCvsQMs5wPEf8gb91a5j/8Utm1LD4eoHGnvnlboqF6+IJ1lbTO1SJO/boYWinMmcC2oD5iNJR9fJ1RG+m14NF8y3mLkhlsgxD2GvuHfyZ4ern0; 25:iu8Z/hSjDr3hQwU14UvO9Ti4I4Ul1B8u7SXv+LpVokOstUQT2zrBynm6nCUJdfa1hylk/aORcz9BnQxzZKtfEoP+/LFZyrM1VL2TjV6ePWfixTf/kc6VYnz/Jv9m539ea7gKkgtVpo8VZW7GAYDYpULr2arA2OnNKqLkW9dDnxUfGWglAblQyEmDlSQ7/8hi4/U09wDDtOrzdumShxlK+eoF6JNMN+f1mPRYS8i2kcrJ00fY5lgPzL+mFTw0XGQiC3ve+XsEBwC9yPpn3+bCVAiImXV2XSSFYZX7Ueg75/rv5YcPgalOaMFXu8LX28ykj74DpnHCtkZE7yW5o01usg==; 31:AXoComav25CYqtI+RV9ugTnFqrA/iTxJ/KOdoVN9fkO/o6A55aw3ge+DKLTYrqY3Gj6d4zgfEO6jl0IOuyVb7grD8e01KiaxdyJxXxMQ7R5ALZ1sZjJNr4V/1jrHUw6IqF7ol/RepFzzIsa+bbEwch5L4s0jJyhrZR4MCim/qGnN1qgtPbUDBE1r6FeUZGvCyfCS3g16UuizJEHn86hKlYci3j40f08icdCMAW50Zsk= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2038: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 20:1uWvxhylgqXSlCRXW3Tmtm/7X7ZZtzzQBs78bMLvrSxiiiRGx/fw7x1aiyLla+GzVZKQntickztSoXwKUdHX/tixHMMHzg1mSoqbyPQMGJ6oFHaU0LUVye1HCUj9U63y/ydzvMZli50MPtUu/4teaJ9VunsEgHLFPQ9cr+9qXE8ykzZ1FIeLOTamZdDEw9E/RP9XjXhO6Djbtf5ePqt3cLyUaMBDncOsg7hkF4anCiu7me1kFP/+XCmpcyqC/6eNEVom32EYn5I+hfKMfcx6B0UT4Vmt0ZmyPQE1tkiMV6P8kx8pkLXIpvVh9NYB1+9ubAqbrF9qYWGdRREPBtGDgnpO3Gddt2yYVwLEpxm2N76oWVpMS9k61/JCBtku3sWMF38Vm4Rcbbxbv/8WrJX/FplRkwnSxbnZcjeEkZV1TYIk/oM7wPp8xC2+cN1oDcuM8sA7q8ZsNa+OPan1Amc3ub85mbnFsQyfMtlpwtj5s1jE6GpI2iMVWE0WHctXPNaz; 4:D8MFRiBkobqowd/DFwfqCDX1UgxRIBP/Oe/HVGMPGKCiia6X+pB//SqKbd4dOsAfc7almhV7srrJqG0NUyc9UxebeSoLbnoAHTX8OiT8+99cfVcoZO/EWHKugFzJxjkhBV99FVhF3DcbTGF6vZwrvIAKLf5Fe0inRz6kIQrHJyIB1o44RCieAntWj940yySyJ2pIxL7miWjwRP2nnagwqoxPXeaMUKKSQKEfgRow6ZxY2QvBq428jvXOq0xuqknf X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3231020)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0501MB2038; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0501MB2038; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(24454002)(189002)(199003)(68736007)(305945005)(478600001)(9686003)(5660300001)(189998001)(229853002)(53936002)(105586002)(7736002)(2870700001)(106356001)(8676002)(6246003)(8936002)(47776003)(66066001)(50466002)(1076002)(81156014)(54356999)(50986999)(4326008)(6916009)(76176999)(3846002)(6116002)(23756003)(97736004)(81166006)(98436002)(2950100002)(83506002)(316002)(6666003)(2906002)(25786009)(6506006)(55016002)(86362001)(58126008)(93886005)(101416001)(33656002)(16526018)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2038; H:yongseok-MBP.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; DB6PR0501MB2038; 23:HZfDdewm8pRQXYjV29HhaXOwArsK2G1q3LcMk?= =?iso-8859-1?Q?LvZBQfIMqBL4foIjy9Iu0UzvmU88iWcDCcevn67DMI5pXUROlNni/mB5YA?= =?iso-8859-1?Q?i+eAtEJ8M1BioH3smA7nC8SIN/b+UpYHoH71GaZXzaElGTN7l0rs6ZPi1m?= =?iso-8859-1?Q?4KlqCiXknzKantf294/n1ZFAGvZ7yqOReF+Mg4i6csHspru/55ba/ru+um?= =?iso-8859-1?Q?qpfRtpRqz0C3GGykSILqPZNodMGFyI5px19AjZoDG7ctBGZkJLUhIcNZYy?= =?iso-8859-1?Q?YQ6iF1NXuhzMqo4IUrBT/+D06049R7aQZKmLIiv0DrwUwkzrIT+5bgWWgD?= =?iso-8859-1?Q?Xcw9fjAdNzAn0aPKiAjQW1u5wZaK04xFZBewScc3bPVTUqxhfWHUtUPKs+?= =?iso-8859-1?Q?R4P8kwhdndYTYPZm+UjaE3U+vEJ9EMRe6LcQHe5J3CPU95T5udTpTGEizq?= =?iso-8859-1?Q?ZLV8w/aGbr8RijM93TWi2jKK/TQp44fnmQaN6u59Tjw4eBnTFw4VIi92nq?= =?iso-8859-1?Q?4mEjZ1+9whhaGy4tH8ZomE4Ufgxm6OpJzjZugM4EZx+XDbJXWBimJ1btQr?= =?iso-8859-1?Q?GRR4Qh5oZ7j2A64KDKZH1aMN5MVT6Yz4ylgCjIbIzSz9d8qWpPcuFVyaaf?= =?iso-8859-1?Q?Gd1jE9DhuucXX6P3IiPRwsHCcU1lpftFOVOdBpue4hVidsgqBRfKDBAEVy?= =?iso-8859-1?Q?0Cd54EsvMUth2uC9U+SiQxbwoJf8nladw/HGGyYFc4mPtxnqxzNgChVWYp?= =?iso-8859-1?Q?F14alRs9Z/XipF6mjD+pYZfe7Wae7Tt/MoLQm+i8Xf0eLA/N/nwuCpzQDq?= =?iso-8859-1?Q?Gi+HoMk+l0p76lQbGsSs57Ckinq4CFSmdfMyyQmWBz+E5nDzBxpcSkQ2mR?= =?iso-8859-1?Q?SiMXN/+Vg4YhAT652iMBpO2KH85p1ELOX9WZgvEyxmAk26Hz/h/TsUPzfx?= =?iso-8859-1?Q?TmowEWk7SAvi/flHHoPc1xjNLcurNsBXzX3Jq3o1ZSmQI//r7p9m/DSBdh?= =?iso-8859-1?Q?7VsY9i/7RhsOVS8zIeDvc+iKmVj6o6buETiig/jNlohG+c4CGYPxtaotHh?= =?iso-8859-1?Q?N6tBPxq0/DkrzrgE5YbGA28CJYclZiYNae9i5mKSit5getYjOTvVZ0Q7Vz?= =?iso-8859-1?Q?/xFfXR0wwEIX/WXkpc2vSzjS7Xk7+K6vArmbAhzL99vd6Shh+FJHFuwWks?= =?iso-8859-1?Q?D3md+AXkGfVycYNGeEGN5HTMRfDR+cLcICNfyR6x46s6XiZ9O1IwUAbjxe?= =?iso-8859-1?Q?Wq2KGKeoUHvs5l7wunSZwZzY3xDUoe9wULp6fwVuA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2038; 6:jS7cIwqHMu0j1N0qFtx/RKJfSXnHLI4cvWq3EOLozN6PPyraeij3Jr9MZLHGgtKSw8ZTymu2xi9lrynNNPH+JRQXGHdgjY4b2fUDw1Gc1s4/c4Km0KkzYgGeir1FBel4zDcJbFZSRapfmGIugmgUxn5G4SMcwjs+8NbpuuC/3rATRyYnsv0EbT5ZMU9sFpVdgjHGNKVb+e4L50ofJzvgAYQoWI2WSkRvWujW5JaZTjPW4gHdXeN0ldPz+lD4jUMqlKh7OI/lvSm9cAYSMOD6dSABCGpZ8UqqNqjkCD+MGVdvQKuVdX8rkYlFkIvQV0Mo2wFdGxtI+S3PF+rwl32rQQ==; 5:RFQmxB7AU4SsrNoj/uyHBI1dNH2sRJgGmmZRkk7sKgeEw8GA/5F4UPfFs+QH8gn7e8eZMKmpTjPhlUZ7k3bVQr11hTq5cXoGOHO+cyWvuCEXP0SnCJfChBV4vVGGW7aTZLHCYZxVLOupBhtw6Xoy9Q==; 24:Q1WDrT5EcAs4AVJRHCj6jxmNRvnHanHGK/R/BGu+Oqbx669noi5UbwW344jZ1gzqezwGUmjvApH9Ls6ZbFdEg21u75IFcBsqTVD9+u0HPes=; 7:s9gG5DNSzXuNX673eVb94uHDMYySEb44krpYPVyTFiVSRFLinBhc45zbbeZwXjoJ0wvL1ZjlaNLzcxLEQ8acbGDCWIdonp33Iu/P5i0DhQwV/8+StilWMbZ94lSrJlrS297U/0SbvF8nOJ7k6OLMmV4e6iFYA89mmwhcvP09liPDfhiD1/6okxW1wK/a5cpYWEDl0RYNNjOybyYJ+z8d3QGNJ+16/8j9uPduuumtbvE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 13:41:18.7903 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a08f5ca-812a-4423-dd2d-08d51ae4e871 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2038 Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: fix reception when VLAN is added X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 13:41:21 -0000 On Tue, Oct 24, 2017 at 09:34:34AM +0200, Nélio Laranjeiro wrote: > On Tue, Oct 24, 2017 at 09:11:42AM +0200, Nélio Laranjeiro wrote: > > On Mon, Oct 23, 2017 at 12:25:45PM -0700, Yongseok Koh wrote: > > > On Mon, Oct 23, 2017 at 04:49:56PM +0200, Nelio Laranjeiro wrote: > > > > @@ -261,75 +284,59 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev) [...] > I've wrongly read your last comment, the patch is correct, it won't add > multiple time the broadcast multicast, it will add one per expected > VLAN. > > Example: > > testpmd> set promisc all off > testpmd> set allmulti all off > testpmd> rx_vlan add 0 1330 > testpmd> rx_vlan add 0 1331 > > Will cause this code to add a broadcast flow with VLAN TCI 1330 and > another broadcast flow with VLAN TCI 1331, others won't be received. > > The user will only receive broadcast packets with VLAN TCI 1330 and > 1331. It is what he expects. What I meant was, if there are multiple MAC addresses on a port, the bcast/mcast flows will be repeated. For example, if there are 3 valid addrs in dev->data->mac_addrs testpmd> mac_addr add 0 testpmd> mac_addr add 0 testpmd> mac_addr add 0 and 2 vlan filters are configured like your example above, then 6 ucast flows (2 per an addr) will be added along with 6 bcast flows and 6 mcast flows. But it only needs 2 bcast flows and 2 mcast flows - one per vlan. Thanks, Yongseok