From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 2CAF61B809 for ; Tue, 24 Oct 2017 15:51:54 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id u138so15866992wmu.5 for ; Tue, 24 Oct 2017 06:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=BhZUOOVT32DJ0ksyt5/YbCj4qJHu/rpUsNQPFqBpZiI=; b=TGKpu4+p1YRrWFsJuRsC68dogFmwJBvdDMNV7/cu5HXZbCeKaRX6iDITyukViFmQTQ 5cTKGe65DpUXuZjzrIfM/DuZvaL2n37ywr+s60kZBns7ASfab8CNEUEVxEbKMftU4k+C vdbvEPhTs2fu9LCC9aReWFk3OoDJSPSy6wEFTGbEwLMERnQL6OmzwxaYnX2uBydJnhNx Z43Gx+4H6RlOdT8xIbAxlW3X02ESCZjkwBRcf97onneKXe4vkaane37YNLwxnwyT2QHb G3oeZK1ca5RytB6+4oFR/M7uo6w1NtM9731Xv0eE6e7cHcAJj0Gw4A/fjeEO9pqrbbMP H69Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=BhZUOOVT32DJ0ksyt5/YbCj4qJHu/rpUsNQPFqBpZiI=; b=al2wwcXABjuizQPnMn4vaujW7ouNbOihOlyimYrDHm8Kv8VFyrjOcS3Q16TZg4nQo2 aO2UxwGdSWj/jJ4lAPPFzGbNSQ/JRJE6ynKWKX1+YJ7t2H7UI5OQ2MTfgwnf1iGH/nK0 h2lAQK1xsrkIMdOCKmKchiJDzH28HOlvsCEqVnq6FdR3V4ORS4zFp8XFnpncaLN+U9kt KmQIg251AmauRHZimoNQI370toMI7Fr1tsNTrcNiWkqul5Vhcv6OX2aKvqaEP2eUuKxo BCtr4CPYkKehGyq6StRpR1xYl/tHmE46hvXdL9Hnz/78XiSQc+fSt7oZN2sSr+1BbeLM fGcw== X-Gm-Message-State: AMCzsaUhz2vQqI0i4+Mg2MvHSSmw2Cmkw4UWQUUJqBZWLGiSRcncD1dw DGsxZu7XYPk9qLP4fTn56cr3 X-Google-Smtp-Source: ABhQp+Tkf4Ud6J1oIWnDa2PP62SeCcV7xEBo4eAggzseu8pluLtIzJUTkH1Xpfmc0tXVvv0DVhlomw== X-Received: by 10.28.234.69 with SMTP id i66mr7919510wmh.21.1508853113677; Tue, 24 Oct 2017 06:51:53 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s196sm427501wmb.6.2017.10.24.06.51.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Oct 2017 06:51:53 -0700 (PDT) From: "=?iso-8859-1?Q?N=E9lio?= Laranjeiro" X-Google-Original-From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Date: Tue, 24 Oct 2017 15:51:49 +0200 To: Ophir Munk Cc: Adrien Mazarguil , dev@dpdk.org, Thomas Monjalon , Olga Shern , Matan Azrad Message-ID: <20171024135149.fyg4nzcbygo2amtz@laranjeiro-vm> References: <1508752838-30408-1-git-send-email-ophirmu@mellanox.com> <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1508768520-4810-5-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1508768520-4810-5-git-send-email-ophirmu@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 4/7] net/mlx4: merge Tx path functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 13:51:54 -0000 On Mon, Oct 23, 2017 at 02:21:57PM +0000, Ophir Munk wrote: > From: Matan Azrad > > Merge tx_burst and mlx4_post_send functions to prevent > double asking about WQ remain space. > > This should improve performance. > > Signed-off-by: Matan Azrad > --- > drivers/net/mlx4/mlx4_rxtx.c | 353 +++++++++++++++++++++---------------------- > 1 file changed, 170 insertions(+), 183 deletions(-) What are the real expectation you have on the remaining patches of the series? According to the comment of this commit log "This should improve performance" there are too many barriers at each packet/segment level to improve something. The point is, mlx4_burst_tx() should write all the WQE without any barrier as it is processing a burst of packets (whereas Verbs functions which may only process a single packet). The lonely barrier which should be present is the one to ensure that all the host memory is flushed before triggering the Tx doorbell. There is also too many cases handled which are useless in bursts situation, this function needs to be re-written to its minimal use case i.e. processing a valid burst of packets/segments and triggering at the end of the burst the Tx doorbell. Regards, -- Nélio Laranjeiro 6WIND