DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
	santosh.shukla@caviumnetworks.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] event/octeontx: add support for event Rx adapter
Date: Tue, 24 Oct 2017 19:57:15 +0530	[thread overview]
Message-ID: <20171024142714.GB27846@jerin> (raw)
In-Reply-To: <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com>

-----Original Message-----
> Date: Tue, 17 Oct 2017 16:41:44 +0530
> From: "Rao, Nikhil" <nikhil.rao@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
>  santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: Re: [PATCH 2/3] event/octeontx: add support for event Rx adapter
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.4.0
> 
> On 10/17/2017 2:23 PM, Pavan Nikhilesh wrote:
> > Add Rx adapter queue add and delete API for both generic eth_devices as
> > well as HW backed eth_octeontx which supports direct event injection to
> > event device.
> > The HW injected event needs to be converted into mbuf, previously this
> > was done in eth_octeontx during rx_burst now it is moved to
> > event_octeontx as events from Rx adapter are dequeued directly from
> > event device.
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> 
> I think the code readability would be better if you compared event_type to
> RTE_EVENT_TYPE_ETHDEV.
> 
> Reviewed by: Nikhil Rao <nikhil.rao@intel.com>

Fixed the missing "-" in Reviewed-by: and applied v4 series
to dpdk-next-eventdev/master. Thanks.

  parent reply	other threads:[~2017-10-24 14:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17  8:53 [dpdk-dev] [PATCH 1/3] net/octeontx: " Pavan Nikhilesh
2017-10-17  8:53 ` [dpdk-dev] [PATCH 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-17 11:11   ` Rao, Nikhil
2017-10-18  8:12     ` Pavan Nikhilesh Bhagavatula
2017-10-24 14:27     ` Jerin Jacob [this message]
2017-10-17  8:53 ` [dpdk-dev] [PATCH 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-18  8:48   ` Mcnamara, John
2017-10-18  9:06     ` Pavan Nikhilesh Bhagavatula
2017-10-17  9:29 ` [dpdk-dev] [PATCH 1/3] net/octeontx: add support for event Rx adapter Bhagavatula, Pavan
2017-10-18  8:45 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-10-18  8:45   ` [dpdk-dev] [PATCH v2 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-18  8:45   ` [dpdk-dev] [PATCH v2 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-18  8:52     ` Mcnamara, John
2017-10-23 18:09   ` [dpdk-dev] [PATCH v2 1/3] net/octeontx: add support for event Rx adapter Jerin Jacob
2017-10-24  6:56     ` Pavan Nikhilesh Bhagavatula
2017-10-24  8:10   ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2017-10-24  8:10     ` [dpdk-dev] [PATCH v3 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-24  8:10     ` [dpdk-dev] [PATCH v3 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-24 13:00   ` [dpdk-dev] [PATCH v4 1/3] net/octeontx: add support for event Rx adapter Pavan Nikhilesh
2017-10-24 13:00     ` [dpdk-dev] [PATCH v4 2/3] event/octeontx: " Pavan Nikhilesh
2017-10-24 13:00     ` [dpdk-dev] [PATCH v4 3/3] doc: add event octeontx Rx adapter limitation Pavan Nikhilesh
2017-10-24 14:21     ` [dpdk-dev] [PATCH v4 1/3] net/octeontx: add support for event Rx adapter Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024142714.GB27846@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=nikhil.rao@intel.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).