From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0052.outbound.protection.outlook.com [104.47.36.52]) by dpdk.org (Postfix) with ESMTP id E4DD51B261 for ; Tue, 24 Oct 2017 19:25:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EXrOVORiySqLx2RyHm8p28b0jjp+SjcHxZgkv0sh5kU=; b=Abjg2fEY0D3ZVAlOG22pU0r+vuzN53fGP1GLQTxgu+jxQOzwDz6JEsFagLyHnPw3G2QvIkgV9WbfS57mE3QiPFFnZMYsAXxTFkSan7xLKDDRpAaWK7L2JXGkibzASE+Ydd2t3JFyw1I+o6ofEQRy30We6iZgV/Rq7jo1OOO2kI0= Received: from PBHAGAVATULA-LT (103.16.71.47) by CY4PR07MB3463.namprd07.prod.outlook.com (10.171.252.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 17:24:56 +0000 Date: Tue, 24 Oct 2017 22:54:40 +0530 From: Pavan Nikhilesh Bhagavatula To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20171024172439.GA18820@PBHAGAVATULA-LT> References: <1508779012-56186-1-git-send-email-harry.van.haaren@intel.com> <1508779012-56186-3-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508779012-56186-3-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR06CA0132.apcprd06.prod.outlook.com (10.175.207.162) To CY4PR07MB3463.namprd07.prod.outlook.com (10.171.252.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63912490-8a84-4b63-1d3e-08d51b0425d3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603229); SRVR:CY4PR07MB3463; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 3:JTTFJrNKUz8u9eGRr9k9/B7P1C6NxzDkoMF1u0vHMDW53eDglOUvkSvAX0k6YcACA5Dc66QSuXi2++y47bbfzclw0FWn9NzNbGQVdUVmFRjHbmfjiq/eflPyL0XwVnuU85b2gGz9aPrr0CM7eyyKoWSRBVkG/ZFSkgcYEwAgqwMjqx7EmmoqzoVWb4g3vwj9aCuHaoBIz6zJA138X0fuXLUbXise2iB0cdmKUKgnP4+Tn7U6h3WzY4JI9IX2SIE0; 25:adxr+2Y3dW+WnSExJ1+vXHKGa+dP8JFU98ae0yRZaECbbbP0h0jJm5f38KWfIeW+YULxYqYJbLSzX31eP7O+0eARh8Ep0hWkzJrCfkpQbf5Uc/rNVmozF5rw0QpbZJSJkOjmQEUN9XBRD8t2/sKQcD7688zV9a+QhbVzZj/bhdBQ9VbnA68M/tf3TUUIbmrrXIRNz6jvEv0OojqsIJokdFcMBhNQMtplnWxYLrLdcX/kEJRiWkIPKOM6nmMFhioea3CgDGNoOT7ju771s9MhZD2YLnxe8EAnUl7QYLXV9vWo+yHo5MHZ2sjLxy15sp7cN6fwlU3N7gwZ8S6gsh86Iw==; 31:VNNVBc5T7TZ4O9msRf+CQL9ebtkHFm6Z89M6gG7xKEKsRNVXWuIJS0ewvZfs9gU6ToQbgbT0kbF35sDPw7dEzbRvtBQ8RVxCC24ScQ06WmTfmgtoJBGKoYYZdoWbi4Czyf6Q7aPTz2teRp1f1XFIbVdwaY9W5Df8WUtkJdQCrnpwM8VrV7aXUh65xxPVpRFFI33+3dYzxuxq87SjH7GIMBCxu/qVjgKY8d761G2Uaks= X-MS-TrafficTypeDiagnostic: CY4PR07MB3463: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 20:b8jNr1NuFQIQakFsFpQEeA1bSOnZBNaRfFStlgsnt5RRrs9s3+oztiMX2SNH2b/ZYwcvpxVWnmDISDa85bE7eht9yAaNC4SbMBK9cL3vY8+3bSZGWW82Cw8Qtta4walviMv+UXgx2TCyAhHVxTesf4vWNgbnkcia0ZIeAHHDM0D6IDqJyltce5MYx4gAmvAcUQRHFYjYfAxxMmAGZPfFlBv5AgLIv3FQK1RYc3jh1KafmvZCeU4MFHVrMq+4dL/FueuU/7jeWas9/Z2PIZPzs5op0Xg+oAziw0/mSXmqOLoCwTB3gFTVfKn4t92HD/y5UKuJGQO+9tMdhXkCkvXDtb3/4M1tjXfFrvTiXmjpKx70omwaUBN2g5PBtgnIVm55fgIyfCS7u8ap2cdipUQf2f7R8VdGrXhMOVcAbqeLsQLrVhAWI8hc6kxK7PKMoTzsWv+Hr3Tug5Prv95fa3FzE/u3Fbq9p3lYuak/8VnK2xN68DLXxVpo1Qt73c6hS/tnv2Haj85PzfvhjT7+z9sVawlQiP7GvdSDomja58hNNIQiBEvS2FqI2yYMSzl29YEwjMLVkubKYC+4osJsJsJpbAzEhPsr93/BzgQoAqAQR9c=; 4:i8Py83u/O+QKwjajEMWnOHI0d/15xz+sd5XZOFHt3t2fALw16fbWNroAKMHza37HkFdxzKSPg2+e/AcMvCmezlT25OyJut8Nob006ojEeB7YfD8zE3/ZdKFS3mZZTWd61szaWVvbBFMC//VZREATMcWWGoyzpk5XXIzPOLxcO1kpjFL9lFbKflf0HZjyu1zV0CGX+KCHFSa6YdPFGHx6YT8h8bGqqzHEjxe7HevX2RuSaTJn/MoFjlEQG8DS//cWXIvMNNhIMCegNFYpk8XLjAeixwQL/V6sE40I6K/iEoo= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(3002001)(3231020)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3463; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3463; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(199003)(24454002)(66066001)(58126008)(229853002)(5660300001)(72206003)(83506002)(33656002)(47776003)(53936002)(97736004)(6496005)(316002)(478600001)(105586002)(106356001)(305945005)(55016002)(16586007)(9686003)(101416001)(3846002)(50466002)(7736002)(23726003)(6666003)(16526018)(6916009)(33716001)(42882006)(1076002)(4326008)(2906002)(8676002)(6246003)(2950100002)(76176999)(25786009)(54356999)(8936002)(189998001)(81156014)(81166006)(50986999)(68736007)(6116002)(18370500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3463; H:PBHAGAVATULA-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3463; 23:NAlYUSxVyIU1WaxmowK4fbp2YSmuYImaHilsZDECL?= =?us-ascii?Q?dvqCQlVwrbs4yDxtxMXCmjyxr8NmfpRJetMG36fUbctNXTfSclJmFYK9Or5z?= =?us-ascii?Q?gtl2EAMgVkn9uLAanW6eyw/IIA1vqw/SsI3XntZZ44kIfbN2F5YjXxvZ4Eu1?= =?us-ascii?Q?epYJKQ6hGb0smvwxvaRVOiDtJJoqwGR6bjq+IdXoY3Q6WWMUp1Bn1EnwGJ1g?= =?us-ascii?Q?DlRzth+Jg4AfPBs/4yVAE+D/bBv9P3vhFeb27Ft8yL1tdwSuJO8zkFlmIrdH?= =?us-ascii?Q?6U4H+j2qIg05RTri3VtKtqwgA8vBDCPJgonJCdGZ2kD6AzVlg6LqeV89RLu6?= =?us-ascii?Q?uTluL+k7IWrNaPgjRXujC+rcVaqK5Jdq0dErZEjOJeoRqgskVym4FFZiBOL0?= =?us-ascii?Q?1lQWwy8T+vShpYkwwdqwcb+VcfhCbitz5ytrARAnQE1S8uVGLhsSM4DJGew+?= =?us-ascii?Q?xM9NSdIKHS+e10BIC5YO5X5BL2WcpG6q2bZBsXvLLZ0sNLLYUGNvGopP7gev?= =?us-ascii?Q?oBjQGH8DdkvqQBobljbfHjF+CGVszjXB0qfaoLWOQEx0YIJE+heaeQ1sMCAA?= =?us-ascii?Q?kbgBB1pQLTDpr/oqTKVeYMbc2lS8ySbYRchNvo0qne6MIdd5MPoTj4tmBIFH?= =?us-ascii?Q?CVEk/STtyZ8ud1SGHeCoRlaMvVWv6kAlNROuHPBgQmBNEqk99x3vOkz/kiM/?= =?us-ascii?Q?AHa91Q5x++n6Vm9v7eEBf7Y1OBmGA+0BWzkSYTZAmwxYgvoRYFsK4aknFRdW?= =?us-ascii?Q?KWM7WO8WHNSbpwRIsClIFntCFCHDFFMxD9AbdQnlxOtkyFpGh2xglBmgf9vG?= =?us-ascii?Q?tD5LgLKHtKbdlFoFQ+r0ZF35Jbs0CrDJcWjWQP9+dZbXGgRL0LgA5FfHzmfJ?= =?us-ascii?Q?0GWdedQW61xAz/yCLNRbovBUU3QIeRXtnjcoxpKE0U3XjScAnFS7GOI5QRT+?= =?us-ascii?Q?wz0+qnLltIT8SlDA75QNwcHZrv2Xl4o9+XJ9GA/PVsBFTv9/B32t4ovH0XiL?= =?us-ascii?Q?77OvgcT3raVoG90t/Ytg/O9JFlmc2BrOemjo1BS2fvLqt+EOxHiPw6DFVVJa?= =?us-ascii?Q?iCug53FJrVKTnBCF5fnyxRfI8n8rFwwbYMIpkHbMx8RB2tH7BJntSJzXtEvw?= =?us-ascii?Q?hngOGdqXKcCY/yi7H+0LQFtig0+X8KhRIQRJthyK26CX3rUboIPTeX796sG9?= =?us-ascii?Q?YcMX1ySkYpSK5AV+uB7QHTCiMR6yKgDRsyVPZKICUerTaVGJYcfhfLnvw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 6:WS9XEF54F8SFHz7b2LGVm7oN/nuTYz70Vzl31UkeHNy7OzUFdulCdnqsLRLQbFd8nBQtCxM03oaoIzSSBBnAJo8OMTrw/6WBr0aMOlrJV9mFCMXfmP10dn2xusIOqCv4Opd0sIQH85rdFwyzMbYxwgsfh9fFpbh6JEJ37HH71rSsHB8hNAXq0WRJ7gSnFKLJDKt+OMvAldabzFumbrVMsQahYpzS1chHNrQ/JF7swFgzQOX3YdmG5JgBcqNRcFxeEGO/dGGdjtfsWQqxMlG3qL4XEbDU16DaLNc+0JizbAwBCkHdiYXwDOBQZ0nJ/DhipZb6Dgq8jylVHGQD9Z0ziQ==; 5:/wKGSAIbnV9zhSDgfOLVwAoOInfYTbQuh2uGwwe1wMsCu9vGSYj3k3bDs3yLF7NpS4ZJu5pi4e214Op6PoQX/3zkCQcRz7d+X3cNoxtrZyyNcMsVF7tzMcPyMZPefp4v8Nq6akyh2DiJftcYMH0f7Q==; 24:vWSe9Sx87Ur90XulN795QvWexbzBnHelA6NbMPpYdpkyDOMsPra5vphcgTBTTMaaUXj3LqSCOs9t62t9eY8QNAY8EJ2pVBDNX6wHGJqAc84=; 7:wo6pHTFd2UeSP1PBazFuREokSRzwxuIM6U577CwSOCxX+2sj2YTEAcQFloPwGqEr1q0XwJWqxT5WEZtimPXEniKrP15x5qGApuPYH3kU8pUrFy7Q+vYFBXtG6GS8a3qc/cYX/+bmSj4KH6XQeu9O/7PxpWReAiJ1c8MDumPOrz7hFh1qE2iXG5TEqoD6X1zAZHKko5YjNlOXt2ymLUclal62kdvtcT5yXwz3iP1YRN0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 17:24:56.0267 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63912490-8a84-4b63-1d3e-08d51b0425d3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3463 Subject: Re: [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 17:25:01 -0000 On Mon, Oct 23, 2017 at 06:16:52PM +0100, Harry van Haaren wrote: > This commit adds a new function to disable the runtime mapped > service-cores check. This allows an application to take responsibility > of running unmapped services. > > This feature is useful in cases like unit tests, where the application > code (or unit test in this case) requires accurate control over when > the service function is called to ensure correct behaviour, and when > an application has an advanced use-case and wishes to manage services > manually. > Hey Harry, The patch looks good from a logical point of view, I have integrated this with 4/7 and 5/7 of the patch set [1] for removing eventdev schedule API and everything works well. My only concern is that the function name is a bit tricky to grasp. Unless the application(dev) knows the internal working of rte_service_runstate_get() it would be a bit tricky to understand the role of rte_service_set_runstate_mapped_check(). I think we should think of a more appropriate API name for this function. > Signed-off-by: Harry van Haaren > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/include/rte_service.h | 23 ++++++++++++++++++++++- > lib/librte_eal/common/rte_service.c | 22 ++++++++++++++++++++-- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 4 files changed, 44 insertions(+), 3 deletions(-) > + * @param enabled When zero, the check is disabled. Non-zero enables the check. > + * > + * @retval 0 Success > + * @retval -EINVAL Invalid service ID > + */ > +int32_t rte_service_set_runstate_mapped_check(uint32_t id, int32_t enabled); > + s/enabled/enable > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > * This function runs a service callback from a non-service lcore context. > * The *id* of the service to be run is passed in, and the service-callback > * is executed on the calling lcore immediately if possible. If the service is > > -- > 2.7.4 > Regards, Pavan