From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0062.outbound.protection.outlook.com [104.47.1.62]) by dpdk.org (Postfix) with ESMTP id E599D23A for ; Tue, 24 Oct 2017 19:55:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+rcmuhuH2k77sIWCK3z9L7MeNKSzjAp2zwCV3fV0R+Q=; b=lZNet03RZCaFnzobuE1q5CTpWUenCDTbA/Jr3aECam6ZaxmWSa3Liq77Sh9QhHr41d4KLHq9dte0N7ldj/TeFmggDuhCYq369hnMCk7WRTdVZ6UqDFc2XYdXwZXtU5w3gxzUrTpxYciIS9E5sC5bLjbuGBa9RRDb0YGm/uXgEuQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from yongseok-MBP.local (209.116.155.178) by DB6PR0501MB2039.eurprd05.prod.outlook.com (2603:10a6:4:6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Tue, 24 Oct 2017 17:55:14 +0000 Date: Tue, 24 Oct 2017 10:55:03 -0700 From: Yongseok Koh To: Nelio Laranjeiro Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20171024175502.GB20667@yongseok-MBP.local> References: <8c8fb4394ba85f5bda005119cbfc851a3b728fa6.1508844772.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c8fb4394ba85f5bda005119cbfc851a3b728fa6.1508844772.git.nelio.laranjeiro@6wind.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: SN4PR0501CA0106.namprd05.prod.outlook.com (2603:10b6:803:42::23) To DB6PR0501MB2039.eurprd05.prod.outlook.com (2603:10a6:4:6::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 408fa163-56f4-4f99-45f8-08d51b086169 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:DB6PR0501MB2039; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2039; 3:1LKhdTvEi/SXLf7KxtK4XWJOFKpRwWJ9ELauD/vc5ihMSsXIVx/ljdxodww9Ox6Ougs/4zhHKcQtleOpTJC7S1IT/n1p2Nj01zNd545RtdOMu3u6x38A5+MGqWyUzOm0+yR4vzJcOBUUJO7kGUXzlghfhjSUcJh74l06xWncNTHO5BRk0biWmTm5C//sBbbMlkiR1e+8hnBZD0RL4vgkOS9e1Vx5+vadb+eZFh5iUA6sB87AHOn+fNrecFkBde0N; 25:nO7uqMXqSF3Gev/EIfWI0kbBIlBZI1HFejyYtjh/IUVeLFSUSVCHQwe5kWUqfq3iXMmIzMua85hPqeVDAFM/EJHquP3c2bO2z2/FshgpWtQdNRyAuLQ7hl2mgxAAmFJNYA0SAUEQnsxPVvi9JAk1gQJbMaFwLGwSlOFFL0B2wcnrMym1r3+aSmQQQsNgu6dVSDIscmJ5ZF5PzHpF2U0aagQSk2malTmlVSW9ADzI1aGdqcwMMUlvKDZCTh5wVqsgVnl5UJ3QQ8BsB8xtrNASP0G2taR+j5rgJMCqk1ef82w+Xtjz48mKRiCUFTM8DCVDC6tri7hoGbgQlOO7lVNWuA==; 31:2ZY+BpOztR1/OgeyIceloJOxjn+jo+AGgm2kd/ZJoB4icMWX674X0DQp251rdF7wPxwkps5OoVBxxDq1Tf23qWJK6CjXX0RtTPQN+fijJ532CduEAcoMyeg6qcVHqeQ6orS2aqFB2bxa6r9qVysGwKWXGKtqBmtJnGISZVnzwZHEjRXvx8JLWeXDm62WJ2OhwGFp8Ke/6M+h9+PJ7dIjl6RHmbMcKOGImzL/DxmtvtM= X-MS-TrafficTypeDiagnostic: DB6PR0501MB2039: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2039; 20:qIB+B27gJAz4uq2xz7x0w6qDd3KgAlY8UX1SYkFVAsiyOwSBPRzWDH/Ab50goLCvlA7opel8meG0BJv3jm8gn4niKA/HiNC8yhTnutZALwzL+B6E/SsO6lsftkP3Pq9SMN+1RYarJLf0GJI3baMaQh1kszpCPyf9gXuJIa1o56yxIpKXR5AOueaLOCIxs5HSSEN7LdJf+5MQ09rrPf1r0bhIuWiK2Y/G7t7c/v/exrsyXJTbWLJMI6+tLP8XZ7UI0gfPvqeazYqNne08Bwf8CjEdMj54CpM6LRZLZjDIwgFazXNFxyOsnESTJx3qicAF0ETxwzMysf5pHmhQhUZqonaLrSQ0pPCETFm/1NIzyPZaed0fUC+0bC+FB+Ht9ZcVVhnEdf4skKRkVzg2hwFtNkpj/M7xJO+Z9OQ00KzM2ChJO2CCPhI6qt6HjORzGw9/UIqHba5kj1NG725hqFw9Yss2Tagh7yvY7JltxMOin9jRFj3VXElqF0yQvkUlT2Yx; 4:1QPLrL5o36kLXZuv2ahrxxlBLSN0u218IzSZ6Jt+Z1okL6NSoNOWZdE9Amj5re8HTheUky/nJTGUwf4gcn6cTNJk267etE3vRc5HwyH/2Gw3yJn2IF71zDRTgd+ZQweHEbsSwx0u5Vtr2INRYSFqH8DjjNFAIoAfdqXMF+gGCkQIJ/VByTfiL6bFj6fCuur+UzENhRwUSNmk7yR7WbyZyIGWXT0GmpAVMDs6VyqEmKs4FfPp8fp2fOOv7Dxd48ZH X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0501MB2039; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0501MB2039; X-Forefront-PRVS: 047001DADA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(199003)(24454002)(50986999)(4326008)(2950100002)(58126008)(8676002)(81156014)(106356001)(8936002)(83506002)(16526018)(305945005)(7736002)(105586002)(101416001)(33656002)(16586007)(53936002)(6246003)(76176999)(55016002)(86362001)(81166006)(25786009)(316002)(54356999)(50466002)(9686003)(98436002)(6666003)(189998001)(68736007)(478600001)(3846002)(6116002)(66066001)(6506006)(5660300001)(6916009)(47776003)(229853002)(2906002)(97736004)(23726003)(1076002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2039; H:yongseok-MBP.local; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2039; 23:xjDvIaSxyHj68xqRBK0C9bgHlfCJqEAeCcCLy2Y?= =?us-ascii?Q?8dHUbU3h3MRu9MmHNg5VyKGY79X/Lk2tJMFmoIbiLzP2+rPFX6PZ+xsFQ+rm?= =?us-ascii?Q?UEi+ffeG/nLLi4E2ITmMANwhpt1UBkW2+ZcDeZL2suCESe8SJvGJWUqUmBUE?= =?us-ascii?Q?Xy+hiJ/QQAHxCMa767pLiqAOz8mpcZuFn4ACe+0C0i5rpeC/sDm5ZKj9iwQZ?= =?us-ascii?Q?xiQGuV0qKssBI07BnIBYb4cXQaShGj45avoQTnzPmlbGfHPW935+hmvvuB5n?= =?us-ascii?Q?WHyyrblRCxJA4tmSrLXs/WLY/iB/2mm4PD0fMRlaSklEOd+BYetOkpa1Swpc?= =?us-ascii?Q?tYRDl5qxMr/dKd3YeDwosMUNXD4yl9JDQYg5igZ8tKC8m0y00sIgMlez7XEt?= =?us-ascii?Q?WcynNXm9X+Zf6Fo9hbaiteg2kB9PkP7RLdu7Se/HLICyq1/QXwLRSQndojHN?= =?us-ascii?Q?VoukAiKU93wXeQyTUOSdWx10STewbot8b/3oEZkWOqDAKUWj+1oHPocm9YRI?= =?us-ascii?Q?wTNZm4EhMTOgnlIQnYfvG5C+JoPMNXRjH+3rK3I88lXlVQZ8HNYMMmOS7ssx?= =?us-ascii?Q?NkYzAf/vWm0wCAPR1XddAWhsEAd0FJy67pAyuEd32LTL2oBOq8BZIZ/ij88c?= =?us-ascii?Q?iKE8xBHBay+IgJ12HF/xS0A7XS0TgYl07okfDB8R4LRg7EHwWfyQI2jpn/4V?= =?us-ascii?Q?n+MxK6X/D5Gg7FKQ3C0k1x2fMo9s1hqDQRghVGUmplI3tqUALPRj/E6sFtDm?= =?us-ascii?Q?dAH53ipyj+n8waBSIby13xLofBgcZ8RVzh8oAD22sPP4pTOhSjSH5ROHRyuK?= =?us-ascii?Q?3Hhbvuujr7aoz5MciMs92rGtm7DpRwfDNbdnJrl++pjbi0+DkAw0/TiSiF1G?= =?us-ascii?Q?DrlHdSRjlZ0DQ9BitJLcXvopjLWd0COJ+b8oEDLgY3JN5yWBglIgh6gdmlXm?= =?us-ascii?Q?ad90/kjIVL4xcrliGFlJ1UfZJqr22s7/rOKzry/0qqKPMpZrd4LdOvalyG/U?= =?us-ascii?Q?J6Qe8Cty+2dVHDwquRIev8A3AwGj45zJDlSvQN8cUGuu7cCV5FMrw5yNwo0+?= =?us-ascii?Q?ep16a28BFHI6UmoEv42da4zS/y1VubKbwMsyhJz47f+NObVxO0Gb5SAWwVHK?= =?us-ascii?Q?Qf9nwybMEdnyt0LZWVcXDD0E53wESdFrc79Iyzlth3aFBZGmJ8/DlJNhiV6E?= =?us-ascii?Q?y9/4uF/eXhVc2ksx67X4DcPnuG2N1QPjI+AMg?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2039; 6:WG1cKVxu/uwZnM6PPfiEtBnqbk58nR2MmJm4pmQr7MuMGbjHfuS3AvWw6PHue9BsK6q99tTrY9cyUsBmNUKYKjU5cQxPP5qEkwBa1ESjxDafz8YYXFiX4snNGe1BI3GtHK0BVfpvItP1ydPopa++I+dMGr/nm/LghmhlER9W/qZ8hCVzoI8ykB0FROXzHlbvBFMIiLmbqVCNVONlO+L3ThZFFRJlQAucQYYCyEgkmyOkaXR0K/oJvazF8M9aJNX/Y1XbTMMoxwmJsfEyjDxrkg3AqgNb45CzUvMxHhhgPvkBWJOz8NizSJCC+DgQNrEDajNZaGFbB+vuLnY0aHL64Q==; 5:jWnfphCTkhumCckrhlxUNUMu7JnfBbumNIpP+bo8PJW/GIa6D9GGc89/7cF1Y6O3hUPPrvNUvGBObr8nr8dQbxBkOAdTjRzJd2JKwT4sPrbTh2i0DL/gFBqnQUNg9IvSv4LKubwYIvBhFJLk1+ywtQ==; 24:w4QgucR4VAPOuPz/kxno2TuCk0WczuMlyoIYI7ckQINZI+JF5ZSJR7OFRpUUXo4PC0SszEcyph2Z9LVw2liqQQlSV/qfipl7dTbCKPvYU4o=; 7:AGWJxHJrh2OZyaG9kpHq7adC4c3jD+CK5YkjT/YqcQIHil0op0Qkk/znYLWYIjAieCXf7xMo32Qr1rRvL2mNZXEWg392NCw5yKyAMf+n5UKfqUSR5M9ElIuXsWKoW2hYUHQUgsPTjXa+NR4dC0g+dO+eAH9wd0aYwwx74AXvf5agbyrkJNLcL7HWzQP0ler4esv05FLN0kR8bYKQRzBq1tC/HYWMaSC1cmvVLj/Y9nQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2017 17:55:14.2489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 408fa163-56f4-4f99-45f8-08d51b086169 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2039 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix adjust priority for drop queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 17:55:18 -0000 On Tue, Oct 24, 2017 at 01:33:19PM +0200, Nelio Laranjeiro wrote: > Drop queue should also adjust their priority according the most specific > layer in the pattern they are matching to avoid dropping all the traffic. > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 26cf593af..549ae6916 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1185,6 +1185,14 @@ priv_flow_convert(struct priv *priv, > parser->queue[HASH_RXQ_ETH].ibv_attr->priority = > attr->priority + > hash_rxq_init[parser->layer].flow_priority; > + } else if (parser->drop) { Isn't this condition redundant? And the following could be more consistent (and readable) with the similar code above. But I'd leave it as your choice. if (parser->drop) { ... } else if (parser->queues_n == 1) { ... } else { ... } > + /* > + * Drop queue priority needs to be adjusted to > + * their most specific layer priority. > + */ > + parser->drop_q.ibv_attr->priority = > + attr->priority + > + hash_rxq_init[parser->layer].flow_priority; > } > exit_free: > /* Only verification is expected, all resources should be released. */ > -- Thanks, Yongseok