From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 397FD1B868 for ; Tue, 24 Oct 2017 23:20:07 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.224.233]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5D1A930C038; Tue, 24 Oct 2017 14:20:06 -0700 (PDT) Received: from C02PT1RBG8WP.vpn.broadcom.net (unknown [10.10.118.158]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id CDA7681EAE; Tue, 24 Oct 2017 14:20:05 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Tue, 24 Oct 2017 16:19:49 -0500 Message-Id: <20171024211953.12021-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.13.5 (Apple Git-94) In-Reply-To: <20171024211953.12021-1-ajit.khaparde@broadcom.com> References: <7b5c8ca8-7523-add0-0cca-826278496a19@intel.com> <20171024211953.12021-1-ajit.khaparde@broadcom.com> Subject: [dpdk-dev] [PATCH v2 11/15] net/bnxt: fix a potential null poiner dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 21:20:07 -0000 Fixes: f7ecea911ec5 ("net/bnxt: fix interrupt handler") Coverity issue: 195046 Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c index 79a119623..49436cfd9 100644 --- a/drivers/net/bnxt/bnxt_irq.c +++ b/drivers/net/bnxt/bnxt_irq.c @@ -50,10 +50,14 @@ static void bnxt_int_handler(void *param) struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param; struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private; struct bnxt_cp_ring_info *cpr = bp->def_cp_ring; - uint32_t raw_cons = cpr->cp_raw_cons; - uint32_t cons; struct cmpl_base *cmp; + uint32_t raw_cons; + uint32_t cons; + + if (cpr == NULL) + return; + raw_cons = cpr->cp_raw_cons; while (1) { if (!cpr || !cpr->cp_ring_struct) return; -- 2.13.5 (Apple Git-94)