From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id B8D06271 for ; Wed, 25 Oct 2017 10:06:02 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id r79so23044666wrb.13 for ; Wed, 25 Oct 2017 01:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mBkr/Nfw2sysLUhLPL92oQkfcqPVlMINKoVITxxYGFU=; b=wyC1MY1qbEwBk7EILk2HL/xU7Nb6+J1WcTb0phluF9HXi9NsDNY6jt+jbzCRzXAQGY urmK2FWsHpOlbLRg81zRt6DBcIlY//ToqTz26KGc220teXHUz3R28KDKP36QRk5uPm0g pSe3fxtpiH8RJI42uTqi57LeJ42Cedeox0QI1FpfwBVgzDRW8Q/1s3ErXUsSXpOoCi+T uEHmE6tx1aSYPq/IDpbz2CB3tN/P4/OYPeWgBmpPaG6GI+Yk0D1d4db+aARERaLfijPt htAifDLz3igs7V/bcCxKauYYTrGsfeWELFFPPcEJe73OlwRHUvqyTPvwZAHd42xsobbH Fi0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mBkr/Nfw2sysLUhLPL92oQkfcqPVlMINKoVITxxYGFU=; b=Xv6Q1l07KPbjGsoSGuycAE3jrOq7KNNXfe4twuSxUsYwbPUZzwffSo6zmRp4Lza2M8 +pH3BboEj2tM+t/WSImcX/EYR7ci3mn4QUeJkdbwHYK156XgFHyj0ns7hw+ubgW4vMmp nzi47WLtW2hT7IzFu0UTqopjO0JnzRwla7LkRMkE8TI4VnbkG7Ip9jiqbRmmyfpae0MM vvJC7g7JD3PrGWkGIQRejMgu0ZEKZNvQRK1TISfErsfig//89pRyv+ga5R2SVxJMxbtG k68xdD9Ui/Vmzi/yRdd7Y9k6X81uN88d0sIt8poBoqJh34wZqWst+HHJq5TodoV03QNa Aoig== X-Gm-Message-State: AMCzsaUoNwqbNrABX8S1az6ew4U6RtpVsqqSdWhoM1NjCWLL2CSukZxP XNJRGidqmQNtTcWQxuRhsl4w X-Google-Smtp-Source: ABhQp+SygoiQBnlaaPYhCPtoP/YRQIAqQGqUz2ZWJJroHP7M1p+lW/yoGl0rNRNh0YQkFrvpJif33g== X-Received: by 10.223.157.136 with SMTP id p8mr1342305wre.28.1508918762472; Wed, 25 Oct 2017 01:06:02 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c82sm1691650wme.20.2017.10.25.01.06.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Oct 2017 01:06:02 -0700 (PDT) Date: Wed, 25 Oct 2017 10:06:00 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20171025080600.25nlxrkracukal4j@laranjeiro-vm> References: <8c8fb4394ba85f5bda005119cbfc851a3b728fa6.1508844772.git.nelio.laranjeiro@6wind.com> <20171024175502.GB20667@yongseok-MBP.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171024175502.GB20667@yongseok-MBP.local> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix adjust priority for drop queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 08:06:02 -0000 On Tue, Oct 24, 2017 at 10:55:03AM -0700, Yongseok Koh wrote: > On Tue, Oct 24, 2017 at 01:33:19PM +0200, Nelio Laranjeiro wrote: > > Drop queue should also adjust their priority according the most specific > > layer in the pattern they are matching to avoid dropping all the traffic. > > > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > > > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx5_flow.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > > index 26cf593af..549ae6916 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -1185,6 +1185,14 @@ priv_flow_convert(struct priv *priv, > > parser->queue[HASH_RXQ_ETH].ibv_attr->priority = > > attr->priority + > > hash_rxq_init[parser->layer].flow_priority; > > + } else if (parser->drop) { > > Isn't this condition redundant? I reach a point that all this "drop" is redundant and could use the Ethernet entry to store it, but in RC phases making a such huge change is not easy. > And the following could be more consistent (and readable) with the similar code > above. But I'd leave it as your choice. > > if (parser->drop) { > ... > } else if (parser->queues_n == 1) { > ... > } else { > ... > } Agreed. Thanks, -- Nélio Laranjeiro 6WIND