From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 277FD1B945 for ; Wed, 25 Oct 2017 11:19:37 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id b189so506458wmd.4 for ; Wed, 25 Oct 2017 02:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Kwr5SlTTbzNqxI2pf78AIrTmE2yK1ewP2HiQpsnx8Q4=; b=pi3h5xvvnJwftyNaeSzbRvF4o/6oJm8tiheSg89WyCOVU9/YcAIbQHlaCSkupKWYUd z4fCC64YR+lkCqQMkMmd/sWpX6NwdgF6eav9MNNpD8tmhFNAW/1p71ZZz2vOXtYLqAeq tiwCW6zLTDVmNBz3/omzIGmYgYRDbmDEqOKhj7tyzs8pQmmjc7H2VWHIRG1tkpHPhiAA EmtaPW6MY8d7FrqEVf4nH2oN9h0vW5q6LoGKPQpRAy2ImwsJ+m1KCae6LOxgtQgW5Teo 0p0f6tiA4NY3FQyPeHF3UCfyZLQOdVHkVHZHfF2D0itlO/92pdxrWZ7CaZSYz6FX59UR lAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Kwr5SlTTbzNqxI2pf78AIrTmE2yK1ewP2HiQpsnx8Q4=; b=YD8yCh0nY7vA+Q00Gf80jXp6M9fuQjrpLpN2sgFwzu6o3RDHxoHfMy1crgSRU98Hbe +rK5kWfG2k9SAR75YjGIzlLV0CSzaqHeAL5GJHDpCmw3gSVsNRng2Ltw2aSD4TYpSENM 5hsdGIIjNyXxZ+oxntLTQ6cFW9zoMCKkV1GSrfvVvTE9eAsr0nOrt3jL9kuswZkpll/1 0bL14xTJdjsECY4yt54c5AVZyU9EQU37hWYet9BXGu6eb2HE/lvjrlfdBCkwFqx5eyfL /iSO5b6iWUCHZhsWFOBvAQGgDhZok3NyNCjpzcJGep+5uibPQq0hpk3SgwIdSjQPgrt0 KAWw== X-Gm-Message-State: AMCzsaUp4dbflkMW0kKyGaa8oQk7apH+S0WvlFvrSFLBkwGu4IPeLqhZ NnDU8thD44fmqa2v5qznkP5h X-Google-Smtp-Source: ABhQp+SPHarwv1a4oImuhxPDT+eu3WovgZ5n5awZYlbJtbXL35VL0Bwefl6XZ49JQQoDMYxpTijvng== X-Received: by 10.28.87.13 with SMTP id l13mr1124035wmb.45.1508923176873; Wed, 25 Oct 2017 02:19:36 -0700 (PDT) Received: from laranjeiro-vm (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g25sm1943157wmc.16.2017.10.25.02.19.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Oct 2017 02:19:36 -0700 (PDT) Date: Wed, 25 Oct 2017 11:19:34 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org, Sagi Grimberg , Alexander Solganik Message-ID: <20171025091934.hvf5fv4bpkzaba2u@laranjeiro-vm> References: <20171022080022.13528-1-yskoh@mellanox.com> <49c39b44917c35ecaabf06f5f920d0f7e0ed0b6b.1508891141.git.yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49c39b44917c35ecaabf06f5f920d0f7e0ed0b6b.1508891141.git.yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix Tx doorbell memory barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 09:19:37 -0000 On Tue, Oct 24, 2017 at 05:27:25PM -0700, Yongseok Koh wrote: > Configuring UAR as IO-mapped makes maximum throughput decline by noticeable > amount. If UAR is configured as write-combining register, a write memory > barrier is needed on ringing a doorbell. rte_wmb() is mostly effective when > the size of a burst is comparatively small. Revert the register back to > write-combining and enforce a write memory barrier instead, except for > vectorized Tx burst routines. Application can change it by setting > MLX5_SHUT_UP_BF under its own necessity. > > Fixes: 9f9bebae5530 ("net/mlx5: don't map doorbell register to write combining") > Cc: stable@dpdk.org > Cc: Sagi Grimberg > Cc: Alexander Solganik > > Signed-off-by: Yongseok Koh > Acked-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Thanks, -- Nélio Laranjeiro 6WIND