From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 5207C1B717 for ; Wed, 25 Oct 2017 12:02:25 +0200 (CEST) Received: from lfbn-1-6068-189.w90-110.abo.wanadoo.fr ([90.110.3.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1e7Ibk-0006LX-FH; Wed, 25 Oct 2017 12:08:21 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 25 Oct 2017 12:02:18 +0200 Date: Wed, 25 Oct 2017 12:02:18 +0200 From: Olivier MATZ To: Ferruh Yigit Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20171025100216.4n2uhllv3exayvhu@platinum> References: <20171023121623.27466-1-olivier.matz@6wind.com> <4171e3c8-31eb-4c40-117b-87ac6a585764@intel.com> <20171024160922.fu7qiciondyikgvb@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] mbuf: rename deprecated VLAN flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 10:02:25 -0000 On Tue, Oct 24, 2017 at 05:42:55PM -0700, Ferruh Yigit wrote: > On 10/24/2017 9:09 AM, Olivier MATZ wrote: > > > >>> But, since we are > >>> close to the release, applying it early after the release could > >>> also be considered. > >> > >> Is there any benefit to be in this release, one think I can think of is 17.11 > >> being LTS, is there any other? > >> > >> And what do you think doing in two steps, > >> - in this release remove deprecated flags > >> - in the beginning of the next release introduce the new flags > > > > I think one good side effect of having only one patch is that > > it doesn't break applications that were using an undocumented > > behavior of a PMD (it just requires a rename). > > Makes sense, overall patch looks good to me, only concern is again making ethdev > layer update in rc2. > > If there is no objection, and Thomas is also OK, lets get this into rc2. > > Meanwhile patch requires update because of qede PMD update, would you mind > sending a new version based on latest next-net? Yes, I'm sending a v2. In my opinion, it could go in rc2.