From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 202FA1B9EB for ; Wed, 25 Oct 2017 18:49:34 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id u138so3091310wmu.5 for ; Wed, 25 Oct 2017 09:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a1+DyRSLjVBeaNkG4a1rj4LS2okDVNf7TxWwvdrCwjk=; b=kVMlO3ZDCK/W9ilVIw0/W+SBmoDeo7UkiGBhmRuqLfTfCze69O3B/lM2t4KYCW2ELb JjvZGs3KqchMGt7fLn55Ua+Qie6qBOjeS5ChPI9xJx/Jro1kr6QamTS9JYpuTb+z5xy0 DYs+a6mW71a4f4Taz9Y/4rN3VuugmDf+j9TFyq/1JvA08Yv3H5LpdVGrcBkY7lCLQ6QT orXOjNu5y5wAzNZsxrdeTVUKm0lVfjgc3nooexF80o5XV2a3WLXvo4dLZxM0zhAWXH4C LUoOicuon5TBGs4sw18AG+tSUV2ANWFfaqd9QnHlQlEwgE2O+F3IDi378wDStktsURlA GYyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a1+DyRSLjVBeaNkG4a1rj4LS2okDVNf7TxWwvdrCwjk=; b=La8d/51trx7OFbCFceSA+QTXA6ihwAcDrZC6vtQYCfBdjdSO2+r7g1wDb1T2cd6NH/ 1GvKZfWwwLGaYyOwk+sN2kSNaccma9px8P/NiQ5e7q64U20rf9PllBOlrlYw0Ms0P6Jj sT9eXfrmC/PyTbzhfHVuGdDbC0Rxe1Zz9uf+RCt1RycbKJGOLoLGNpDmysPverY011YT qTF3yyvp0L7tNsP8FL8AIPeEXxqJn2NHWfr8flXqoYjF7kzNcsWAm0OSq1MSRGkPT/uQ SmbHvRFFmSpZ8gfVopedbnwjOY+plu/Z8nVZMEmlfyoQcA8YKfkyPvfuCyxAixf+/O5Y ULXA== X-Gm-Message-State: AMCzsaXy8gidq0LYP9qq+xuTlBOtqQqqbvuDXGo/ChnS76M2M6+K60L+ 2tA/Un8nt3Lzfb1hn3gqFhU0RQ== X-Google-Smtp-Source: ABhQp+RJtIw5NcgX/qt8Ahf6JmLam/uOSKePid9A6W2xaQCqCPLDG+1wKFgKF4hN013ycghlFbsllg== X-Received: by 10.28.230.216 with SMTP id e85mr2733539wmi.86.1508950173738; Wed, 25 Oct 2017 09:49:33 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o24sm3253941wmi.39.2017.10.25.09.49.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 09:49:32 -0700 (PDT) Date: Wed, 25 Oct 2017 18:49:21 +0200 From: Adrien Mazarguil To: Ophir Munk Cc: dev@dpdk.org, Thomas Monjalon , Olga Shern , Matan Azrad Message-ID: <20171025164921.GG26782@6wind.com> References: <1508752838-30408-1-git-send-email-ophirmu@mellanox.com> <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1508768520-4810-2-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508768520-4810-2-git-send-email-ophirmu@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2 1/7] net/mlx4: remove error flows from Tx fast path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 16:49:34 -0000 Hi Ophir, Matan, On Mon, Oct 23, 2017 at 02:21:54PM +0000, Ophir Munk wrote: > From: Matan Azrad > > Move unnecessary error flows to DEBUG mode for > performance improvements. > > Signed-off-by: Matan Azrad One comment before going on with the review of the remaining patches in this series, ideally, even obvious patches such as this one (ifdef'ing some code away) should come with a couple of sentences describing their performance impact. If it's negligible or just a gut feeling, then say so. If it's significant, then by all means you should provide hard numbers and a test scenario (no need to go in details though). Performance being the main purpose of DPDK and all, it's *that* important since such commits may be considered for back-ports later (the lack of performance can be consirered a bug). Some patches labelled as performance improvements are actually code clean up not worth validating on their own, but possibly leading to subsequent patches with actual improvements. I think it's the case here, just avoid mentioning "performance improvement" without proof. Other than that: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND