From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id ADFA61BAA9 for ; Thu, 26 Oct 2017 01:03:49 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id l1so1493132wrc.3 for ; Wed, 25 Oct 2017 16:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4+gf2gh0461KNWqcUrhd8y6LsbbmqftObEtlSEsALq8=; b=VDqZKVJO1yJZMuA7cZIZm8yiJxkcpBTBr3Hu4QzaVNkpTaiAud87kk4GU4uuKz9Dd6 k0BJm25scKlub9IZFyMiJl33NlstU4DNSv1XbbMwmO5fG7Yl15eRYZTnk2cJJuMDdjjr tR1p7wB5c+HT5BXGNU36D2yqniDHaykBCK3FmszYFfM9cQp3qDjdhwe+CmtXZOUVJL1G rx5fs5QonR8f/VPeCArzOKDXFLpptlWAZ4386ogvPB6sGwC6Ezru06C0rwlL4oUQKYk1 PxapTHdUpqtTCbgxRdI9HMoEvoRIDL8oTt3ExvLkxhRispOmeSJXqjigNIUbiA0HdEOS Yk5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4+gf2gh0461KNWqcUrhd8y6LsbbmqftObEtlSEsALq8=; b=r1+knY1l3V103LwqJ/W0bL5KU6GpJ30cmHt4ajU6jM9y2NeR1fjid2npUkDyHS/PvP Cn7B9fOKmIYkOdaujS0C/jSowO68ucTvxcGcYk7BHPlJ/rnqIdViglgf2sCv2NBYqLG6 vvjiuOp7TvuqmCg/3ogk7yJijmj+CIAJW5Z9leMbxmCnwQUwgvftKP47YaE5l9LK+o2h MMlfqE8NZh0MgvtKpd6EHQRk/wv4kVaRDDDHSSjEL5624hngb91enr2jIWDMu33I3xlv vnyWigFDet3EhGDG9GYGs+PYCOYJQdiuPMIBHa0GGjQ6XqVLyzMcdQK09uJeFwMpHrIz VEQA== X-Gm-Message-State: AMCzsaWsZF1lJcMF2YxhPN30jbVhFriG0T5ZOKfjMsEhOhpaJIhpflOe CxP0B0n9xQaOUbXt+Qw2112GFQ== X-Google-Smtp-Source: ABhQp+TWbIdNomPZCkRDs8xDHRiN2Mht+pYokbDV2PKxwJTz88kLFgHwcQ2+Yn3QGDdg6pCbijFhYw== X-Received: by 10.223.144.76 with SMTP id h70mr3734631wrh.228.1508972629271; Wed, 25 Oct 2017 16:03:49 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o197sm10393035wmg.3.2017.10.25.16.03.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Oct 2017 16:03:48 -0700 (PDT) Date: Thu, 26 Oct 2017 01:03:37 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jianfeng Tan Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Message-ID: <20171025230336.GB10890@bidouze.vm.6wind.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1508951446-70979-1-git-send-email-jianfeng.tan@intel.com> <1508951446-70979-4-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1508951446-70979-4-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 23:03:49 -0000 Hello Jianfeng, On Wed, Oct 25, 2017 at 05:10:45PM +0000, Jianfeng Tan wrote: > Move the vdev bus from lib/librte_eal to drivers/bus. > > As the crypto vdev helper function refers to data structure > in rte_vdev.h, so we move those helper function into drivers/bus > too. > > Signed-off-by: Jianfeng Tan > --- <...> > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > index 4b29e3d..cb12d19 100644 > --- a/drivers/bus/Makefile > +++ b/drivers/bus/Makefile > @@ -36,4 +36,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += dpaa > > DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc > > +DIRS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += vdev > +DEPDIRS-vdev = $(core-libs) > + This DEPDIRS should not be necessary, see commit: cbc12b0a96f5 ("mk: do not generate LDLIBS from directorydependencies") You will need to add the relevant LDLIBS into drivers/bus/vdev/Makefile however. > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/bus/vdev/Makefile b/drivers/bus/vdev/Makefile > new file mode 100644 > index 0000000..6c48ba0 > --- /dev/null > +++ b/drivers/bus/vdev/Makefile > @@ -0,0 +1,55 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2017 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_bus_vdev.a > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + Here: missing LDLIBS if above is valid. > +# versioning export map > +EXPORT_MAP := rte_bus_vdev_version.map > + > +# library version > +LIBABIVER := 1 > + > +SRCS-y += vdev.c > + > +# > +# Export include files > +# > +SYMLINK-y-include += rte_vdev.h > + > +include $(RTE_SDK)/mk/rte.lib.mk <...> -- Gaëtan Rivet 6WIND