From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 97F951BBC5 for ; Fri, 27 Oct 2017 11:33:42 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 27 Oct 2017 02:33:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,304,1505804400"; d="scan'208";a="167801370" Received: from silpixa00381635.ir.intel.com (HELO silpixa00381635.ger.corp.intel.com) ([10.237.222.149]) by fmsmga005.fm.intel.com with ESMTP; 27 Oct 2017 02:33:40 -0700 From: Jasvinder Singh To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, yulong.pei@intel.com Date: Fri, 27 Oct 2017 10:46:19 +0100 Message-Id: <20171027094619.147024-1-jasvinder.singh@intel.com> X-Mailer: git-send-email 2.9.3 Subject: [dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 09:33:43 -0000 Some drivers might allow to commit the traffic management hierarchy while being in running state. Therefore, removes port status check before invoking hierarchy commit API in the cli. If needed, device can add port status check at the driver layer. Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_tm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index 964ce9d..53f941c 100644 --- a/app/test-pmd/cmdline_tm.c +++ b/app/test-pmd/cmdline_tm.c @@ -2033,12 +2033,6 @@ static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result, if (port_id_is_invalid(port_id, ENABLED_WARN)) return; - /* Port status */ - if (port_is_started(port_id)) { - printf(" Port %u not stopped (error)\n", port_id); - return; - } - if (strcmp(res->clean_on_fail, "yes") == 0) clean_on_fail = 1; else -- 2.9.3