From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7101E1BB44 for ; Fri, 27 Oct 2017 18:57:52 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id t139so5025446wmt.1 for ; Fri, 27 Oct 2017 09:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OdZSQcI64Sxg83704/6ZuEeVbujXi0MV/6bBirAL/Oo=; b=yrbOhiTevLK/HIRnjbuK482beiVBx/9jLf3r2hzSk411bCtPGqP//9zdgxRXqxBcJ2 0O0C8y3qZg5TRcy8UT000N6+QiqhJlDOmUuCvekMnO6Etx3b7Q5tMde5l7GpLDps5qmw +QRjvn3ZHLNtSUvPMfCZDKUgsBXzzSndWgSzOF+XW7dwSqqX5snLz18/VRy7//xYr47V ZIaPmwlPZJoK5q4Qw8HQB4RTlM3ePSeRpdjUG6SLHLIB3rLPSgaiqBLOIO6K3G8SYvRq XKzINQlODmwYcmZTMT5xupghX7r6AE0AblzCcYx5BR5YKHyglk8eVg0mWotwbNaDZg9/ 7UdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OdZSQcI64Sxg83704/6ZuEeVbujXi0MV/6bBirAL/Oo=; b=RtIOp3MjVQRBgXZ+MrDtgsl07iCQdC4aB+pJ30OPNYLqgL1PzE57lWcUDmMT4qSmJg +TPomvx55mFIhKpTCf5xQEJ0bM0zdJM94+Qv/e8i9N0jCywXU96eGEJlKaVNbCTxORHD E9az2CRksFFT89Q87Tu6ZkUQn0Hr3OIL2pF6vgl3HSxgnpaSb0qVwEeToJzucVtJN1Ii TVum5diG7gbEDUhaDqKDin2zJGPV0g2zrFZJ3MBo2PsVzpSi2DOSQIuOHuFhMHksG0I5 8afbCL7V3g6AQdo0SonZtXe2LtU5QeiifJB7ls2Ym6rr6+emE7Q9qQdwrsU2aH3Kyeur Jlog== X-Gm-Message-State: AMCzsaWAQcbA+KOns8yERZja93XeRzOi+fU2MHlF91VaOoz8ibqFAGt0 EnOeQR3YIx2f/1qnGgp118utnQ== X-Google-Smtp-Source: ABhQp+R+eZoKRZEVIrn58NwLBtuE241L7oCx0woOVXGFrVsgBkfNwrIxbH1qMDyhWpC7645+9VIO3w== X-Received: by 10.80.224.7 with SMTP id e7mr1479235edl.117.1509123471912; Fri, 27 Oct 2017 09:57:51 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p91sm5631039edp.69.2017.10.27.09.57.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Oct 2017 09:57:50 -0700 (PDT) Date: Fri, 27 Oct 2017 18:57:38 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: "Tan, Jianfeng" , dev@dpdk.org, "jblunck@infradead.org" , "Richardson, Bruce" , "Ananyev, Konstantin" , "De Lara Guarch, Pablo" , "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "mtetsuyah@gmail.com" , "Yigit, Ferruh" Message-ID: <20171027165738.GD10890@bidouze.vm.6wind.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1536098.KmeRH1tTdf@xps> <1534566.pSR1OR4QPK@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1534566.pSR1OR4QPK@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 16:57:52 -0000 On Fri, Oct 27, 2017 at 10:53:11AM +0200, Thomas Monjalon wrote: > 27/10/2017 10:19, Tan, Jianfeng: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 27/10/2017 03:06, Jianfeng Tan: > > > > --- /dev/null > > > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > > > @@ -0,0 +1,8 @@ > > > > +DPDK_17.11 { > > > > + global: > > > > + > > > > + rte_vdev_init; > > > > + rte_vdev_register; > > > > + rte_vdev_uninit; > > > > + rte_vdev_unregister; > > > > +}; > > > > > > It should not be needed to export the driver ops. > > > > rte_vdev_register/unregister are needed by vdev PMDs, which are needed to export, isn't it? > > Yes you're right, I overlooked it. > > > And for rte_vdev_init()/rte_vdev_uninit(), do you mean we all change to use rte_eal_dev_attach()/detach()? > > rte_vdev_init() is mostly used in tests. > I changed my mind, you can keep it. > Maybe it would be clearer to rename rte_vdev.h to rte_bus_vdev.h > to mimic what was done for PCI. So rte_bus_*.h are mainly for PMDs > and not to be used by common applications. > > > > Please can you try to make it private? > > > > Even we want to make it private, I think it needs deprecation notice, which we can further improved for the next release? > > Yes we can revise usage of rte_vdev_init(), rte_eal_dev_attach() and > rte_eal_hotplug_add() in the next release. > > Gaetan, do you have any comment? Well, as stated before, I agree that deprecating attach / detach seems good to me. The hotplug API supersedes it and the only difference from a user PoV is the artificial restriction to vdev and PCI buses. -- Gaëtan Rivet 6WIND