* [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started
@ 2017-10-30 7:32 Ori Kam
2017-10-30 7:41 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Ori Kam @ 2017-10-30 7:32 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro, yskoh; +Cc: dev, orika
When adding count action to a drop flow rule while the device was not
stated, the counter was not saved in the flow.
Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
Cc: orika@mellanox.com
Signed-off-by: Ori Kam <orika@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f392f1f..3999b84 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1690,13 +1690,13 @@ struct ibv_spec_header {
++parser->drop_q.ibv_attr->num_of_specs;
parser->drop_q.offset += size;
flow->drxq.ibv_attr = parser->drop_q.ibv_attr;
+ if (parser->count)
+ flow->cs = parser->cs;
if (!priv->dev->data->dev_started)
return 0;
parser->drop_q.ibv_attr = NULL;
flow->drxq.ibv_flow = ibv_create_flow(priv->flow_drop_queue->qp,
flow->drxq.ibv_attr);
- if (parser->count)
- flow->cs = parser->cs;
if (!flow->drxq.ibv_flow) {
rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_HANDLE,
NULL, "flow rule creation failure");
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started
2017-10-30 7:32 [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started Ori Kam
@ 2017-10-30 7:41 ` Nélio Laranjeiro
2017-10-31 1:41 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2017-10-30 7:41 UTC (permalink / raw)
To: Ori Kam; +Cc: adrien.mazarguil, yskoh, dev
On Mon, Oct 30, 2017 at 09:32:24AM +0200, Ori Kam wrote:
> When adding count action to a drop flow rule while the device was not
> stated, the counter was not saved in the flow.
>
> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> Cc: orika@mellanox.com
>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index f392f1f..3999b84 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1690,13 +1690,13 @@ struct ibv_spec_header {
> ++parser->drop_q.ibv_attr->num_of_specs;
> parser->drop_q.offset += size;
> flow->drxq.ibv_attr = parser->drop_q.ibv_attr;
> + if (parser->count)
> + flow->cs = parser->cs;
> if (!priv->dev->data->dev_started)
> return 0;
> parser->drop_q.ibv_attr = NULL;
> flow->drxq.ibv_flow = ibv_create_flow(priv->flow_drop_queue->qp,
> flow->drxq.ibv_attr);
> - if (parser->count)
> - flow->cs = parser->cs;
> if (!flow->drxq.ibv_flow) {
> rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_HANDLE,
> NULL, "flow rule creation failure");
> --
> 1.7.1
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Thanks,
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started
2017-10-30 7:41 ` Nélio Laranjeiro
@ 2017-10-31 1:41 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-31 1:41 UTC (permalink / raw)
To: Nélio Laranjeiro, Ori Kam; +Cc: adrien.mazarguil, yskoh, dev
On 10/30/2017 12:41 AM, Nélio Laranjeiro wrote:
> On Mon, Oct 30, 2017 at 09:32:24AM +0200, Ori Kam wrote:
>> When adding count action to a drop flow rule while the device was not
>> stated, the counter was not saved in the flow.
>>
>> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
>> Cc: orika@mellanox.com
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-31 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-30 7:32 [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started Ori Kam
2017-10-30 7:41 ` Nélio Laranjeiro
2017-10-31 1:41 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).