From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0079.outbound.protection.outlook.com [104.47.36.79]) by dpdk.org (Postfix) with ESMTP id 4DC9A2BF5 for ; Mon, 30 Oct 2017 10:10:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4/08YpldrzbiQgjFrsteCbcO6eqdSExGd+YjD0Gv7a8=; b=kqgHS4D+yBp66xjJ09Tl2QCym+k7Dj0AsKucSAT4qYZME7tTKrzQnxhvzq3zLmi33HF76MKAvGO+mCE9waCwF2Q4vKg0gfREZrBInQbX+2a8DvnCMhe1jXR9yPqc7Vuz8e1C/7UXZfnPSk/GxE/sg/aFOAKaVdRJFvFp46ntuVQ= Received: from jerin (14.140.2.178) by CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Mon, 30 Oct 2017 09:10:26 +0000 Date: Mon, 30 Oct 2017 14:40:12 +0530 From: Jerin Jacob To: =?iso-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20171030091011.GA26331@jerin> References: <20171028062053.6615-1-jerin.jacob@caviumnetworks.com> <20171030080654.GF10890@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171030080654.GF10890@bidouze.vm.6wind.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BMXPR01CA0018.INDPRD01.PROD.OUTLOOK.COM (10.174.214.156) To CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74f18f9e-8691-4eb7-0e76-08d51f761021 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603238); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:+u/ZzjWQImZ2y4MosQbGlWVVeeEbyJlhajOM15/l2LZ4u6GwhEEQIPJ+Bc1q9UuGzTTH1PQndhMFBchP1b59vN4A1OUWDc/9SVDxG6AsKrq9qwibb5v3ltaAVYr+x/PsOgZlh2bSV0zAY/8Noy2TqOHnZC4UQ+TK4Kq2wQ6Uo9pMER6LGACjNEyKlAU8jXO3X4U/4bAqR1LBEl+lXLlEZaUQzQ5jEITXTsR+U3aDDAzjTeoz1Qa/A51Bt1vwGA/S; 25:ERzF02AouN1zQ5RlxZKGhdsnultcBhRbeYmn8BV+fdLiDGNOlM9ynIkhsida+jCB4aVSvl/yv8UnGeVc59TaTBfSUGWGRxl06bViMqAfTumzvSjTvPjQ5hlMz86m32MTfaiRLcyYuBSKNG8w70pPAePusFb5BujPPRdw6R/G/UicAw8ZGOTz9b9F59ZChyyphLDrPrN52/tk/KhGH7+QI+3kcjZ25o0cKYC2s/hTtRo//FzpncGU0ftjOzuwRIyqlJq/wYs90n4k7M6ktINByqPTaUEtQSDEvucfGmgW8lPyJlmW6bIJWVOOGVph+MXEqcGP2i9H5R1Xkeay0ZqQUA==; 31:pCEl1/t8KpgPuZq7mwsWck3dLM9L69HzyNKdyuKlZFwz0qc87JKJRSnaeKyr+qCDjQEckIMMSWOhAzNai+KArkfVrQkXYFexeOu5TIsqTHen90EYBzzp1nPRN63kmQYQ3PKZBZl3Te7pN3oRx9iIO+YjhO5MNJhpbflsmBKkkbwc6gaX0RqSw+QKQlztWDhFwED67FxjBExczDaSw40gXYqFMZUaVGf7BMC19eXDUGo= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:xDvpj5VZgCvgUnOzzRGDB3siBxXRhlWF/RZLssp7THq5ySMI3tm1nTwpcaR4tcJhrnmEEItduRk1R1bxZ6uf9ulJgcnEmrkxqnSwF+iXlXPMa2ZxkVJicg6MKC2ZqpKZhJthNTQHKvu8ZHUeAdzDzNPqMw1QEmP+fCxMAo1wp4JDJQyu2FETBGLNMCMy5x93N7vwQsnkWEVUwpfVvICTZW2ilsIarq+KGkSbu3qlJUecTCLBObACy5DiplxoufAx/mgiYeUt992VTuK6SeggTKoiz4WUq60i3PU9g7SssHGXYFCmT8dzKLAgUxvC3QPexfm7/6sEYlRzEh9Ot8jSXUMEq07iVIZxdSkaxhifvrXcCJE6d+0lKj48Wcg4k+zidwRJr1eODXpRg//TjCgrenhQPT0k9My8v6dcTd+JMD4FX9l3dgaRZBId7FbVQWGoLruoMRJrt+5oe9NFM6uDNJED/gsFEY/Tcb8hpUUVwB0BMOZf5zEYkJ50K9+LMDIpgDBuvBAasfzDUgTj4pH+z2toM4WnWUumXjhD2yhjZ1PxWCQcpWY8/G9xVH6gd/5dkdRIZkBjo2RktmuJ+5gJAGVVdRi9xhkE/IBfXb9NULg=; 4:XAhiSSOUq8kuJXjvnA7yifEqmW6Z2J+ziBu9CyzfPXHgodBaIEwL/u0FM6UZEsV/vBY6Va6apgGvwACdPxfy9TQrXiUIpZG+drwIPxyA+SV+HV/hIsmMwbG+IGR78BZL5vVbqYDn8cFIfm85bygV7vpICRBed5PT5FVjOicAIkaVeVew9oI+r1L3hIKbo7oTcDQGdzdNbZfZkvvgWgllNCE0nCOCP5E94T6FEunworUnXl3RnCKhM267YSxqaGWBt4SM9UyvCTeePX9B9fUxbA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR07MB2518; X-Forefront-PRVS: 0476D4AB88 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(13464003)(199003)(377424004)(24454002)(189002)(51914003)(6666003)(6246003)(23756003)(2906002)(72206003)(2870700001)(189998001)(6496005)(316002)(58126008)(4326008)(229853002)(50466002)(9686003)(55016002)(478600001)(53936002)(105586002)(305945005)(7736002)(97736004)(106356001)(47776003)(54356999)(83506002)(33656002)(6916009)(2950100002)(1076002)(5009440100003)(16526018)(42882006)(68736007)(33716001)(76176999)(66066001)(81156014)(25786009)(8936002)(6116002)(3846002)(81166006)(50986999)(101416001)(5660300001)(8676002)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; CO2PR07MB2518; 23:rbyrAhpigOPRTk9Vsf7zc/dw0lkB6GxS8Ailk9q?= =?iso-8859-1?Q?B5+r3ZgBBcwfVFGBGkGbmY95FgGdFrZHYJ5JeYNN1JNzygaIq8tdahQBB7?= =?iso-8859-1?Q?hVSIjo9amZty7qqWQdzmKRx03Lw8BStzNrgkkLAkfCjGWvPRKknKxjcAPn?= =?iso-8859-1?Q?iwhFEIvfQs1rxy7SOT3AqB24OSyrI7KXAKEKJMDxBKEplIn+3ayr+Q2gsm?= =?iso-8859-1?Q?hL3yxzMkZMNOjrdYbbk7z7R75HlGlQoMaOGovMWV7krujqlU3rqODU7Bu2?= =?iso-8859-1?Q?9M6pm1yUANjX5mlnX/lzdY4+IwtKuItoqhy7qK+17E70sB+IYcEmwYhqA5?= =?iso-8859-1?Q?c1aOVfZN2WEA1qUUk17UyZUyPCK7p1E21M7+/XYFVtYz/GBBrhI8OlNq+D?= =?iso-8859-1?Q?QhPkdqI8xAdcgi8X3bh1weCuA5ZkqsOAiq6MCjcJ2NnosumziOPcPSzJ4a?= =?iso-8859-1?Q?ys8JmSA92Rvb6VngSfv2EGIGXvt52OYXSekssWZX2QRGnQXPcPC1TM1J+r?= =?iso-8859-1?Q?YP8BJ/NArgc0XM6lQtucbFtPbNvCu+9ESaYEMNOLdZgDJEYwI9JmjzCKjI?= =?iso-8859-1?Q?2iPXQ+7HbK50GbXw8BMwkcHztp6dWBAHzIpETbuWnpcNOghLbOJmpSj5AX?= =?iso-8859-1?Q?qCkeejejSZzG+lFz8R3Uk0xcC/rZ0DEPQnIGWDj9PUTJz8TbwkEn+MqTU7?= =?iso-8859-1?Q?jSE7zarw2f9B1/NN1hiEHgrhluUJtaxf6DnXr1DlVyBmnU+a8cJ8K0NNRB?= =?iso-8859-1?Q?FdUwuzesE4e9KFgrxn1IzxnXqoFlZ6shi0Lh+cGmDoXVlSV6rDwVwRgbJ9?= =?iso-8859-1?Q?TmnRValsZJIVf+nNlr1v3bjhEXartSAnWoqCOrc/ZyLY68PCkB66dX2LK3?= =?iso-8859-1?Q?WRHyryc5QG4VONf9Q3AfSZLWCDlHlADcrV7/i8BflQ0qcwlAO3nvRe9z3Q?= =?iso-8859-1?Q?H035wB9+7uzEcCADQp12aPNS+jTnSmuWTLslu9Dz+reZQvqE19Vk795hRx?= =?iso-8859-1?Q?WTseWl+XjVwPvCUF/BHRrVc5NJel4C3v69GdP/Wx80EPie2SlIbOraeubF?= =?iso-8859-1?Q?EJreWnb4X2AFZgzhUzaAAWQWadT/UFp6OLrluvCindigfoShgOXwaDGMWH?= =?iso-8859-1?Q?x/nJv8TqRfEokAmL7MB79UpS8um2s7Pi0RzUl2bWqO0NxmsTSjRB2+uf2O?= =?iso-8859-1?Q?2c2kRijjM+3VUBzgtmCys0CLJ7AqDAbJGYPSG571VrQeZW+TuoIiixZy8X?= =?iso-8859-1?Q?MwCc5a+ym1DDTZBtJcTLT+om4Ul2/FWfCu/aQjO0InW7r6xm+XHVFffq8R?= =?iso-8859-1?Q?+Ig0Ygnmu2ZyP+PffA9/may/YSbVwpLEG5N75ezaoGwQMOft0PRsQbRRrz?= =?iso-8859-1?Q?g2lrnbYjwKKhPUBQarOZffLxSj6C2?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:ABI6A/a3SzYfwHzR+pXy8/kxZp8QO3LPYOm+gUfuSImsMLyCdUhWzocp4k9yg2OETGyTyzjelcaklHVm3WxGi5cJQJyCaj9mbCcEsaRxl8XYogoqJpoZXLpgXp9YZwwYLTswKZdd8j/fYsFPL0lcI1s60DESmDo8k9HCoplCK4Ik5Zbzho9RKw+auLuDWw1HOiRx12vwbxX7r0rJJmW1fMP14EmxvuqcwuEuZmQgGhuI88Fec+VztZ9wVA/LY52Oh/h9mDv2pnPYHJnB90b05+59lALUav8HItQ2H6SjpWQ2REWQQDBeHZiLg0B2stnutAgCy0sMkGZ7Zh/MBKM8lkLmWAVZx/thMOk/55lLISo=; 5:xQmd4i+X+z4nGWAvIskYiTjvnoNpfQNq5ae3lruF2iJvkM9riAUR90VzS5Jg76BOJ31VdAnZiadpec3yhb3DG1/+mK5+76Gx7o8lbTnAo4uToOW5Axg1f1hd75vHfLfixpFclclLF0J3bJBnVKvWqVniv1Q98MzTYEzerL2u8j4=; 24:sc5s6TNr+a2rZVehyu7K+GNPlNp7PptofqTqWLMaY9QwL67sfEdt7xoOpCWYv/HvdacwaN7JntXhUP3ZZuVNOEegpb9Z8wKoFVI7rqsxuig=; 7:NeBbcKF7OGc5hpH8q0x7S4awlc7nVdIWrrO1VS3sjgJv9wr5Q6egtm187k2BUINVSFY23qCvLSStkeX3exGB+OwGSwodCsuDRDszHuiZiP4SEgu7FE5TsAhy2RFiW3FICHhCGpmmAzyQ1V45g+n2obYG+Ff5asoEBxVSROzSeXG0A3CEQv017Y1RLftK2RicFtn9L+kXJ7Hqbd69QmyJhNxeWRiS2s1/62AYqCevf/3Z7gHQVuIJw+FOmI8vMECb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2017 09:10:26.3746 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74f18f9e-8691-4eb7-0e76-08d51f761021 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 09:10:30 -0000 -----Original Message----- > Date: Mon, 30 Oct 2017 09:06:54 +0100 > From: Gaëtan Rivet > To: Jerin Jacob > Cc: dev@dpdk.org, thomas@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode > User-Agent: Mutt/1.5.23 (2014-03-12) > > Hi Jerin, Hi Gaëtan, > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: > > The definition of VFIO_PRESENT is "eal_vfio.h", Fail to > > include eal_vfio.h will result in disabling vfio. > > > > Fixes: 279b581c897d ("vfio: expose functions") > > > > Thanks for the fix, sorry for VFIO. > I tried to let go of VFIO_PRESENT in the PCI patchset, unfortunately I did > not do a good-enough job. > > Instead of reinstating the dependency on the private eal_vfio.h header, > I'd suggest replacing all VFIO_PRESENT references within the PCI bus by > RTE_EAL_VFIO, and make the pci_vfio.c compilation depend on it within > the linux Makefile. Something like: That will work. But, I think, We can push this patch as a hot fix as master is broken now.