From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 898621B2F1 for ; Mon, 30 Oct 2017 15:23:26 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id b189so16158684wmd.4 for ; Mon, 30 Oct 2017 07:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EEh3RAioE/R3ciguBhAATZgvJ8A82eritp60SnVXOJ0=; b=bwyok+K6L/seSWqu9rBAt6dnPl7kYAdfKamcq27XdxL8dIUJ40sJf+OTWhiRYIaBm+ C5IdZp3ILAfI+jO2+hZSvg2k4ThfUasBXgPu2TsuRoa8mDyu9Nxu2SeiLAm4rd/2D8i5 1uLYH0A6u4mjRiwLDo3WETXpnfToJyUkwDrNFpUyDqVFMyKWWe51wl+7pLF2iJkAs5uN WsEfLgmeny9Uw8izCXUQSW6/AWYbngsPuO2DkjmX6K9ZHY97dQWuChzEIESnp4JNEis6 Ll2jrZIz+t0dddhYqzeXWkAJzNxTYo2Z65MTZOSyfR0UQHsMUlLNVMni0zDB51HDJ99V cs7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EEh3RAioE/R3ciguBhAATZgvJ8A82eritp60SnVXOJ0=; b=h4ZQU9a/pS4rrpgRb6vZmG2nsYmTd2xpeCPzrAGBcLRNa37Mrgl2LtJJ3ZMz1GP8DP 0zRbOIGDLBbdT4b8E3Sp/7KgF/tnWK/ccv06uCQPDdGMgwIYChaoZYjTIyanoAX1wi8j pBc5TR0TWMSbTBBYwNwyCgWW6Nu89l8/Dlkl04+8lXFl76rnYEZsmyhOSnNr/boz4x4B tW9mLNHi7D3S8AfhH/zij/E/D0UvfmKIqZg0T+WhAH1n5Q2qgoReYj6z2yl+w1uOxRXF B1AhIPFe9zqYFz768jqWjnEiSXNnc47OkNScPBTBJcDrrge6+wOmYXtjZeIhCtx6wxto dZVw== X-Gm-Message-State: AMCzsaXDW7JWSEBBn9nz0C0daXI3kn6ocoOMWzNF9gIZVa0Y/Wxvbkks pYXlDO+CSyyz59mPE93p0u5Czg== X-Google-Smtp-Source: ABhQp+Qbb4bumYLJVEiQoCOfHOKTFzBS90g0Nh6T1IQg3IJhYurjENxx8FP4Uz66+7MCmoOKWKOHgA== X-Received: by 10.28.96.130 with SMTP id u124mr3973052wmb.121.1509373406300; Mon, 30 Oct 2017 07:23:26 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s21sm8884549wra.16.2017.10.30.07.23.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2017 07:23:25 -0700 (PDT) Date: Mon, 30 Oct 2017 15:23:14 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org, Ophir Munk Message-ID: <20171030142314.GX26782@6wind.com> References: <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509358049-18854-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509358049-18854-2-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v3 1/7] net/mlx4: remove error flows from Tx fast path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 14:23:26 -0000 On Mon, Oct 30, 2017 at 10:07:23AM +0000, Matan Azrad wrote: > Move unnecessary error flows to DEBUG mode. > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil I missed a couple of details while reviewing the original version, the first one being mlx4_post_send()'s return value is still documented as updating rte_errno in case of error, it's not the case anymore after this patch. Please see below for the other one: > --- > drivers/net/mlx4/mlx4_rxtx.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c > /** > @@ -510,8 +508,6 @@ struct pv { > assert(max <= elts_n); > /* Always leave one free entry in the ring. */ > --max; > - if (max == 0) > - return 0; > if (max > pkts_n) > max = pkts_n; > for (i = 0; (i != max); ++i) { While minor, this change has nothing to do with this patch, right? I think it can slightly degrade an application performance as it removes the guarantee that subsequent code only needs to be run if there is at least one packet to process in case the TX ring is constantly full (SW faster than HW). Can you remove it? -- Adrien Mazarguil 6WIND