From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 11D9B1B2F4 for ; Mon, 30 Oct 2017 15:23:42 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id y9so12777414wrb.2 for ; Mon, 30 Oct 2017 07:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vKLTdL0+jGbhxI3WgkpGsbpKy2mrqhe7p6GO4wqKqdk=; b=E1OLIL2rcZJqRhi4xkFLI35xpw8v9KWLJe/Wfma/snEVpsNFqpepkEkxP5Z1YhzNqP 3bxvL5GqLS0e0+dKdnMAjQ2nMgriNlp0YqoV5IWeKcvu04xeejTUqtNobHx8btlIKfCe rQMhUL4a9GcOfHOdGKHGYTov2DyZzqklzh4B+x0/ETXtBw1Beb2c57kfFdYpQVeMampp 0GZEgOjI6VWf+I7bkAQ6G8iQU6c6njzQhcfwVTguiMYZqZen5UatjKjaXWL/KiJ+ultA +5Iqb+utBWWWoeqtlDCK/1m6m34OyoXXnqrEupdx5nZFhFVpcdhkN5I9/23+nQGxAI/r 08WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vKLTdL0+jGbhxI3WgkpGsbpKy2mrqhe7p6GO4wqKqdk=; b=PR8V4xmPHw2x9LRg7ioQh6UYORMs6N/NEiXidqj/WkbmY9qMlpPA48/CJ2wy5D7kmk KL+/CBVXj3nt+gdmBttXBHbwf+gvW2/5xV5DAqZgZ8JXLRnUhDNN4Rh2R2DDN8zXB6eo mrF3B/Btx/DgUBRpHRN/1Ve90q7QTlSW6OtvIjrhPwUYpAGfhR8Z7LSBB1f7C66S/6lo k0xyI0IxTw3HEqqKjArjCPtdg/924fli8qYUS3sUnPmhDcyF0zcmNku4TiyCXBqwUPsU jSNJvm1pcX2LiReI7a+frrT/t2YqPW2AhNpF96kpTsS59KRMmD4mR/iW4zo+1wXcl4Vu sKgA== X-Gm-Message-State: AMCzsaW0SFM1LKohkaX8mR8IavFlAkCFCFvw0NIvNJf55BLfpwAqyXZZ 6xmLXtwAIQPArtB2D40OxJOo8Q== X-Google-Smtp-Source: ABhQp+T8VHfTwXxZ5M9ko4iWEj9lVKidp587T8ejZ56QGRyhPeOKoX3I0W/cgNQiNpoi3eB0F/nu3g== X-Received: by 10.223.130.225 with SMTP id 88mr7928864wrc.6.1509373421897; Mon, 30 Oct 2017 07:23:41 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o24sm3336223wmi.39.2017.10.30.07.23.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2017 07:23:41 -0700 (PDT) Date: Mon, 30 Oct 2017 15:23:30 +0100 From: Adrien Mazarguil To: Matan Azrad Cc: dev@dpdk.org, Ophir Munk Message-ID: <20171030142330.GZ26782@6wind.com> References: <1508768520-4810-1-git-send-email-ophirmu@mellanox.com> <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509358049-18854-4-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509358049-18854-4-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 14:23:42 -0000 On Mon, Oct 30, 2017 at 10:07:25AM +0000, Matan Azrad wrote: > Merge tx_burst and mlx4_post_send functions to prevent > double asking about WQ remain space. > > Signed-off-by: Matan Azrad Except for one nit below, Acked-by: Adrien Mazarguil > --- > drivers/net/mlx4/mlx4_rxtx.c | 357 +++++++++++++++++++++---------------------- > 1 file changed, 172 insertions(+), 185 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c > @@ -477,18 +314,168 @@ struct pv { > } while (tmp != NULL); > } > RTE_MBUF_PREFETCH_TO_FREE(elt_next->buf); > - /* Post the packet for sending. */ > - err = mlx4_post_send(txq, buf); > - if (unlikely(err)) { > + Extra empty line. -- Adrien Mazarguil 6WIND